[Resolved] Passing PHP variabels to next page?

[Tim_L]

Hi,

I've got a page with prouct info on it. The same page also has a recordset of variables.

I've got a button which has been written using php something like:

<? print"<a href=\"write_review.php?PID=$product_id\">img etc...?>

This passes the product ID to the next page so that I can use it! How would I pass another variable too? using the same button?

Many thanks...

[LordShryku]

If you have the variable already, put it in the url on the button.

<? echo "<a href=\"write_review.php?PID=".$product_id."&var2=".$var2."\">img etc...?>

[Tim_L]

Thanks so much for your reply!

The code you've given me is correct but when I implement it with the correct variable names etc, variable 2 is empty.

However, I've already got:

$product_id = $_GET['PID']; 
$product_title = $_GET['title'];

at the top of the page.

When I click on the button it gives me:

http://www.blah.com/blah.php?PID=CORRECTPID&title=

Title doesn't seem to be getting the variable??? Not sure what I'm doing wrong?

[GreyBoy]

Is the second variable given a value prior to printing the link???

Can you show us your code??? There are several reasons why that can happen.

[Tim_L]

Yes, the 2nd variable is given a value before the link is printed and is displayed above the link button correctly!

This is my button code:

<? echo "<a href=\"write_review.php?PID=".$product_id."&title=".$product_title."\"><img src=\"..\images\button_reviewprod.gif\" alt=\"Review Product\" width=\"90\" height=\"19\" border=\"0\"></a>"; ?>

Code for correctly displayed title:

<?php echo $row_rs_products['title']; ?>

My recordset details:

<?php
$product_id = $_GET['PID']; 
$product_title = $_GET['title'];

$colname_rs_products = "1";
if (isset($HTTP_GET_VARS['PID'])) {
  $colname_rs_products = (get_magic_quotes_gpc()) ? $HTTP_GET_VARS['PID'] : addslashes($HTTP_GET_VARS['PID']);
}
mysql_select_db($database_razordicom, $razordicom);
$query_rs_products = sprintf("SELECT * FROM products WHERE PID = %s", $colname_rs_products);
$rs_products = mysql_query($query_rs_products, $razordicom) or die(mysql_error());
$row_rs_products = mysql_fetch_assoc($rs_products);
$totalRows_rs_products = mysql_num_rows($rs_products);

mysql_select_db($database_razordicom, $razordicom);
$query_rs_reviews = "SELECT * FROM reviews WHERE PID=$product_id";
$rs_reviews = mysql_query($query_rs_reviews, $razordicom) or die(mysql_error());
$row_rs_reviews = mysql_fetch_assoc($rs_reviews);
$totalRows_rs_reviews = mysql_num_rows($rs_reviews);

?>

[Tim_L]

Any ideas?

[GreyBoy]

Ok, I think I might have found your problem.

In your button link:

<? echo "<a href=\"write_review.php?PID=".$product_id."&title=".$product_title."\"><img src=\"..imagesbutton_reviewprod.gif\" alt=\"Review Product\" width=\"90\"

dont use \" before and after the variables.

So, instead it would look like:

<? echo "<a href=write_review.php?PID=".$product_id."&title=".$product_title."><img src=\"..imagesbutton_reviewprod.gif\" alt=\"Review Product\" width=\"90\" height=\"19\" border=\"0\"></a>"; ?>

I was having a similar problem, and that fixed it.

[Tim_L]

Nope that didn't work either???😕

[Norman_Graham]

I'm not surprised it didn't work, Tim L. PHP recognises a string or value as beginning with either ' or ". As soon as either ' or " are encountered again, the string is assumed to be finished. You HAVE to escape ' and " if they are intended as such and not as demarcation marks. You CAN use ' inside the string if it's demarcated by ", and vice versa, but what GreyBoy is suggesting will not work.

Incidentally, using non-quoted attributes and values in HTML is very bad practice and it'll catch up with you one of these days.

 <?php echo "<a href=\"write_review.php?PID=" . $product_id . "&title=". $product_title . "\">
<img src=\"./imagesbutton_reviewprod.gif\" alt=\"Review Product\" width=\"90\" height=\"19\" border=\"0\">
</a>"; ?>

For collation, I suggest using a space before and after the point. I don't know if this is entirely necessary, but I suspect it might be. It sure as hell makes things easier to read.

HTH

Norm

[Tim_L]

Thanks Norm - I also thought that regarding what GreyBoy said but I thought I may as well give it a go!