damn parse errors

daf_cr

okay, i keep getting the parse error:
Parse error: parse error, unexpected $end in e:\apache\htdocs\dafsplacev2\bin\counter.inc.php on line 44

I dont have a clue why, but i do know when i include anotherone it gives me this error:
Parse error: parse error, unexpected '}' in e:\apache\htdocs\dafsplacev2\bin\counter.inc.php on line 43

This is really annoying me as i cant figure it out! The script is for a counter with mysql tables dp_counter and dp_count, dp_counter keeps the ip with visit number, dp count just stores the amount of visits. Another Question, how do you color the code without going through each bit painstakingly coloring each bit?

<?php
include("config.inc.php");
include("vars.inc.php");
##################

Show Counter

##################
$sql1 = "SELECT count FROM dp_count WHERE row = 1";
$result1 = mysql_query($sql2)
or header("Location: ../index2.php?page=error&error=5");
while ($row1 = mysql_fetch_array($result1,MYSQL_ASSOC)) // line 10 //
{ // open brackets 1 //
extract($row2);
} // close brackets 1 //
##############

Check IP

##############
$sql = "SELECT * FROM dp_counter WHERE counterIP='$SERVER[REMOTE_ADDR]'";
$result = mysql_query($sql)
or header("Location: ./index2.php?page=error&error=5");
$num = mysql_num_rows($result); // line 20 //
if ($num) { // open brackets 2 //
// ip found //
$ip = "found";
} // close brackets 2 //
else { // open brackets 3 //
mysql_query("INSERT INTO dp_counter VALUES
counterIP = '$SERVER[REMOTE_ADDR]'")
or header("Location: ./index2.php?page=error&error=5");
$counter++;
mysql_query("UPDATE dp_count SET count = '$counter' WHERE row = 1") // line 30 //
or header("Location: ./index2.php?page=error&error=5");
##################

Show Counter

##################
$sql2 = "SELECT count FROM dp_count WHERE row = 1";
$result2 = mysql_query($sql2)
or header("Location: ./index2.php?page=error&error=5");
while ($row2 = mysql_fetch_array($result2,MYSQL_ASSOC))
{ // open brackets 4 //
extract($row2); // line 40 //
} // close brackets 4 //
} // close brackets 3 //

Thanks for any effort made as its a tough one,

Daf.

Merve

Why do you need MySQL to make a counter? It's so much easier to make one with just an external file.

You get the funky colors by typing (PHP)and then the code and then closing it with (/PHP) but substitute the normal brackets for rectangular brackets. I didn't type rectangular brackets because that would have taken the tags out of the message.

example:

<?php
phpinfo();
?>

buck2bcr

I don't have an answer yet, I just wanted to put your code in a easier to read format.

One thing that I do see right off the bat is on line 8 you haven't defined $sql2 yet and you are trying to run it in the mysql query.

When running the code on my local as is I don't get a parse error. You may want to check your include files.

HTH

Originally posted by daf_cr

<?php
include("config.inc.php");
include("vars.inc.php");
##################
## Show Counter ##
##################
$sql1 = "SELECT count FROM dp_count WHERE row = 1";
$result1 = mysql_query($sql2)
	or header("Location: ../index2.php?page=error&error=5");
	while ($row1 = mysql_fetch_array($result1,MYSQL_ASSOC))				// line 10 //
		{																// open brackets 1 //
		extract($row2);
	}																	// close brackets 1 //
##############
## Check IP ##
##############
$sql = "SELECT * FROM dp_counter WHERE counterIP='$_SERVER[REMOTE_ADDR]'";
$result = mysql_query($sql)
	or header("Location: ./index2.php?page=error&error=5");
$num = mysql_num_rows($result);											// line 20 //
if ($num) {																// open brackets 2 //
	// ip found //
	$ip = "found";
	}																	// close brackets 2 //
else {																	// open brackets 3 //
	mysql_query("INSERT INTO dp_counter VALUES
					counterIP = '$_SERVER[REMOTE_ADDR]'")
		or header("Location: ./index2.php?page=error&error=5");
	$counter++;
	mysql_query("UPDATE dp_count SET count = '$counter' WHERE row = 1")	// line 30 //
		or header("Location: ./index2.php?page=error&error=5");
##################
## Show Counter ##
##################
	$sql2 = "SELECT count FROM dp_count WHERE row = 1";
	$result2 = mysql_query($sql2)
		or header("Location: ./index2.php?page=error&error=5");
		while ($row2 = mysql_fetch_array($result2,MYSQL_ASSOC))
			{															// open brackets 4 //
			extract($row2);												// line 40 //
			}															// close brackets 4 //
		}																// close brackets 3 //

?>

daf_cr

<?php
include("config.inc.php");
include("vars.inc.php");
##################
## Show Counter ##
##################
$sql1 = "SELECT count FROM dp_count WHERE row = 1";
$result1 = mysql_query($sql1)
	or header("Location: ../index2.php?page=error&error=5");
	while ($row1 = mysql_fetch_array($result1,MYSQL_ASSOC))
		{
		extract($row2);
	}
##############
## Check IP ##
##############
$sql = "SELECT * FROM dp_counter WHERE counterIP='$_SERVER[REMOTE_ADDR]'";
$result = mysql_query($sql)
	or header("Location: ./index2.php?page=error&error=5");
$num = mysql_num_rows($result);
if ($num) {
	// ip found //
	$ip = "found";
	}
else {
	mysql_query("INSERT INTO dp_counter VALUES
					counterIP = '$_SERVER[REMOTE_ADDR]'")
		or header("Location: ./index2.php?page=error&error=5");
	$counter++;
	mysql_query("UPDATE dp_count SET count = '$counter' WHERE row = 1")
		or header("Location: ./index2.php?page=error&error=5");
##################
## Show Counter ##
##################
	$sql2 = "SELECT count FROM dp_count WHERE row = 1";
	$result2 = mysql_query($sql2)
		or header("Location: ./index2.php?page=error&error=5");
		while ($row2 = mysql_fetch_array($result2,MYSQL_ASSOC))
			{
			extract($row2);
			}
			}						
?>

ok, now i get:
Warning: extract(): First argument should be an array in e:\apache\htdocs\dafsplacev2\bin\counter.inc.php on line 12
😕

Daf.

buck2bcr

You are trying to extract $row2 in line 12 and you haven't declared $row2 as an array. In the prior statement you have declared $row1.

Originally posted by daf_cr

ok, now i get:
Warning: extract(): First argument should be an array in e:\apache\htdocs\dafsplacev2\bin\counter.inc.php on line 12
😕

Daf.

daf_cr

ok, its all sorted now! the reason why i didnt use a mysql counter was cos its for my a-level project, and i need substence!! cheers for the help guys, much appreitiated!

Daf.