Function

[benson]

Hello,
I'm trying to learn PHP.
So i thought let's make some unuseful things.
So this is not very important.

I made this script but it seems to have some troubles.

<?php
function show($string,$key)
{
$repl = "";
	while ($i < strlen($string))
	{
		$alph=array(1 => 'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X', 'Y', 'Z');
		$lengts=strlen($string);
		$lengtk=strlen($key);
		if($lengts > 26)
			{
			$lengts = $lengts - $lengtk * 2;
		if($lengts < 0)
			{
			$lengts = $lengts + $lengtk;
			}
			}
		if($lengtk > 26)
			{
			$lengks = $lengtk - $lengts * 2;
			if($lengtk < 0)
				{
				$lengtk = $lengtk + $lengts;
				}
			}
		$repl=strtolower(str_replace($alph[$lengts], $alph[$lengtk], $string));
	$i= $i++;
	}
echo $repl."<br>De lengte string ".$lengts." = ".$alph[$lengts]."<br>De lengte key ".$lengtk." = ".$alph[$lengtk]."<br>".$error;
}
$str=strtoupper($_GET['string']);
$key=strtoupper($_GET['key']);
echo $_GET['string']."<br>";
show($str,$key);
?>

[paulnaj]

What might they be?

[benson]

Just trying to scramble a sentence with the help of itself and a key.
Firstly i had it different so there are some stupid things.

But when i execute this it takes too much time.

so if you or somebody want to look at it please.

[laserlight]

You'll have to explain your scambling algorithm.
Also, if you have encryption in mind, then it is better to use strong encryption than to try and come up with something yourself, unless you are a crypto expert.

However, from a hacker's point of view, one reason why your script takes too long is that it is inefficient.

You should take out evaluation of strlen() and declaration of the array out of the loop.

[benson]

Got it to work.
And laserlight, my aim of this script was only to learn more about the language i'm not going to use it i just want to learn arrats loops and some functions.

Thnx..