[Resolved] File Upload -> Save problem

[DeadlySin3]

Hello

Gotta quick question about a file upload script.

When I go to save it uploaded file, it's saved only as "fupload", it doesn't save w/the actual file name like I thought it would.

Anyone have any ideas as of why?

here's the code:

<?php
// blogItUploaderVars.inc.php
/*
 *  Maximum Size an image may be
 *
 *  $maxImageSize
 *
 *  51200 = 50 KB
 *
 */

$maxImageSize = "51200"; 

/*
 *  Path Information
 *
 *  1.) $file_dir
 *
 *  1.)$file_url
 *
 *  1.) full path ex /home/user/public_html/img
 *
 *  2.) full url ex http ://www.site.com/img
 *
 *  NO TRAILING SLASH!!
 *
 */

$file_dir = "/home/mydir/public_html/img";
$file_url = "http://www.site.net/img";

?>

<?php
// upLoadform.php
<?php include("blogItUploaderVars.inc.php");

foreach( $HTTP_POST_FILES as $file_name => $file_array ) 
{
echo "path: ".$file_array['tmp_name']."<br />\n";
echo "name: ".$file_array['name']."<br />\n";
echo "type: ".$file_array['type']."<br />\n";
echo "size: ".$file_array['size']."<br />\n";

if(is_uploaded_file( $file_array['tmp_name'] )
 && $file_array['type'] == "image/gif" )
{
move_uploaded_file( $file_array['tmp_name'], "$file_dir/$file_name")
or die("Couldn't Copy");
echo "<img src=\"$file_url/$file_name\"><br />\n\n";
} // End IF statement

} // End Foreach loop

?>

<form enctype="multipart/form-data" method="POST">
<input type="hidden" name="MAX_FILE_SIZE" value="<?php echo $maxImageSize; ?>">
<input type="file" name="fupload">
<br /><br />
<input type="submit" value="Upload">
<br />
</form>

[DeadlySin3]

If it helps.. everything is displayed properly.

tmp_name
name
type
size

all display right.

even displaying the image w/this code works

<?php
echo "<img src=\"$file_url/$file_name\"><br />\n\n";
?>

When I look at the source code, the $filename being referenced is "fupload" - no extension - and the image still shows up.

Either way i'm still boggled as to why I can't save .gif images with their original file name using the above script.

Any and all help on this matter is greatly appreciated!

-DeadlySin3

[DeadlySin3]

Well, should the above code work? It sure looks to me like it should!

[helz]

seems like its displaying the name of the field instead of the value...
add a line below the size one:
$file_name = $_POST['fupload'];

==edit==
still no idea why the image works but the upload doesnt

can you check the source of the image to see what the filename is...

i have an incling that its:
dir/fupload

[DeadlySin3]

The upload does work; it's just saving the $file_name as "fupload"

My question is why isn't it saving it as the original file name?

You said I should add this line:
$file_name = $_POST['fupload'];

But I think that would add a conflict; due to this line here:
foreach( $HTTP_POST_FILES as $file_name => $file_array )

As i've said before, everything works properly, and the image displays; but it's name is fupload every time.. i'd like to keep the original file name!

[helz]

the image is being shown because its opening the file fupload as a file. its using the name of the form field instead of its value...

[DeadlySin3]

o.O

after playing w/the script for while more, i finally got it to work right!

Thanks guys:

here's the final code

<?php
<?php 
include("blogItUploaderVars.inc.php");
foreach( $HTTP_POST_FILES as $file_name => $file_array ) 
{
echo "path: ".$file_array['tmp_name']."<br />\n";
echo "name: ".$file_array['name']."<br />\n";
echo "type: ".$file_array['type']."<br />\n";
echo "size: ".$file_array['size']."<br />\n";


if(is_uploaded_file( $file_array['tmp_name'] ) && $file_array['type'] == "image/gif" )
{
move_uploaded_file( $file_array['tmp_name'], "$file_dir/".$file_array['name'])
or die("Couldn't Copy");
echo "<img src=\"$file_url/".$file_array['name']."\">";
echo "<br />\n\n";
} // End IF statement

} // End Foreach loop

?>

<form action="<?php echo "$self"; ?>" enctype="multipart/form-data" method="POST">
<input type="hidden" name="MAX_FILE_SIZE" value="<?php echo $maxImageSize; ?>">
<input type="file" name="fupload">
<br /><br />
<input type="submit" value="Upload">
<br />
</form>