Sign-Up Script Problem

Napster

I have this thing in my script so that it will not let multipul people have the same username. It is

$result2 = mysql_query("select count(*) as num_users FROM members WHERE username='$username'"); 
$row = mysql_fetch_array($result2,MYSQL_ASSOC);

and then later in the script I have

elseif ($row[num_users] > 0)
{
echo "That username is already used";
}

But that does not work, a lot of people can have the same username. How do I fix this?

examancer

maybe you just mistyped it here, but should the last part look like this:

if ($row["num_users"] > 0)
{
echo "That username is already used";
}

Napster

i did not mistype it. i copied and pasted it from my script, so If i add the " and the " it should work?

examancer

i would think so, unless there is another problem

Napster

it still doesn't work, but i will post my whole php script

<?php

include("colours.inc.php");
include("jocey.inc.php");

$connection = mysql_connect($host,$user,$password)
  or die ("Couldn't connect to the database");
mysql_select_db($database, $connection)
  or die ("Couldn't select database");

$result2 = mysql_query("select count(*) as num_users FROM members WHERE username='$username'"); 
$row = mysql_fetch_array($result2,MYSQL_ASSOC); 

$username = strip_tags(trim($first));
$password1 = strip_tags(trim($last));
$password2 = strip_tags(trim($last2));
$email = strip_tags(trim($email1));

if ($row["num_users"] > 0)
{
echo "That username is already used";
}
elseif ($username == "")
{
echo "Username is blank";
}
elseif (!ereg("[A-Za-z1-9_ -]{3,20}",$username)) 
{
echo "Username is not in a valid format";
}
elseif ($row["num_users"] > 0)
{
echo "That username is already used";
}
elseif ($password1 == "")
{
echo "The first password field is blank";
}
elseif ($password2 == "")
{
echo "The second password field is blank";
}
elseif (!ereg("[A-Za-z1-9_ -]{3,20}",$password1)) 
{
echo "The first password is not in a valid format";
}
elseif (!ereg("[A-Za-z1-9_ -]{3,20}",$password2)) 
{
echo "The second password is not in a valid format";
}
elseif ($password1 != $password2)
{
echo "The passwords are not the same";
}
elseif ($email == "")
{
echo "Email is blank";
}
elseif (!ereg("[A-Za-z1-9_@.-]{3,20}",$email)) 
{   //50
echo "Email is not in a valid format";
}
elseif ($sex == "")
{
echo "Are you Male or Female?";
}
elseif ($race == "")
{
echo "What is your race?";
}//60
elseif ($profession == "")
{
echo "What is your class?";
}
elseif ($row[num_users] > 0)
{
echo "That username is already used";
}
elseif ($username == blah)
{
echo "You can not use that username";
}
else
{

$query = "INSERT INTO members (username,password,email,race,sex,exp,level,money,profession) VALUES ('$username','$password2','$email','$race','$sex','0','1','90','$profession')";
$result = mysql_query($query) or die (mysql_error());

mail("$email", "Welcome to Elarune", "Hi and welcome to Elarune, you personal information is as follows 

Username: $username 
Password: $password2  

           The Elarune Staff");

echo "You have been successfully signed up<br><a href='index.php'>Go Home</a>";
}


?>

Thank you

examancer

Make this change to your query lines to check for any error... It looks like your defining the $username variable AFTER you use it in a query:

// change these lines:
$result2 = mysql_query("select count(*) as num_users FROM members WHERE username='$username'"); 
$row = mysql_fetch_array($result2,MYSQL_ASSOC);  

// to this:
$result2 = mysql_query("select count(*) as num_users FROM members WHERE username='$username'"); 
if (!$result2) { // if the query fails:
  echo("Problem executing MySQL query: " . mysql_error));
}
$row = mysql_fetch_array($result2,MYSQL_ASSOC);

Napster

ok so i changed it and it now looks like

$result2 = mysql_query("select count(*) as num_users FROM members WHERE username='$username'");  

if (!$result2) { 
  echo("Problem executing MySQL query: " . mysql_error()); 
} 
$row = mysql_fetch_array($result2,MYSQL_ASSOC);

but it still doesn't work, it wont count the things to make sure there is only 1 of that username. Is there any other way of checking to see if the username is already being used

Napster

Does anybody know what is wrong with it

Nixon

Here is the code for my signup form. Very similar to yours.


<?php

include ("connectdb.inc.php");

$date = date ("dmY"); 

//Check if any of the fields were blank

if ($username == NULL) { die ("Please fill in the username field"); }
if ($password1 == NULL) { die ("Please fill in the first password field"); }
if ($password2 == NULL) {die ("Please fill in the second password field"); }
if ($email == NULL) { die ("Please fill in the email field"); }
if ($outwarlink == NULL) { die ("Please fill in the Outwar Link field"); }
if ($outwarusername == NULL) { die ("Please fill in the Outwar Username field"); }
if ($ques1 == NULL) { die ("Please fill in the question fields"); }
if ($ques2 == NULL) { die ("Please fill in the question fields"); }
if ($ques3 == NULL) { die ("Please fill in the question fields"); }


$outwarlinksub=substr($outwarlink,0,4);

if ($outwarlinksub == http) {} else { die ("Please start your outwar link [url]http://www.outwar.com/page.php?x=........[/url]"); }

if ($password1 == $password2) { } else {die ("Sorry your 2 password fields did not match"); }

//Check if username has already been used

$table=outwarinfo;

$finduser=mysql_query( "select * from outwarinfo where username=\"$username\" ");
$findusershow=mysql_num_rows( $finduser );

$findlink=mysql_query( "select * from outwarinfo where outwarlink=\"$outwarlink\" ");
$findlinkshow=mysql_num_rows( $findlink );

if ( $findusershow == "1" ) { die("Sorry this username is already being used"); }

if ( $findlinkshow =="1" ) { die("Sorry this link is already being used"); }

?>

Napster

Why would mine not be working

ofSHIZ

Do you think that the table you put to insert to.. "members" is the same as the MySQL table? Is your database correct? Just.. checking..