I hate variables... so should you

[Shawazi]

This code works great for input types = "text". I actually got it from someone off this forum.

 if(!isset($_POST['selist'][$numb]))    $_POST['selist'][$numb] = ""; 
    $selist = "selist[".$numb."]";  

      echo " <select name='".$selist."'> "; 

If it were text id have the value= $_POST['selist'][$numb]

The problem is in a selection list. The options are set up like this:

<option value='$subgenrows[subgenreid]'>$subgenrows[subgenreid] $subgenrows[title] by $subgenrows[artist]</option>"

Now when you hit submit and go to the next page

$thisnumber = $_POST['selist'][$numb];

You would think that $thisnumber would be the value of the option but it gives me the name of the selection list. It does the same if i set $thisnumber equal to $selist it just says "Array"

Where is the PHP noob (me) messing up? Thx

[Weedpacket]

What does the select tag look like?

[Shawazi]

I fooled around with the code more before giving up but here it is

while ($subrows = mysql_fetch_array($subres)) // puts the subgenres id and name into array
					{


			$numb = $subrows[id];
			echo "<tr><td>Select a Featured Album from $subrows[name]</td></tr>
		<tr><td>";
		  $picklist = "thelist_$numb";
  echo "$picklist<select name='".$picklist."'> "; 
				echo" <option value=''></option><option value=''>No Album</option>";
	$subgenres = mysql_query("select * from cds where subgenreid='$subrows[id]' ORDER BY title");
	while ($subgenrows = mysql_fetch_array($subgenres))
		{
		echo "<option value='$subgenrows[subgenreid]'"; if ($subgenrows[featured] == "yes") { echo " selected "; }
echo ">$subgenrows[subgenreid] $subgenrows[title] by $subgenrows[artist]</option>";
			}
		echo "</select></td><td><input type='hidden' name='subnum' value='$subnum'>";

		echo"<input type='submit' name='featsubmit' value='Select Featured Album for $subrows[name]'></td></tr>";
		}

Then the second page is

$numb = 1;
		while ($numb <=	$subnum)
			{
			$picklist = "thelist_$numb";
					$thisnumber = $_POST[$picklist];
					if ($thisnumber !="")
				{
				echo "$shazam<br>";
				$newquery = "select * from cds where id='$thisnumber'";
				echo "$newquery<br>";
				$newres = mysql_query($newquery) ;
				$newrow = mysql_fetch_array($newres) ;
				echo "The newrow subgenreid is $newrow[subgenreid]<br>The newrow id  is $newrow[id]<br>";
				mysql_query("update cds set featured='no' where subgenreid='$newrow[subgenreid]'") ;
				mysql_query("update cds set featured='yes' where id='$newrow[id]'") ;
				$catres = mysql_query("select * from subgenres where id='$newrow[subgenreid]'") ;
				$catrow = mysql_fetch_array($catres) ;
				echo "$newrow[title] by $newrow[artist] is now featured in $catrow[name]<br>";

					}
		$numb++;

No matter what I've tried it just gives me 9, which is the value of
thelist_$numb (being as 9 is the 9th category and the one i've been selecting from the list).

[Weedpacket]

Okay, so you've got <select> tags named thelist_1, thelist_2, and so on. Judging from what I can see, the values of $POST['thelist_1'], $POST['thelist_2'], and so on will be the subgenre ID for the album selected. I take it this isn't what you want?

Incidentally, calling the <select> tags thelist[1], thelist[2], etc., would make the processing step easier (and more robust):

Page 1:

while ($subrows = mysql_fetch_array($subres)) // puts the subgenres id and name into array
{	$numb = $subrows['id'];
	echo "<tr><td>Select a Featured Album from $subrows[name]</td></tr>
<tr><td>";
	$picklist = "thelist[$numb]";
	echo "$picklist<select name='$picklist'> "; 
	echo" <option value=''></option><option value=''>No Album</option>";
	$subgenres = mysql_query("select featured,title,artist from cds where subgenreid='$subrows[id]' ORDER BY title");
	while ($subgenrows = mysql_fetch_array($subgenres))
	{	echo "<option value='$subrows[id]'"; if ($subgenrows['featured'] == "yes")
		{	echo " selected ";
		}
		echo ">$subrows[id] $subgenrows[title] by $subgenrows[artist]</option>";
	}
	echo "</select></td><td><input type='hidden' name='subnum' value='$subnum'>";
	echo"<input type='submit' name='featsubmit' value='Select Featured Album for $subrows[name]'></td></tr>";
}

and page 2:

foreach($_POST['thelist'] as $thisnumber)
{	echo "$shazam<br>";
	$newquery = "select * from cds where id='$thisnumber'";
	echo "$newquery<br>";
	$newres = mysql_query($newquery) ;
	$newrow = mysql_fetch_array($newres) ;
	echo "The newrow subgenreid is $newrow[subgenreid]<br>The newrow id  is $newrow[id]<br>";
	mysql_query("update cds set featured='no' where subgenreid='$newrow[subgenreid]'") ;
	mysql_query("update cds set featured='yes' where id='$newrow[id]'") ;
	$catres = mysql_query("select * from subgenres where id='$newrow[subgenreid]'") ;
	$catrow = mysql_fetch_array($catres) ;
	echo "$newrow[title] by $newrow[artist] is now featured in $catrow[name]<br>";
}                

[Shawazi]

I DO want it to give me the subgenre ID. Using arrays or using list_$numb is still giving me the select name thelist_1, thelist_2, etc instead of their values in the options. You would think that would only happen with arrays but apparently it's not

[Najjar]

Use the same code its fine but name the select statment with brakets like this:

if(!isset($POST['selist'][$numb])) $POST['selist'][$numb] = "";

// $selist = "selist[".$numb."]";

echo " <select name='$selist[]'> ";

This should do it... 🙂

if not let me know please.

[Shawazi]

There are two codes I've tried. My last post was about the one without arrays. This one is to Najjar who helpd with the array code. I get this error:

parse error, unexpected ']', expecting T_STRING or T_VARIABLE or T_NUM_STRING in

<select name='$selist[]'> is not valid

[Najjar]

I am sorry man...
Just take out the $ sign from the array

Like this:

<select name='sellist[]'>

🙂

[Shawazi]

It does just what it did before. It is giving me 9... the value of the name - not the value of the selected option

[Najjar]

Can you send me your code so I can look at it...

because I am using this in all my codes!!!!!

[Shawazi]

Here is the main section, below it i will put the form

if ($featform == "yes")
{
	if ($featsubmit == "Select Featured Artist")
		{
			mysql_query("update users set featured='no'");
			mysql_query("update users set featured='yes' where username='$art'");
			echo "$art is now the Featured Artist.<br>";
			include("selfeatart.php");
		}
	if ($featsubmit == "Select Genre")
		{
			include("selfeatart.php");
		}
	if (ereg("^Select Featured Album for ", $featsubmit))
		{
		$numb = 1;
		while ($numb <=	$subnum)
			{
			$thisnumber = $_POST['selist'][$numb];
					if ($thisnumber !="")
				{
				$newquery = "select * from cds where id='$thisnumber'";
				echo "$newquery<br>";
				$newres = mysql_query($newquery) ;
				$newrow = mysql_fetch_array($newres) ;
				echo "The newrow subgenreid is $newrow[subgenreid]<br>The newrow id  is $newrow[id]<br>";
				mysql_query("update cds set featured='no' where subgenreid='$newrow[subgenreid]'") ;
				mysql_query("update cds set featured='yes' where id='$newrow[id]'") ;
				$catres = mysql_query("select * from subgenres where id='$newrow[subgenreid]'") ;
				$catrow = mysql_fetch_array($catres) ;
				echo "$newrow[title] by $newrow[artist] is now featured in $catrow[name]<br>";

					}
		$numb++;
		}

	include("selfeatart.php");
	}




}

The form is

$artres = mysql_query("select id, featured, username from users");
echo "
<form method='post' action='$php_self?featform=yes'>
<table>

<tr><td>
<select name='art'><option value='-No-Artist-'>No Artist</option>";
while ($artrow = mysql_fetch_array($artres))
{
echo "<option value='$artrow[username]'"; if ($artrow[featured] == "yes") { echo " selected "; }
echo ">$artrow[username]</option>";
}
echo "</select></td>
<td><input type='submit' name='featsubmit' value='Select Featured Artist'></td>
</tr>";
echo "<tr><td>Select a genre to get subgenres for Featured Albums</td></tr>
<tr><td><select name='maingenres'><option value='No Genre'>No Genre</option>";
$genres = mysql_query("select * from maingenres ORDER BY name");
while ($genrows = mysql_fetch_array($genres))
	{
		echo "<option value='$genrows[id]'>$genrows[name]</option>";
	}
echo "</select></td><td><input type='submit' name='featsubmit' value='Select Genre'></td></tr>";

if ($maingenres != "" and $maingenres != "No Genre")
	{
		$subres = mysql_query("select * from subgenres where maingenreid='$maingenres'"); //maingenre defined elsewhere
		$subnum = mysql_num_rows($subres);
		while ($subrows = mysql_fetch_array($subres)) // puts the subgenres id and name into array
					{
// HERE IS THE SECTION ON THE FORUM 				

			$numb = $subrows[id];
			echo "<tr><td>Select a Featured Album from $subrows[name]</td></tr>
		<tr><td>";
		if(!isset($_POST['selist'][$numb])) $_POST['selist'][$numb] = ""; 
// $selist = "selist[".$numb."]"; 
echo " <select name='selist[]'> "; 

				echo" <option value=''></option><option value=''>No Album</option>";
	$subgenres = mysql_query("select * from cds where subgenreid='$subrows[id]' ORDER BY title");
	while ($subgenrows = mysql_fetch_array($subgenres))
		{
		echo "<option value='$subgenrows[subgenreid]'"; if ($subgenrows[featured] == "yes") { echo " selected "; }
echo ">$subgenrows[subgenreid] $subgenrows[title] by $subgenrows[artist]</option>";
			}
		echo "</select></td><td><input type='hidden' name='subnum' value='$subnum'>";

		echo"<input type='submit' name='featsubmit' value='Select Featured Album for $subrows[name]'></td></tr>";
		}
}
echo "</table></form>";

Thanks

[Najjar]

First - did you test the value of ($subgenrows[subgenreid])
inside the loop like this:

while ($subgenrows = mysql_fetch_array($subgenres))
{
// HERE
echo $subgenrows[subgenreid];

echo "<option value='$subgenrows[subgenreid]'>
$subgenrows[subgenreid] $subgenrows[title] by $subgenrows[artist]</option>";
}

and take the if statment out it might coz a problem like skipping values.
the best thing to do is to have the if statment out side
and creat a variable with the value "selected" if YES and NULL ""
if NO.

Then test the select statement buy it self and what values its giving you directly from the database.

do these things step by step and test every time this way if it works you can tell what was the problem
Let me know

[Shawazi]

I figured it out. I was being quite stupid. I should have had subgenrow[id] instead of subgenrow[subgenreid]. All school work and programming has gotten to my brain so it's time for Dynasty Warriors.

[Najjar]

Thats great..... 🙂

[Shawazi]

It turns out it WAS skipping variables though. I made the change you said to and it still won't work.

The changes:

while ($subgenrows = mysql_fetch_array($subgenres))
			{
			if ($subgenrows[featured] == "yes") 
				{ 
				$mselect = " selected "; 
				} 
			echo "<option value='$subgenrows[id]' '$mselect'>$subgenrows[title] by $subgenrows[artist]</option>";
			}

The other part:

$numb = 1;
		while ($numb <=	$subnum)
			{
			$thisnumber = $_POST['selist'][$numb];
					if ($thisnumber !="" and (!ereg("^hi", $thisnumber)))
				{
				echo "thisnumber is not blank and it does not begin with hi<br>";
				$newquery = "select * from cds where id='$thisnumber'";
				$newres = mysql_query($newquery) ;
				$newrow = mysql_fetch_array($newres) ;
				mysql_query("update cds set featured='no' where subgenreid='$newrow[subgenreid]'") ;
				mysql_query("update cds set featured='yes' where id='$newrow[id]'") ;
				$catres = mysql_query("select * from subgenres where id='$newrow[subgenreid]'") ;
				$catrow = mysql_fetch_array($catres) ;
				echo "$newrow[title] by $newrow[artist] is now featured in $catrow[name]<br>";
				}
					else
					{
					echo "then it goes to the else and thisnumber is $thisnumber<br>";
						if ($thisnumber !="")
						{
						echo "then this number is not blank so it removes an album<br>";
					$nenumber = str_replace("hi_selist[", "", "$thisnumber");
					$newnumber = str_replace("]", "", "$nenumber");
					$bam = mysql_query("select * from subgenres where id='$newnumber'");
					$bamrow = mysql_fetch_array($bam);
					mysql_query("update cds set featured='no' where subgenreid='$newnumber'");
					echo "newnumber is $newnumber and thisnumber is $thisnumber";
					echo "You have removed the Featured Album from $bamrow[name]<br>";					
						}

				}
		$numb++;
            }

I have 3 things in the database to test it out. Under Electronic - > Experimental everything works fine. Experimental is 9. Then for Indie -> Lo-Pop it works too. Lo-Pop is 1. Then the one that doesn't work the number is 50. That doesn't carry over.. is it something to do with double digits? Cause it jumps past the first blank and says $thisnumber is blank

[Najjar]

But you got it to work at the end right... 😕

[Shawazi]

I THOUGHT I got it to work. The main problem before was in fact due to my idiocy. But now I have it working, yet it only works for some categories. That means it's skipping right? But if it was skipping from time-outs woulnd't it skip randomly and not work for the same things everytime?

[Shawazi]

It's actually not working because it's skipping the first part. Like it will work for all subgenres under a maingenre like Electronic but not others such as the whole Hip-Hop section won't work. eh i'll try and figure it out myself

[Najjar]

Did you test your SQL statement
or tacked your loop variables
and you have you <select> as an array
array values starts from "0" but your loop is starting from "1"

$numb starts from 1 .... !!!!

so maybe its skipping the first value of the array
coz your array is not sorted by the id so the ids are not in a
sequence then 50 might be the first value on the array as:

$selist[0] = 50

I hope this will help.

[Shawazi]

I fixed it.

$subres = mysql_query("select * from subgenres where maingenreid='$maingenres'"); //maingenre defined elsewhere
		$subnum = mysql_num_rows(mysql_query("select id from subgenres"));  //number of subgenres under a maingenre

Subnum was originally just mysql_num_rows($subres). I realized that would give 12 everytime and stop the loop I was using even tho the id could go up higher. So all is well now.