php/mysql producing only one row of data

weasel-king

Hi all,

First post, and I'm obviously a newbie. I have a simple db with one table (of dvds, if you must know!). The code is not the most compact, but, hey, I'm just learning. The problem is that only one row of the table is displaying in the output.

Here's the php code I've gotten so far:

<?
$db_name = "criteriondb";
$table_name = "tblmain";

$connection = @mysql_connect("localhost", "USER", "PWD")
	or die(mysql_error());

$db = @mysql_select_db($db_name, $connection) or die(mysql_error());
$sql = "SELECT * FROM $table_name ORDER BY spineNum DESC";
$result = @mysql_query($sql,$connection) or die(mysql_error());

while ($row = mysql_fetch_array($result)) {
	$title = $row['title'];
	$director = $row['director'];
	$country = $row['country'];
	$year = $row['year'];
	$spineNum = $row['spineNum'];
	$aspectRatio = $row['aspectRatio'];
	$notes = $row['notes'];
	$ownDVD   = $row['ownDVD'];

$output = "<tr><td>$spineNum</td>";

if ($ownDVD == "1") {
	$output .= "<td class=\"own\">$title</td>";
}
else {
	$output .= "<td>$title</td>";
}

$output .= "<td>$director</td>
	<td>$country</td>
	<td>$year</td>
	<td>$aspectRatio</td>
	</tr>";
}
?>

I then have a simple table and am echoing the $output block in between the header and footer rows. The SELECT statement produces all the rows in mysql, just not through the php page. I've also altered my code a few times to be like examples I've seen here with no luck. I'm sure it's something simple...

Thanks in advance!

bastien

the row you display is probably the last one...try adding this:


//rest of your code
$output .= "<td>$director</td> 
    <td>$country</td> 
    <td>$year</td> 
    <td>$aspectRatio</td> 
    </tr>"; 

echo $output;
} //end while loop
?>

weasel-king

Hi "bastien",

That did the trick. The book I'm using to teach myself (PHP Fast & Easy Web Development) insists on putting all the php code before the opening <html> tags and echoing any output in the <body>.

When I simply moved it to the body, it works. Looks like the books are misleading sometimes, too!

Thanks for your help.

bastien

the other option is to add a period in the first line with the $output...which would concatenate the rows in the manner described by the bool...that might have been the initial error

while ($row = mysql_fetch_array($result)) { 
    $title = $row['title']; 
    $director = $row['director']; 
    $country = $row['country']; 
    $year = $row['year']; 
    $spineNum = $row['spineNum']; 
    $aspectRatio = $row['aspectRatio']; 
    $notes = $row['notes']; 
    $ownDVD   = $row['ownDVD']; 

[color=red]$output .= "<tr><td>$spineNum</td>";[/color] 

if ($ownDVD == "1") { 
    $output .= "<td class=\"own\">$title</td>"; 
}

//rest of code

drawmack

<?
$db_name = "criteriondb";
$table_name = "tblmain";

$connection = @mysql_connect("localhost", "USER", "PWD")
	or die(mysql_error());

$db = @mysql_select_db($db_name, $connection) or die(mysql_error());
$sql = "SELECT * FROM $table_name ORDER BY spineNum DESC";
$result = @mysql_query($sql,$connection) or die(mysql_error());

while ($row = mysql_fetch_array($result)) {
	$title = $row['title'];
	$director = $row['director'];
	$country = $row['country'];
	$year = $row['year'];
	$spineNum = $row['spineNum'];
	$aspectRatio = $row['aspectRatio'];
	$notes = $row['notes'];
	$ownDVD   = $row['ownDVD'];

//here is the culprit I'm adding a period before the equals
$output .= "<tr>\n	<td>$spineNum</td>\n";

//the next lines rewriten for readability and speed
$output .= "	<td " . ($ownDVD == '1') : "class=\"own\">" ? ">" . ">" . $title . "</td>\n";

$output .= "	<td>$director</td>
	<td>$country</td>
	<td>$year</td>
	<td>$aspectRatio</td>
</tr>";
}
?>

Thanks in advance! [/B][/QUOTE]