[Resolved] Loop logic and math problems...I think...

ywickham

I have the following code that pulls the number of downloads someone has completed from a database.

Ideally, the way this is supposed to work is that the user is allowed 5 downloads for a period. If the user has more than 5 downloads, they are denied the download and sent to another page. If they are allowed to download, the download proceeds. It also increments a counter field in the database. This is the code:

//Pull user id from cookie
$xnum = $HTTP_COOKIE_VARS['bbuserid'];

//Get number of downloads for current member
$query = "SELECT usergroupid, filedownloads FROM user WHERE userid = $xnum;";
$result = mysql_query($query);

$total_downloads = mysql_fetch_array($result);

$member_usergroup = $total_downloads[usergroupid];
$member_downloads = $total_downloads[filedownloads];

$pafiledb_sql->connect($db);
$config = $pafiledb_sql->query($db,"SELECT * FROM $db[prefix]_settings",1);

//If the user has a Monthly Membership
if ($member_usergroup == 10) {

if ($member_downloads == 5) {  //if downloads are 5

	//Deny user download and redirect to upgrade page
	chdir("c:/phpdev/www/html/modules/forums");
	?>
		<body onload=javascript:window.location.href="../../../segue.html">
	<?php
	exit;
} else {  //if downloads are less than 5

	//Allow user to download file
	include "./includes/download.php";

	//Increment file counter by 1
	$member_downloads = $member_downloads + 1;

	//Update file counter field in database
	$query = "UPDATE user SET filedownloads = $current_downloads WHERE userid = $xnum;";
	$result = mysql_query($query);

}
} else {
	include "./includes/download.php";
}

But of course, things are not as they should be and I'm running into the following problems:

When a user downloads the file, If the user has reached their 5 file limit, the download is still proceeding. It should not allow them to download the file.
There is a line that increments the counter by one. What I'm finding though, is that the field in the database gets set to whatever number I am incrementing by, instead of adding that number and the current file download number together to get the new total. For instance, if I changed my increment number to 3, once I re-run the script, the new number in the database would change to 3, no matter how many downloads were completed by the user.

Any ideas? I've been toying with this for hours now, and what seems like it should have been an easy task is now making me feel really stupid. 🙁 Help!

stolzyboy

think this may be the problem

 $member_downloads = $member_downloads + 1; 

    //Update file counter field in database 
    $query = "UPDATE user SET filedownloads = $current_downloads WHERE userid = $xnum;";

you have member_downloads incrementing by 1, then you are setting filedownloads equal to current_downloads, shouldn't that be member_downloads, or am i not looking far enough into the problem

ywickham

Oops! I thought I cleaned all that up, but that is not the answer. That section of the code should properly read:

//Increment file counter by 1
	$member_downloads = $member_downloads + 1;

//Update file counter field in database
	$query = "UPDATE user SET filedownloads = $member_downloads WHERE userid = $xnum;";
	$result = mysql_query($query);

Do you see anything else? Anyone?

(Thank you for noticing that, though!)

uniflare

Change these to lines:

    if ($member_downloads == 5) {  //if downloads are 5 

and

    $member_downloads = $member_downloads + 1;

to this:

    if ($member_downloads => "5") {  //if downloads are 5 or higher

and

    $member_downloads++;

That should solve the problem

uniflare

also try this...

$member_usergroup = $total_downloads[usergroupid]; 
$member_downloads = $total_downloads[filedownloads];

change the above to lines to this:

$member_usergroup = $total_downloads['usergroupid']; 
$member_downloads = $total_downloads['filedownloads'];

That may also solve the problem

ywickham

uniflare:

I made the changes, with the exception of changing the comparison operator to ">=" as my page would not display in the order you had it.

I then updated the "filedownloads" field in the database for my test user to 5 to force a "no download allowed" situation. What happened is that the field in the database was set back to 1 and the user was allowed to download the file.

Other options?

ywickham

uniflare:

I also tried to quotes around the the array elements with the same results.

Here is an update on the code as it is now with all the changes:

//Pull user id from cookie
$xnum = $HTTP_COOKIE_VARS['bbuserid'];

//Get number of downloads for current member
$query = "SELECT usergroupid, filedownloads FROM user WHERE userid = $xnum;";
$result = mysql_query($query);

$total_downloads = mysql_fetch_array($result);

$member_usergroup = $total_downloads['usergroupid'];
$member_downloads = $total_downloads['filedownloads'];

$pafiledb_sql->connect($db);
$config = $pafiledb_sql->query($db,"SELECT * FROM $db[prefix]_settings",1);

//If the user has a Monthly Membership
if ($member_usergroup == 10) {

if ($member_downloads >= "5") {  //if downloads are 5

	//Deny user download and redirect to upgrade page
	chdir("c:/phpdev/www/html/modules/forums");
	?>
		<body onload=javascript:window.location.href="../../../segue.html">
	<?php
	exit;
} else {  //if downloads are less than 5

	//Allow user to download file
	include "./includes/download.php";

	//Increment file counter by 1
	$member_downloads++;

	//Update file counter field in database
	$query = "UPDATE user SET filedownloads = $member_downloads WHERE userid = $xnum;";
	$result = mysql_query($query);

}
} else {
	include "./includes/download.php";
}

Thanks!

stolzyboy

ok, so what is happening now, nothing, allowing download, what

can you put some simple echo's in the if's to make sure you are getting into the if's

you should also think about changing these lines

$result = mysql_query($query);

to this

$result = mysql_query($query) or die(mysql_error());

so any errors will be reported to you

also try echoing out $query before you use mysql_query to make sure you are getting your $variables thru like you want

ywickham

The script still continues to allow the file download. I've tried echoing my variables in this script, but they don't get displayed anywhere I can view them (neither within the current file, or the file it calls...I believe it has something to do with the header() function towards the end.)

I've also changed my result variable line, with no errors reported on the queries.

stolzyboy

if you echo $member_downloads that doesn't show up

uniflare

make sure there are no other parts in your script or your included scripts that would alter that number field

also it seems that if they are not a member it lets them download the file... Echo the two variables ($member_usergroup,
$member _downloads)

also try this debug code:

//Pull user id from cookie 
$xnum = $HTTP_COOKIE_VARS['bbuserid']; 

//Get number of downloads for current member 
$query = "SELECT usergroupid, filedownloads FROM user WHERE userid = $xnum;"; 
$result = mysql_query($query); 

$total_downloads = mysql_fetch_array($result); 

$member_usergroup = $total_downloads['usergroupid']; 
$member_downloads = $total_downloads['filedownloads']; 

echo($member_usergroup.$member_downloads"); // debug echo

$pafiledb_sql->connect($db); 
$config = $pafiledb_sql->query($db,"SELECT * FROM $db[prefix]_settings",1); 

//If the user has a Monthly Membership 
if ($member_usergroup == 10) { 

echo("your a member,"); // debug echo

   if ($member_downloads >= "5") {  //if downloads are 5 
       echo(" and not allowed to download"); // debug echo
       //Deny user download and redirect to upgrade page 
        chdir("c:/phpdev/www/html/modules/forums"); 
        echo('<body onload=java script:window.location.href="../../../segue.html"> ');
        exit; 
    } else {  //if downloads are less than 5 

   echo(" and are allowed to download"); // debug echo

    //Allow user to download file 
    include "./includes/download.php"; 

    //Increment file counter by 1 
    $member_downloads++; 

    //Update file counter field in database 
    $query = "UPDATE user SET filedownloads = $member_downloads WHERE userid = $xnum;"; 
    $result = mysql_query($query); 

} 
} else { 
    echo("Not A Member"); // debug echo

include "./includes/download.php"; 
}

ywickham

Correct, if I echo $member_downloads it does not show up.

Maybe more of an explaination is due. The page that contains this code does not run through this code until after a link has been clicked that has an action variable set to "download". So imagine that this whole set of code is wrapped in an IF statement checking for that variable.

Once that variable setting is verified, the script continues with the code I posted. At that time, it calls another page which controls the download of the file itself (that's the "include/download.php".)

download.php then loads, presents a blank page which starts or is a result of the starting file download. Once the file has been downloaded or cancelled, the page, along with the file prompt dissappear and you are left back at the original page that displays the link that was clicked to download the file.

If I could echo variables successfully, I probably wouldn't be having this problem. 🙁

ywickham

uniflare:

See my previous post about echoing. If you have any suggestions on bypassing this problem, please let me know...anyone.

Also, I have verified and the variable has a unique name that is only used in this section of code.

As for control of downloading, there are several different member types, I am only concerned about controlling downloads for this one member type (10), which is why if a member is not of this type, they are allowed to download all they like.

stolzyboy

change these lines

$query = "SELECT usergroupid, filedownloads FROM user WHERE userid = $xnum;";

$result = mysql_query($query);

to this

$query = "SELECT usergroupid, filedownloads FROM user WHERE userid = $xnum;";

echo $query; //does the xnum show up
$result = mysql_query($query) or die(mysql_error());

uniflare

So your saying that if you try exit("hello world"); it doesn't do anything?......

ok, instead of this code:

$query = "SELECT usergroupid, filedownloads FROM user WHERE userid = $xnum;";  

$result = mysql_query($query);

try using this code:

$pafiledb_sql->connect($db); 
$total_downloads = $pafiledb_sql->query($db,"SELECT * FROM user WHERE userid = '$xnum';",1);

ywickham

stolzyboy:

I added the echo for the xnum variable. The results line had already been changed, as per my comment in a previous post.

The xnum variable did not show up.

stolzyboy

ok, so that is where the underlying problem is, where does xnum come from

ywickham

uniflare:

So now I have:

$pafiledb_sql->connect($db); 
$total_downloads = $pafiledb_sql->query($db,"SELECT * FROM user WHERE userid = '$xnum';",1);

$total_downloads = mysql_fetch_array($result);

Should I be changing that last line to:

$total_downloads = mysql_fetch_array($total_downloads);

Or something of that nature?

stolzyboy

uniflare, i'm gonna leave this up to you til you are though out, cuz i think we may be confusing him by both of use making suggestions

ywickham

stolzyboy:

The $xnum variable gets pulled from cookie at this line:

$xnum = $HTTP_COOKIE_VARS['bbuserid'];

A user can't access this section of the site if the cookie is not set. This is tested and working successfully in other areas of the site.

I think I see where you are going with this and have to disagree with you on that one, because if they $xnum variable was not being set, then the line that was:

$query = "SELECT usergroupid, filedownloads FROM user WHERE userid = $xnum;";

would never have been able to access the record in the database which is later on used to reset the "filesdownload" field to the wrong number. Do you agree?