How would you do this????

[sgtpepper]

Here is a hunk of code:

function getCurrSearchType(){
if (isset($SESSION["searchType"])){
$this->currSearchType = $SESSION["searchType"];
} else {
$this->currSearchType = "commercial";
}
}
function getCurrSearchType(){
if (isset($SESSION["searchType"])){
$this->currSearchType = $SESSION["searchType"];
} else {
$this->currSearchType = "residential";
}
}

How should I merge these two functions together?

[bastien]

function getCurrSearchType()
{ 
    if ($_SESSION["searchType"]=="commercial" ){ 
           $this->currSearchType = $_SESSION["searchType"]; 
    } else { 
           $this->currSearchType = "residential"; 
    } 
}

this assumes that those are the only two options

hth

[drawmack]

  function getCurrSearchType($st_var,$default = 'commercial'){
    $ret_val = $default;
    if ($st_var != '') {$ret_val = $st_var;}
    return $ret_val
} //end getCurrSearchType

now it's all in how you call it.

//default to commercial
$this->searchType = function getCurrSearchType($_SESSION["searchType"]);

//default to residential
$this->searchType = function getCurrSearchType($_SESSION["searchType"],'residential');

I also made the code self contained. Well behaved functions do not modify globals and if they do it is by modifying a parameter passed by reference.