E-Z Problem...

[erikhillis]

Why is this code pulling out every result in my roster table?... I only want people with the inactive status, in the status row pulled out.

<?php
$db = mysql_connect("localhost","jointops_xfactor","xxxx");
mysql_select_db (jointops_xfactor);
$sql = "SELECT * FROM roster WHERE game='{$_REQUEST['game']}' 
|| game2='{$_REQUEST['game']}' 
|| game3='{$_REQUEST['game']}' 
|| game4='{$_REQUEST['game']}'
|| status='inactive'  order by rankposition asc";
if (!$result = mysql_query($sql)) {
    print "Invalid query ($sql) : " . mysql_error();
    exit;
}
while ($row = mysql_fetch_assoc($result)) {

print "<table width=598 align=center>
<tr>
<td width=20%><a href=soldier.php?soldierid={$row['soldierid']}><font face=Verdana size=1 color=8d8d8d><B>{$row['name']}</B></a></td>
<td width=20%><center><font face=Verdana size=1 color=FFFFFF>{$row['rank']}</td>
<td width=20%><center><font face=Verdana size=1 color=FFFFFF>{$row['location']}</td>
<td width=20%><center><font face=Verdana size=1 color=FFFFFF>{$row['joined']}</td>
<td width=20%><center><font face=Verdana size=1 color=FFFFFF>{$row['specialty']}</td></tr>
<tr>
<td colspan=8 width=100% bgcolor=444444 height=2>
</td></tr>
</table>";
} 

?>

[LordShryku]

If you only want inactive people, then why all the extra OR statements?

game='{$REQUEST['game']}'
|| game2='{$REQUEST['game']}'
|| game3='{$REQUEST['game']}'
|| game4='{$REQUEST['game']}'

[Moonglobe]

and i think it should be OR instead of || in SQL? and the last one shouldn't even be OR, it should be AND, becuase you ONLY want people with inactive status.

hth
moon 🙂

[LordShryku]

Well, MySQL will accept ||, though it's not standard SQL practice.

And that damn beaver's following me AGAIN! :p

[erikhillis]

http://www.joint-ops.net/xfactor/roster.php?game=bhd

Problems still there...

<?php
$db = mysql_connect("localhost","jointops_xfactor","xxxxx");
mysql_select_db (jointops_xfactor);
$sql = "SELECT * FROM roster WHERE game='{$_REQUEST['game']}' and game2='{$_REQUEST['game']}' and game3='{$_REQUEST['game']}' and game4='{$_REQUEST['game']}' and status='inactive' order by rankposition asc";
if (!$result = mysql_query($sql)) {
    print "Invalid query ($sql) : " . mysql_error();
    exit;
}
while ($row = mysql_fetch_assoc($result)) {

print "<table width=598 align=center>
<tr>
<td width=20%><a href=soldier.php?soldierid={$row['soldierid']}><font face=Verdana size=1 color=8d8d8d><B>{$row['name']}</B></a></td>
<td width=20%><center><font face=Verdana size=1 color=FFFFFF>{$row['rank']}</td>
<td width=20%><center><font face=Verdana size=1 color=FFFFFF>{$row['location']}</td>
<td width=20%><center><font face=Verdana size=1 color=FFFFFF>{$row['joined']}</td>
<td width=20%><center><font face=Verdana size=1 color=FFFFFF>{$row['specialty']}</td></tr>
<tr>
<td colspan=8 width=100% bgcolor=444444 height=2>
</td></tr>
</table>";
} 

?>

[Moonglobe]

there should still be OR's between the gameX = blah, but there sholud be an AND right before the status='inactive' part, as in:

$sql = "SELECT * FROM roster WHERE game='".$_REQUEST['game']."' OR game2='".$_REQUEST['game']."' OR game3='".$_REQUEST['game']."' OR game4='".$_REQUEST['game']."' AND status='inactive' order by rankposition asc";

hth
moon 🙂