want to select all users in the database instead of 1

Paragon

My problem is. It only shows 1 user in the database. I want to show all the users in the database.

<?	
include("accesscontrol.php");
include('../config.php');
include('header.php'); 
if($editpermission != "true"){ echo "You do not have permission to edit entries.</div></div></body></html>"; }else{
?>
 <form action="<? echo $PHP_SELF ?>" method="POST">
<?
    mysql_pconnect("$host","$username","$userpass");
    mysql_select_db("$userdatabase");
    $result = mysql_query("SELECT * FROM $userprefix order by dlevel");
    while($r=mysql_fetch_array($result))
    {    

    $id=$r["id"];
    $userid=$r["userid"];
    $rank=$r["rank"];
    $dlevel=$r["dlevel"];
    if($rank="$rank")
    {
    	$result = mysql_query("SELECT * FROM $rankprefix WHERE rnum='$rank'");
    	    while($r=mysql_fetch_array($result))
    {
    	$rnum=$r["rnum"];
    	$rank=$r["rank"];
    	}
    	}
    ?>
    <div align="right">
  <table border="0" cellpadding="0" cellspacing="0" style="border-collapse: collapse" width="75%">
    <tr>
      <td width="100%"><? echo $userid;?>  <input type="text" name="dlevel" value="<? echo $dlevel; ?>" size="6">  <? echo $rank; ?></td>
    <br />  <br /> 
   <input type="submit" name="editdlevel" value="Edit" />
</form>
<? }?> 
   </tr>
  </table>
</div>
<?
if($editlevel=="Edit")
{
	$sql = "UPDATE $userprefix SET id='$id',userid='$userid',dlevel='$dlevel' WHERE id=$id";
        $result = mysql_query($sql);
        echo "Entry Updated </div></div></body></html>";
		exit;
    }
}
?>

trexx

the problem is that you reuse the $result var. first you select all users and then you begin to loop through the results. the you fill results with your second query that gets the ranking. So the results of the first one are lost.

just use another var for your second query.

btw. it's not a good idea to do a query for each user to get it's ranking. try to use a join instead. (the advantage is: if you have 200 users in your DB you need to do 201 queries to show each user and it's rank, with a join you only do ONE query... see? g)

Paragon

This is only for certain users. How could I do that though?

trexx

mh... use an LEFT OUTER JOIN to join the users table (on the left side) with the ranking table. You'll get a NULL value for the users that don't have a rank.

Paragon

umm...huh?

Paragon

what does that mean man?

Dax

perhaps when u did

if ($rank = "$rank") {

u meant

$rank == "$rank

Dax

what $rank = "$rank" mean? it makes no sens

Paragon

means nothing I took it out.