[Resolved] Retrieve username for mail to user

SeenGee

Hi, i'm using this script to allow a user to retrieve their password by filling their email address into a form, it sends their password fine but i cant seem to be able to send their username aswell.

<?
session_start();
require ('functions.php');
include 'db.php';

$pagename = 'Lost password';
pagetop($pagename);

switch($_POST['recover']){
	default:
	include 'lost_pw.html';
	break;

case "recover":
recover_pw($_POST['email_address']);
break;
}
function recover_pw($email_address){
	if(!$email_address){
		echo "You forgot to enter your Email address <strong>Knucklehead</strong><br />";
		include 'lost_pw.html';
		exit();
	}
	// quick check to see if record exists	
	$sql_check = mysql_query("SELECT * FROM users WHERE email_address='$email_address'");
	$sql_check_num = mysql_num_rows($sql_check);
	if($sql_check_num == 0){
		echo "No records found matching your email address<br />";
		include 'lost_pw.html';
		exit();
	}

// Everything looks ok, generate password, update it and send it!

function makeRandomPassword() {
	$salt = "abchefghjkmnpqrstuvwxyz0123456789";
	srand((double)microtime()*1000000); 
  	$i = 0;
  	while ($i <= 7) {
    		$num = rand() % 33;
    		$tmp = substr($salt, $num, 1);
    		$pass = $pass . $tmp;
    		$i++;
  	}
  	return $pass;
}

$random_password = makeRandomPassword();

$db_password = md5($random_password);

$sql = mysql_query("UPDATE users SET password='$db_password' WHERE email_address='$email_address'");


$subject = "Your Password at MyWebsite!";
$message = "Hi, we have reset your password.

New Password: $random_password
Username: $username

[url]http://localhost/public/suv/login.php[/url]

Thanks!
The Webmaster

This is an automated response, please do not reply!";

mail($email_address, $subject, $message, "Wrom: MVRESKPNKMBIPBARHDMNNSKVFVWRKJVZCMHVIBGDADRZFSQHYUCDDJBLVLMHAALPTCXLYRWT

echo "Your password has been sent! Please check your email!<br />";
include 'login_form.html';
}
pagebottom();
?>

i know it will be something along these lines but i cant make it work.


$username_check = mysql_query("select username from users where email_address='$email_address'");
	$username = $username_check;

n00854180t

What output are you getting now? Have you tried querying the database directly?

SeenGee

its outputting all the email details correctly including the new password.

what i need to do is query the database but its not working, i basically just need to retrieve username from the database then send this through with the email.

n00854180t

Try putting

 or die(mysql_error())

on your mysql functions and I am just curious but it looks like you are missing your closing parenthesis for your mail function:


mail($email_address, $subject, $message, "Wrom:  MVRESKPNKMBIPBARHDMNNSKVFVWRKJVZCMHVIBGDADRZFSQHYU
CDDJBLVLMHAALPTCXLYRWT

Should be


mail($email_address, $subject, $message, "Wrom:  MVRESKPNKMBIPBARHDMNNSKVFVWRKJVZCMHVIBGDADRZFSQHYU
CDDJBLVLMHAALPTCXLYRWT ")

Unless that is intentional.

SeenGee

that piece of code should actually be:

mail($email_address, $subject, $message, "From: MyDomain Webmaster<admin@mydomain.com>\nX-Mailer: PHP/" . phpversion());

dont know how it turned into what it is above.

i have the other thing you mentioned already.

basically, i know that all i need to do is something along these lines:

$username_check = mysql_query("select username from users where email_address='$email_address'");
	$username = $username_check;

but that returns :

Username: Resource id #3

Thanks.

n00854180t

while ($row = mysql_fetch_array($username_check))
{
echo $row["username"];
}

That should work if you want to get the actual value.

SeenGee

thanks but i dont want to actually echo the value back, i just want it to be included in the email that gets sent out so that it includes both the username and password.

This is the entire script with the changes now:

<?
session_start();
require ('functions.php');
include 'db.php';

$pagename = 'Lost password';
pagetop($pagename);

switch($_POST['recover']){
	default:
	include 'lost_pw.html';
	break;

case "recover":
recover_pw($_POST['email_address']);
break;
}
function recover_pw($email_address){
	if(!$email_address){
		echo "You forgot to enter your Email address <strong>Knucklehead</strong><br />";
		include 'lost_pw.html';
		exit();
	}
	// quick check to see if record exists	
	$sql_check = mysql_query("SELECT * FROM users WHERE email_address='$email_address'");
	$sql_check_num = mysql_num_rows($sql_check);
	if($sql_check_num == 0){
		echo "No records found matching your email address<br />";
		include 'lost_pw.html';
		exit();
	}

// Everything looks ok, generate password, update it and send it!

function makeRandomPassword() {
	$salt = "abchefghjkmnpqrstuvwxyz0123456789";
	srand((double)microtime()*1000000); 
  	$i = 0;
  	while ($i <= 7) {
    		$num = rand() % 33;
    		$tmp = substr($salt, $num, 1);
    		$pass = $pass . $tmp;
    		$i++;
  	}
  	return $pass;
}

$random_password = makeRandomPassword();

$db_password = md5($random_password);

$sql = mysql_query("UPDATE users SET password='$db_password' WHERE email_address='$email_address'");


$username_check = mysql_query("select username from users where email_address='$email_address'");
while ($row = mysql_fetch_array($username_check)) 
	{ 
	echo $row["username"]; 
	}


$subject = "Your Password at MyWebsite!";
$message = "Hi, we have reset your password.

New Password: $random_password
Username: $username

[url]http://localhost/public/suv/login.php[/url]

Thanks!
The Webmaster

This is an automated response, please do not reply!";

mail($email_address, $subject, $message, "Wrom: GPKYLEJGDGVCJVTLBXFGGMEPYOQKEDOTWFAOBUZXUWLSZLKBRNVWWCUFPEGAUTFJMVRESKPN
echo "Your password has been sent! Please check your email!<br />";
include 'login_form.html';
}
pagebottom();
?>

stolzyboy

well you don't just have to echo it there, that was just for illustration i'm sure, anyhoo, you can set it equal to a variable so you can use it in your mail

while ($row = mysql_fetch_array($username_check)) 
{ 
$variable_name_you_want = $row["username"]; 
}

n00854180t

Just change this

"); 
    while ($row = mysql_fetch_array($username_check))  

        {  

        echo $row["username"];  

        } 


$subject = "Your Password at MyWebsite!"; 
$message = "Hi, we have reset your password. 

New Password: $random_password 
Username: $username 

<a href="http://localhost/public/suv/login.php" target="_blank">[url]http://localhost/public/suv/login.php[/url]</a> 

Thanks! 
The Webmaster 

This is an automated response, please do not reply!";

To this:

"); 
    while ($row = mysql_fetch_array($username_check))  

        {  

        $username = $row["username"];  



$subject = "Your Password at MyWebsite!"; 
$message = "Hi, we have reset your password." . "\n";


$message .= "New Password: " .  $random_password . "\n";
$message .= "Username: " . $username . "\n";
$message .= '<a href="http://localhost/public/suv/login.php" target="_blank">[url]http://localhost/public/suv/login.php[/url]</a>' . "\n"; 
$message .= "Thanks!" . "\n"; 
$message .= "The Webmaster" . "\n\n"; 

$message .= "This is an automated response, please do not reply!";

Using newlines ("\n") and appending the $message variable makes for cleaner code.
Then end the while loop right after the include at the bottom:

include 'login_form.html'; 
}
} 
pagebottom(); 
?>

SeenGee

of course, i'm still learning as you can see. theres no accounting though for the stupidity caused by sleep deprivation.

Thanks a lot.

n00854180t

No problem, I am still learning also hehe.