unexpected $ and some DW problems...

[Radu]

hi there.

first of all - i have this php script/page, it seems like it should work fine, but i keep getting this error when i try to run it "Parse error, unexpected $ in path/to/file on line ##". the number is always the last line of the script or page. i am not sure how i should get rid of this problem. could u help?

also, i have just imported this site into Dreamwaver. i figured it wouldn't give me any problems doing that (i first exported it from another installation, properly), but now some of my "server behaviors" are giving me errors, like "MM_ERROR: unexpected error". any ideas on what might have caused that? should i just give up the imported site, and redefine a new one?

thanks a bunch.

Radu

[LordShryku]

Well, no clue about Dreamweaver, but post your code and I'll try to help you with your parse error....

[Radu]

okay, here it goes... it's just a simple page used to change a user's password.

<?php require_once('Connections/Connect1.php'); ?>
<?php
mysql_select_db($database_Connect1, $Connect1);
$query_get_users = "SELECT user_name FROM users ORDER BY user_name ASC";
$get_users = mysql_query($query_get_users, $Connect1) or die(mysql_error());
$row_get_users = mysql_fetch_assoc($get_users);
$totalRows_get_users = mysql_num_rows($get_users);
?>
<p align="left" class="mostoftext"><strong><em>Edit Users</em></strong></p>
<p align="center" class="mostoftext">Use this form to change a user's <strong>password</strong>:</p>
<form action="do_edit_user.php" class="mostoftext" name="update pass">
<table width="400" border="1" cellpadding="0" cellspacing="0" class="mostoftext">
  <!--DWLayoutTable-->
  <tr> 
    <td width="396" height="25" align="center" valign="middle">User: 
      <select name="user_to_edit" size="1" class="mostoftext" id="user_to_edit">
        <?php
do {  

?>
        <option value="<?php echo $row_get_users['user_name']?>"<?php if (!(strcmp($row_get_users['user_name'], $row_get_users['user_name']))) {echo "SELECTED";} ?>><?php echo $row_get_users['user_name']?></option>
        <?php
} while ($row_get_users = mysql_fetch_assoc($get_users));
  $rows = mysql_num_rows($get_users);
  if($rows > 0) {
      mysql_data_seek($get_users, 0);
	  $row_get_users = mysql_fetch_assoc($get_users);
  }
?>
      </select>
      New password: 
      <input name="new_pass" type="password" class="mostoftext" id="new_pass"></td>
  </tr>
  <tr> 
    <td height="56" align="center" valign="middle"><input class="mostoftext" type="submit" name="Submit" value="Change password"></td>
  </tr>
</table>
</form>
<?php
mysql_free_result($get_users);
?>

Thanks.

[LordShryku]

You're while loop is incorrect

//you have
while ($row_get_users = mysql_fetch_assoc($get_users));

//should be
while ($row_get_users = mysql_fetch_assoc($get_users)) {

//then you'll also need to close the loop when finished

[Radu]

Thanks, but unfortunately, it still won't work, even if i change that...

so what i have in there is:

do {
whatever to do }
while (condition);

why wouldn't that be correct?

[LordShryku]

while() is for looping. You're trying to use it as a statement, not a loop. Take a look at my signature. It hows how a while() loop should be used

[laserlight]

actually, I think your do while loop is correct, though I personally would prefer a while loop, since the first mysql_fetch_assoc() is fairly unnecessary.

LordShryku, read up on the do while loop here

The error reported probably has to do with an unmatched brace, or some missing '$' etc, causing the parser to parse all the way to the end of the script, and hence reporting the error on the last line.
I cant quite find it though, could it be in an iinclude file?

[LordShryku]

Ah yeah....missed the do {

Think I need some sleep....