Form isnt updating.

[Paragon]

I'm having a little trouble. Its not updating.

<?
function EDITPROFILE(){
include('config.php');
 $uid = $_SESSION['uid'];
 $submit = $_POST['submit'];
	mysql_pconnect("$host","$username","$userpass");
	mysql_select_db("$userdatabase");
	$resultdrop = mysql_query("SELECT * FROM $userprefix WHERE userid = '$uid'");
    while($r=mysql_fetch_array($resultdrop))
    {        

    $id=$r["id"];
    $password=$r["password"];
    $fullname=$r["fullname"];
    $emailaddress=$r["emailaddress"];
    $pic=$r["pic"];
    $division=$r["division"];
    $bio=$r["bio"];
    $URL=$r["URL"];
	}
	if(!$submit)
    {
?>
<form method="POST" action="<? echo $php_self ?>">
  <input type="hidden" name="id"  size="45" value="<? echo $id ?>" />
  <input type="hidden" name="userid"  size="45" value="<? echo $userid ?>" />
  Username : <? echo $uid ?><br />
  <br />
  <input type="password" name="password"  size="45" value="<? echo $password ?>" />
  Password<br />
  <br />
  <input type="text" name="fullname"  size="45" value="<? echo $fullname ?>" />
  Full Name<br />
  <br />
  <input type="text" name="emailaddress"  size="45" value="<? echo $emailaddress ?>" />
  Email Address<br>
  <br>
  <input type="text" name="URL"  size="45" value="<? echo $URL ?>" /> 
  Website<br>
  <br>
  <input type="text" name="pic"  size="45" value="<? echo $pic?>" /> 
  Picture<br>
  <br>


  <? 

  $divisiondrop = "SELECT Gname FROM $divisionprefix ORDER BY id desc";

 ?>

 <select name="division">

 <? 

$resultdivision=mysql_query($divisiondrop) or die(mysql_error()); 
while($row=mysql_fetch_array($resultdivision)) { 

?>

<option value="<?=$row['Gname']?>"><?=$row['Gname']?></option>

<? 
}
?> 
</select> Division

  <br>
  <br>


  <textarea rows="7" name="bio" cols="38"><? echo $bio ?></textarea><br>
    <br />

  <input name="submit" type="submit" value="Edit Profile" />
</form></div>
<?
}
if($submit)
    {
       $add_all = "UPDATE $userprefix SET id='$id',password='$password',fullname='$fullname',emailaddress='$emailaddress',pic='$pic',division='$division',bio='$bio',URL='$URL' WHERE id=$id";
       $result = mysql_query($add_all);
        echo "Your profile has been updated.</div></div></body></html>";
		exit;
    }
}
?>

[dankstick]

It looks like you are over-writing your variables.

You need to put this code...

$resultdrop = mysql_query("SELECT * FROM $userprefix WHERE userid = '$uid'");
    while($r=mysql_fetch_array($resultdrop))
    {        

    $id=$r["id"];
    $password=$r["password"];
    $fullname=$r["fullname"];
    $emailaddress=$r["emailaddress"];
    $pic=$r["pic"];
    $division=$r["division"];
    $bio=$r["bio"];
    $URL=$r["URL"];
    } 

inside of the if(!$submit) condition and not outside of it.

[Paragon]

That has no affect. Still doesn't work either way.

[Shawazi]

Why don't you check to see that all the variables are passing? Does it get to echoing "Your profile has been updated" ? If so change the echo to

echo "Your profile has been updated.<br>Query check:<br> $add_all<br><br></div></div></body></html>"; 

This will show the query.

You should also put at the query:

$result = mysql_query($add_all) or die("Error executing query");

These two steps will help you find your bug much faster. The user id is just a number right? If not the error is id=$id needs to be id='$id'

Let me know what happens seeing as you're the first person I'm helping on this forum :-D