Object Oriented style

[mdeanh]

I am creating some objects which require complex procedures to set up the variables. I can think of three different ways to code this. Does anyone have comments on pros and cons of each approach?

class TestClass1 {
var $foo;
var $bar;

// Constructor
function TestClass1() {
	$this->createFoo();
	$this->createBar();
}

function createFoo()
{ $this->foo = 'something' }

function createBar()
{ $this->bar = 'something'  }

}

class TestClass2 {
var $foo;
var $bar;

// Constructor
function TestClass1() {
	$this->foo = $this->createFoo();
	$this->bar = $this->createBar();
}

function createFoo() {
	//Statements
	return $foo;
}

function createBar() {
	//Statements
	return $bar;
}

}

class TestClass3 {
var $foo;
var $bar;

// Constructor
function TestClass3() {
	$this->foo = new Foo();
	$this->bar = new Bar();
}

}

class Foo {
// Constructor
function Foo() {
//Statements
}
}

class Bar {
// Constructor
function Bar() {
//Statements
}
}

[Anarchyh]

Hmm, reallly depends on the complexity of the foo & bar objects (not necessarily how complex they are to set up). If they are fairly complex i would say go with the one from testclass 3 since creating foo & bar as objects will allow you to alter the internal structure of the types without necessarily having to alter the classes that utilise them. If the initilisiation of these variables will involve some other functions i would also say go for three since you can then encapsulate them in the foo & bar objects.

However, if they aren't really that complex i would say that creating them as objects would be pointless so go with number 1.

[mdeanh]

Thanks, that was what I suspected but it's good to get confirmation.