parse error, unexpected $

phpscripters

Hello,

I feel bad for asking a question that deals with the entire script and not a little patch. But, it is only like 39 Lines so it isn't bad. I get a parse error, unexpected $ error in the following code, I have searched it through and through with no luck spotting the issue. If you can find it please let me know, your assistance would be greatly appreciated!


<?php
session_start();
include ("config.php");
include ("functions.php");
include ("settings.php");

echo "<head>";
echo "<title>$mem_title :: phpEZLinks Lite</title>";
echo "</head>";

$check = $_SESSION["check_log"];
$member = $_SESSION["user_name"];

if($check != "yes") {
alert_goto("Error: User Must Be Logged In To Access This Page!", "login.php");
} else {

echo "<center>";

if($use_bg == 1) {
echo "<body bgcolor=\"$bgcolor\">";
} else {
echo "<body>";
}

if($show_logo == 1) {
echo "<img src=\"$logo_url\">";
}

echo "<br><br><br>";

echo "<a href=\"main.php\">Main</a> : <a href=\"add.php\">Add Link</a> : <a href=\"mylinks.php\">View / Delete My Links</a> : <a href=\"password.php\">Change Password</a> : <a href=\"logoff.php\">Logout</a>";
echo "<br><br>";

foreach($HTTP_POST_VARS as $name => $value) {
$$name = $value;
}

?>

Thanks,
Brian

HalfaBee

Does this help?
HalfaBee

<?php
session_start();
include ("config.php");
include ("functions.php");
include ("settings.php");

echo "<head>";
echo "<title>$mem_title :: phpEZLinks Lite</title>";
echo "</head>";

$check = $_SESSION["check_log"];
$member = $_SESSION["user_name"];

if ($check != "yes") {
    alert_goto("Error: User Must Be Logged In To Access This Page!", "login.php");
} else {
    echo "<center>";

if ($use_bg == 1) {
    echo "<body bgcolor=\"$bgcolor\">";
} else {
    echo "<body>";
} 

if ($show_logo == 1) {
    echo "<img src=\"$logo_url\">";
} 

echo "<br><br><br>";

echo "<a href=\"main.php\">Main</a> : <a href=\"add.php\">Add Link</a> : <a href=\"mylinks.php\">View / Delete My Links</a> : <a href=\"password.php\">Change Password</a> : <a href=\"logoff.php\">Logout</a>";
echo "<br><br>";

foreach($HTTP_POST_VARS as $name => $value) {
    $$name = $value;
} 

?>

ScubaKing22

I see it!!!! It's on the line right before the closing bracket. It says $$name = $value; so just change it to $name = $value;

HalfaBee

No the $$name is correct, there is a missing closing brace at the end.
Nice formatting shows the error.
I ran it thru phpCodeBeautifier

HalfaBee

ScubaKing22

Well I guess that's true too. But how is having two $$'s correct? Please enlighten me...

HalfaBee

Yes $$name is correct.

This bit of code does the same thing as register_globals=on.
foreach($HTTP_POST_VARS as $name => $value) {
$$name = $value;
}

It can also be done using the extract function.
extract( $HTTP_POST_VARS );

You will need to read up on variable variables in the manual 🙂

HalfaBee

ScubaKing22

OK I guess I never knew that. But wouldn't that be the error since he is getting unexpected $ ?

HalfaBee

If you leave a brace or quote out and php parse's to the end of the file you get the unexpect $ at the last line number.
Not a very useful message.

Try it and see what happens.

HalfaBee

BuzzLY

To further clarify the $$names mystery...

When you use this code:

foreach($HTTP_POST_VARS as $name => $value) { 
  $$name = $value; 
}

... what it does is take the value in $name in each loop, add a $ to it to make a variable, and assign the value in $value to that variable. Clear as mud?

Let's say the first item in the $HTTP_POST_VARS array is "username", and that name is "BuzzLY". The foreach loop assigns $name = "username" and $value = "BuzzLY". The very next line assigns $username = "BuzzLY", which is what we want to happen, right?

That is why there are is $$ in that line, and why it is NOT the line causing the error.

In the future, please do not post so much code on one line inside your

 tags.  Anything inside [code=php] or [code] tags will NOT wrap properly- you need to wrap them yourself so it doesn't stretch out the page.

Arc

Yah i;ve never seen anyone use w $$'s on a variable either. Seems wierd.

But yah,when you get unexpected $ it usualy means an unclosed {} bracket, from my experience.