properly formatting returned results?

Kinsbane

Hey folks, a bit of a problem.

Whilst grabbing the recordset from my database, I wanted to use that to format a nice and pretty thumbnails table for some images - my plan was to have the table 3 columns wide, and however many rows down.

Here's the problem - each row from the recordset corresponds to one row in the outputted table - meaning 3 of the same image per row, rather than 3 different images per row.

head to http://www.darwenstheory.net/main.php?s=showgig&gig=Paladinos you can see what's happening.

Here's the code I'm using to format the recordset right now:

<?



echo $what;
$SQL="SELECT ID, image_path, thumb_path FROM Images WHERE gig='". $what ."' ORDER BY ID";
$SQL_Result=mysql_db_query($DB,$SQL,$sql_conn);
$SQL_Rows=mysql_num_rows($SQL_Result);

  while($row = mysql_fetch_assoc($SQL_Result)) {

	echo "
    <tr> 
      <td><div align=\"center\"><a href=\"main.php?s=showpic&iid=".$row['ID']."\"><img src=\"".$row['thumb_path']."\" style=\"border-style: solid; border-color: black; border-width: 1px;\"></a><br><br><a href=\"main.php?s=showpic&iid=".$row['ID']."\"><img src=\"http://www.darwenstheory.net/images/eye.gif\" border=0></a>&nbsp; &nbsp; &nbsp; <a href=\"".$row['image_path']."\" target=\"_blank\"><img src=\"http://www.darwenstheory.net/images/disk.gif\" border=0></a></div></td>";
	  echo "<td><div align=\"center\"><a href=\"main.php?s=showpic&iid=".$row['ID']."\"><img src=\"".$row['thumb_path']."\" style=\"border-style: solid; border-color: black; border-width: 1px;\"></a><br><br><a href=\"main.php?s=showpic&iid=".$row['ID']."\"><img src=\"http://www.darwenstheory.net/images/eye.gif\" border=0></a>&nbsp; &nbsp; &nbsp; <a href=\"".$row['image_path']."\" target=\"_blank\"><img src=\"http://www.darwenstheory.net/images/disk.gif\" border=0></a></div></td>";
     echo "<td><div align=\"center\"><a href=\"main.php?s=showpic&iid=".$row['ID']."\"><img src=\"".$row['thumb_path']."\" style=\"border-style: solid; border-color: black; border-width: 1px;\"></a><br><br><a href=\"main.php?s=showpic&iid=".$row['ID']."\"><img src=\"http://www.darwenstheory.net/images/eye.gif\" border=0></a>&nbsp; &nbsp; &nbsp; <a href=\"".$row['image_path']."\" target=\"_blank\"><img src=\"http://www.darwenstheory.net/images/disk.gif\" border=0></a></div></td>
    </tr>";
		}
	?>

I have also tried using a for { } loop to format the recordset as well, but that performed the same as the while loop - 3 of the same image per row. Any ideas?

Thanks,
Kinsbane

LordShryku

Well, you're while loop is only echoing the row it finds before looping. So effectivly, you're just echoing your data three times. Try something like this

$i=0; //incrementing variable
$limit=3; //integer for limits before new row
$hardLimit=3; // hard limit to break on
while($row=mysql_fetch_assoc($SQL_Result)) {
    $i++; // increment var
    echo "row data"; // echo your row of data
    // if we hit our limit, make a new row and set the new limit
    if($i==$limit) { 
        echo "<tr>";
        $limit=($i+$hardLimit);
    }
}

Kinsbane

Originally posted by LordShryku
Well, you're while loop is only echoing the row it finds before looping. So effectivly, you're just echoing your data three times. Try something like this
$i=0; //incrementing variable
$limit=3; //integer for limits before new row
$hardLimit=3; // hard limit to break on
while($row=mysql_fetch_assoc($SQL_Result)) {
    $i++; // increment var
    echo "row data"; // echo your row of data
    // if we hit our limit, make a new row and set the new limit
    if($i==$limit) { 
        echo "<tr>";
        $limit=($i+$hardLimit);
    }
}
[/B]

Hey thanks for replying, though I am still a bit confused..

when I echo the row data, would I echo the HTML for all 3 cells in the row? or just one cell? I'm not seeing how it would take 3 rows from the recordset and format them into one row in the HTML table 😕

Kinsbane

Nevermind, got it.

here's the ending code for it:

<?php

$what=$_GET['gig'];
$SQL="SELECT ID, image_path, thumb_path FROM Images WHERE gig='". $what ."' ORDER BY ID";
$SQL_Result=mysql_db_query($DB,$SQL,$sql_conn);
$SQL_Rows=mysql_num_rows($SQL_Result);

  $i=0; //incrementing variable 
$limit=3; //integer for limits before new row 
$hardLimit=3; // hard limit to break on 
while($row=mysql_fetch_assoc($SQL_Result)) { 
    $i++; // increment var 
    echo "<td><div align=\"center\"><a href=\"main.php?s=showpic&iid=".$row['ID']."\"><img src=\"".$row['thumb_path']."\" style=\"border-style: solid; border-color: black; border-width: 1px;\"></a>
<br><br><a href=\"main.php?s=showpic&iid=".$row['ID']."\">
<img src=\"http://www.darwenstheory.net/images/eye.gif\" border=0></a>&nbsp; &nbsp; &nbsp; 
<a href=\"".$row['image_path']."\" target=\"_blank\"><img src=\"http://www.darwenstheory.net/images/disk.gif\" border=0></a></div></td>"; // echo your row of data 
    // if we hit our limit, make a new row and set the new limit 
    if($i==$limit) {  

        echo "</tr><tr>"; 
        $limit=($i+$hardLimit); 
    } 
}
?>

thanks, Lord 😃

LordShryku

I knew you'd get it 🙂