Welcome!

jstarkey

Welcome to the new Code Critique forum. We've created this forum in the spirit of Open Source. One of the biggest advantages of OS is the fact that everyone can see the code. Having millions of eyes on the source means that just about any bug or exploit is going to be found in record time. It also helps the community grow, by sharing the "better ways" of doing things.

Please feel free to post your code here for others to offer suggestions and/or comments. Please also share the wealth by checking out someone else's work as well.

Enjoy!!

n00854180t

Cool forum idea 😉

Merve

I think that this forum is a great idea. It'll help me find the bugs in PEBoDMyAdmin in record time! And now...BuzzLY is a mod! Congrats BuzzLY!

I just found it a little weird when I signed into PHPBuilder, went to the EL, went back to the main page, and found a new forum, but it's all good because I'm sure that this forum is going to rock and we'll be running on ten pages in record time!

planetsim

This sounds like a great idea for all..

so to start things off

<?php
phpinfo();
?>

Can someone tell me how to improve that 😃

n00854180t

LOL

<?php
	phpinfo();
?>

Indent.

Merve

Actually, you wouldn't indent for that one. Usually...it's a matter of preference. It's so simple that there is absolutely no point in indenting.

n00854180t

I know. I was j/k.

planetsim

yay im a master at phpinfo(); Ok i guess there are more serious ones like Merve wants..

jstarkey

Originally posted by planetsim
<?php
phpinfo();
?>
[/B]

You forgot to comment it. Remember, a year from now you may look at this and say "what was I thinking".

n00854180t

LOL good one.

planetsim

your so right hows this

<?php
//this page will say im so smart
//it will produce a whole gui look of the php.ini file
//my mates will think im some sort of genius when i show them
//    that a little line of code can produce so much
phpinfo();

//remember its php as in the language
//info as information about it
// () for no particular reason other than it looks good
// ; to close it off
?>

I might not have said enough.

jstarkey

While that will suffice, it's generally a good idea to follow a standard convention. Might wanna check out something like PHPDoc:

http://pear.php.net/manual/en/package.php.php

😃

LordShryku

Bah! There's those "standards" again...

drawmack

actually you should turn php_info off on your server it gives a hacker too much information including your htaccess usernames and passwords.

drawmack

On a different note this is a great forum idea. I am working up my cv site and for it I am doing some downloadable php - mostly games and guestbooks and stuff. With this forum I can let the community test them out for me so I'm not embarassed by a stupid mistake that stops my code from executing on other people's servers.

thanks phpbuilder.

Moonglobe

Yes indeed, great idea! lol thats about all i have to say right now.....

piersk

Originally posted by drawmack
actually you should turn php_info off on your server it gives a hacker too much information including your htaccess usernames and passwords.

Or, you could do what I did (although I can't take all the credit. I got the idea off John)

jstarkey

Originally posted by piersk
Or, you could do what I did (although I can't take all the credit. I got the idea off John)

Copycat!! :mad:

😃

piersk

Hey! I credited you, both here and there.

jayant

but what if some error occurs and we need to debug:-

    <?php
        // note about the license in which the following is being
        // dibtributed, other legal mumbo jumbo

    // turn on all errors for better debugging
    error_reporting(E_ALL);
    // some comment
    $debug_on = 1;
    // some comment
    if($debug_on==1) echo "about to enter function phpinfo";
    // some comment
    phpinfo();
    // some comment
    if($debug_on==1) echo "just exit from function phpinfo";

    // end thanksgiving if any
?>