Regarding code appearance...

dalecosp

I called up my brother the NT sysadmin guy and asked him for help with a CSS issue that turns out wasn't much of one.

He commented on the fact that "I didn't care what my HTML source looked like."

Now, he doesn't have much concept of database-driven/scripted sites ....

How much effort do you go to to ensure that the HTML source of your sites are properly 'tabbed' and 'newlined', etc., particularly when you're trying to whip stuff out at the lowest cost for the client?

Form or function, or both?

LordShryku

None at all, unless there's a need to(HTML mail, etc). My highly non-standardized way of doing things again tells me functionality is better than pretty. They don't nned to be lookin at that stuff anyway

-my two cents

Nehle

I often write for functionality at first, if I have time after that, I try to make my sites both XHTML and CSS validated. Takes a couple of extra hours, of course, but I like to be certain my sites works on any webbrowser (except that IE has some CSS problems, but screw them 😛 )

Moonglobe

just a hobbiest myself, but that could soon change..... in any case if it's just for me i try and make things pretty.......... if it's not perfect i don't mind. If i was getting paid then i agree with LordShryku totally.

onyx

I never generally bother to do proper indenting (and when I can be bothered I just get emacs to automatically do it) but I always make my sites xhtml 1.0 transitional and my CSS comply. I never used to do this and converting it all was quite a pain but now I just churn out compliant HTML and CSS without even thinking about it. I certainly think it is good practice to do so to aid understanding, maintainance and complience.

Nehle

Vim does indent properly for me. And if it doesn't it's an easy command.
I like having properly indented code, makes debugging hell of a lot. easier, and it's also easier for others to understand

LordShryku

Indenting code is one thing....
My PHP code is pristine with it's indentation and formatting. I think he's talking about the HTML code generated from the PHP code though. In which case, I really don't care too much unless I have to.

bliss322

"They don't need to be lookin at that stuff anyway"

well, i was about to mention that they just might HAVE to look at it someday.

proper form (server side and client side) is a treat to the person that has to come behind you and maintain your work; whether that's another freelancer or an employee of your client. i work for a large enough company that the other offices often buy third party web apps that i then have to support.

but then LordShryku reminded me about php generated html, so i figured i'd shut up cause i'm guilty there. :rolleyes:

LordShryku

Like I said. My PHP is all properly indented, and I give plenty of free space in there to keep things well seperated. In fact, I give hell to people that don't do that. But my generated HTML isn't always the prettiest thing to look at....

eoghain

Personally for me I like to try and make my HTML somewhat readable. Now I don't do much HTML work anymore but when I did I found it very annoying to try and see what went wrong in my HTML if it wasn't formatted somewhat. Now it may not have been the pretiest HTML but at least the various sections were identifiable for me to track down errors.

But if I don't have to deal with the HTML then I don't bother with any formatting issues. My code looks good and is understandable and that is all that matters.

Sxooter

The worst offense to me is the single very long line web page. We've all seen it. A 16k string on one line, no CRs or breaks. ugh.

As long as the html has CRs in it I'm pretty happy.

Nixon

Hey, I always try to keep my PHP in good form. If its in good form it tends to be easier to update and so on.... HTML I use dreamweaver to do all my html then I manually code the PHP. Dreamweaver sorts most of it out for me.

LordShryku

I don't think these people get the difference between coding HTML and generated HTML...

I'm with you Sxooter. I see that stuff all the time with these canned php nukes. Hurts my eyes...

dalecosp

Originally posted by eoghain
Now it may not have been the pretiest HTML but at least the various sections were identifiable for me to track down errors.

And that was the gist of my OP ... my brother only codes for his employer's site, (and deals will over a hundred users daily with only one assistant IT dude) but he's real picky about perfect looking HTML and CSS. That's fine ... he's salaried 😉

Me, I've got 8 or more sites either in development or in the maintenance phase, plus a "few fire and forget's" and I've got no one else working, plus I have LAN's in various offices and residential customers calling me everytime they get a virus or a modem zotted by lightning, (which this time of year is more often that some other times...)

If a site works, I don't much care, although I don't like to forget the "\n" 's as Sxooter says ...it's nice if it fits on a screen when viewing source. And, I'm never sure that the browser I'm using is "da bomb" when it comes to interpreting CSS (but that's another subject...)

I called my brother 'cause I was adjusting type sizes in CSS and it wasn't doing anything in the browser ... and we needed to figure out what containers were open, and which might be overriding another.

He has a good point, but cleaning up the code is going to take awhile, and some of my clients are probably getting near the point of not being so happy when they get my invoices.... :eek:

I guess it's like anything else ... use your head in each circumstance.

The source for the page we were looking at last night looks much better today 😃

drawmack

There are a couple of important things here

1) I do not generate html from inside of php. I create templates that just have variables in them and then I include those files. This being the case it's very easy for me to format my html properly

2) I validate my xhtml templates before I even start writting php. I do not validate my css because it yells at me for things it shouldn't like leaving out a bgcolor.

3) I like well formated html for me not for them. I often have to look at my html source as part of finding the errors in the php and this is much easier if it's well formated.

tbach2

I've got to agree with drawmack-- I use phplib's template which makes it really simple to have easy-to-read html. Which is really handy when your customer wants you to go back and make it look different.

Jeb_

Again, with drawmack. I try to avoid generating HTML inside PHP as much as possible (it's just a maintenance mess later on).

But then again I don't care how nice it looks. I'll take the time to put in the CR-LF's, and I'll preserve what indenting my editor gives, but I'm not going to ensure each tag is exactly 1 indent under the parent tag, etc.

tekky

if I have an error, or problem with an HTML output... I just add a debug keyword or \n\r above/below it so it stands out until fixed, I could care less what the HTML looks like I care more about the PHP source as thats what I do the most of

function not form 🙂

drawmack

I have read the function/form and the form/function arguments and as far as I'm concerned neither of them holds water.

I personally believe form = function.

Here is why I way this:
Code that doesn't work but looks beautiful, i.e. good form poor functionality, is useless.

Code that looks horrible but works is not reusable and is almost impossible to change and update. Therefor this code is also useless.

If anyone argues with this then I guess that in php your variables are all named $one, $two and you never use indenting or line returns either.

To me it doesn't make any sense to format some of your code, i.e. format the php and not the html.

That's like writting half a user's manual.

Merve

...and leaving someone like me to figure it out 😃

Formatting the HTML is important for me too, I guess. I don't want crazy fly-away generated HTML...I think what drawmack means by reusable is changeable. It is hard to change unformatted all-over-the-place HTML. It is easy to reuse without any changes the HTML, all you have to do is copy+paste, but that is just a temporary solution.