Well, more personal opinions than "coding standards", but my two cents:
1) The multiple echo statements in you functions could be turned into one echo statement. This would help a bit with dalecosp's need to get his HTML source formatted right. And it's just a bit easier/prettier.
2) The long if/elseif statements should be made into switch statements. Prime example...
if ($_GET[mode] == 'news') {
$admin = "New News";
}
else if ($_GET[mode] == 'edit') {
$admin = "Add/Change Edit";
}
else if ($_GET[mode] == 'joke') {
$admin = "New Joke";
}
else if ($_GET[mode] == 'cheats') {
$admin = "New Cheat";
}
else if ($_GET[mode] == 'poll') {
$admin = "New Poll";
}
else if ($_GET[mode] == 'users') {
$admin = "Users Admin";
}
else if ($_GET[mode] == 'version') {
$admin = "Version History";
}
else if ($_GET[mode] == 'counter') {
$admin = "Counter";
}
else if ($_GET[mode] == 'enews') {
$admin = "Edit News";
}
else if ($_GET[mode] == 'guest') {
$admin = "Guestbook";
}
else if ($_GET[mode] == 'blog') {
$admin = "Blogs";
}
// made into a switch statement...
switch($_GET[mode]) {
case "news":
$admin = "New News";
break;
case "edit":
$admin = "Add/Change Edit";
break;
case "joke":
$admin = "New Joke";
break;
case "cheats":
$admin = "New Cheat";
break;
case "poll":
$admin = "New Poll";
break;
case "users":
$admin = "Users Admin";
break;
case "version":
$admin = "Version History";
break;
case "counter":
$admin = "Counter";
break;
case "enews":
$admin = "Edit News";
break;
case "guest":
$admin = "Guestbook";
break;
case "blog":
$admin = "Blogs";
break;
default:
break;
}
planetsim did a good article on this that was made sticky on one of the forums. Can;t remember which one, but I'll link it once I find it.
Didn't get through it all, but everything else I saw looks pretty nice. GJ 🙂
