[Resolved] fopen() syntax -> variables

mberman

I'm trying to make a rather simple script and somehow can't figure out how to do this.. fopen() has always confused me, I've posted about that a few times before.

Anyways, here's what I want to do...

1) open a file, users.txt, that contains a group of usernames/passwords in a CSV (comma seperated values) format.

-EXAMPLE:-
joeuser,joepass
bobuser,bobpass

2) store those in an array (i guess...)

3) Check and see if the variables $username and $password match a combination in the file

I was also thinking if a for() loop that creates an array for every line in the file would work better.

And yes, I do know that this way of doing things in extremely non-secure, and it's fine for now. It's just test-users, that are all me, with non-important passwords.

Any help would be greatly appriciated!

barand

Easiest to use

$filearray = file('users.txt');   //each line of file is an element of filearray
foreach ($filearray as $data) {
   list($user, $pwd) = explode(',' , $data);
   // process user and pwd
}

hth

mberman1

Well, that heled a lot, but I'm still stuck... With a couple of things. Whenever I go to reply to a post or start a new thread with my account, mberman, I get a permission denied, even though I was logged in. Any help with that would be appriciated, but for now, mberman1 will be my identity. Anyways, I implemented your selection, but I think I'm still doing something wrong. My code is as follows:

<?PHP
##################################################################
#                                                                #
#               Paypet v. 1.0 public beta                        #
#                                                                #
#                                                                #
##################################################################

//Define the major, standard vars
$pp_version = "PayPet v. 1.0 <u>UNPUBLIC BETA</u>";
$pp_lisc = "Joe M. Blow";
$pp_lisccomp = "JowBlow, Inc.";
$pp_lisckey = "KJ6383jd9";
if ($onceover == "") {
//print the html
echo "
<html>
<head><title>PayPet v. 1.0 Public Beta</title>
</head>
<body>
<center><font color='red' size='5'>PayPet</font>
<br>
<form action='index.php' method='post'>
<input type='hidden' name='onceover' value='true'>
<i><font color='blue'>Please Login</font></i><br>
<b>Username: </b><input type='text' name='username' value=''>
<br>
<b>Password: </b><input type='password' name='pwd' value=''>
<br>
<input type='submit' name='submit' value='Login!'>
<input type='reset' name='reset' value='Reset!'>
</form>
<p>
<p>
$pp_version liscensed to $pp_lisc of $pp_lisccomp (key $pp_lisckey)
</body>
</html>
"; } elseif ($onceover == "true") {

//test code below
$filearray = file('users.txt'); //each line of the file is an array.
foreach($filearray as $data) {
      list($user,$pwd) = explode(',' , $data);
        //process the username/password data
     if($username = $user && $pwd = $password) {
//end test code
echo "
<html><head><title>$pp_version ($pp_lisc)</title>
</head>
Welcome to <i>$pp_version</i>, $username!";
}  else {
echo "bad boy.";
} else {
echo "<font color='red'>Error. Invalid DIM variables.</font>";
}
?>

Now, the variables parsed from the url are $username and $pwd. I get an parse error at line 54, which I also can't figure out (hence the whole script pasted). The "test" code is denoted by "//test code below" and "//end test code". (My comment at the top got messed up with pasing).

barand

One error is

if($username = $user && $pwd = $password) {

should be

if($username == $user && $pwd == $password) {

mberman1

all right. I'll change that. Is my if syntax otherwise correct for comparing the file to the user-submitted values?

mberman1

it stilll doesn't like something. parse error on line 44 still 😢

barand

You have at least one '}' missing

barand

This parses

 ##################################################
################
#                                                                #
#               Paypet v. 1.0 public beta                        #
#                                                                #
#                                                                #
 ##################################################
################

//Define the major, standard vars
$pp_version = "PayPet v. 1.0 <u>UNPUBLIC BETA</u>";
$pp_lisc = "Joe M. Blow";
$pp_lisccomp = "JowBlow, Inc.";
$pp_lisckey = "KJ6383jd9";
if ($onceover == "") {
    //print the html
    echo "
    <html>
    <head><title>PayPet v. 1.0 Public Beta</title>
    </head>
    <body>
    <center><font color='red' size='5'>PayPet</font>
    <br>
    <form action='index.php' method='post'>
    <input type='hidden' name='onceover' value='true'>
    <i><font color='blue'>Please Login</font></i><br>
    <b>Username: </b><input type='text' name='username' value=''>
    <br>
    <b>Password: </b><input type='password' name='pwd' value=''>
    <br>
    <input type='submit' name='submit' value='Login!'>
    <input type='reset' name='reset' value='Reset!'>
    </form>
    <p>
    <p>
    $pp_version liscensed to $pp_lisc of $pp_lisccomp (key $pp_lisckey)
    </body>
    </html>
    ";
    }
elseif ($onceover == "true") {

//test code below
$filearray = file('users.txt'); //each line of the file is an array.
foreach($filearray as $data) {
      list($user,$pwd) = explode(',' , $data);
        //process the username/password data
     if($username = $user && $pwd = $password) {
//end test code
        echo "
        <html><head><title>$pp_version ($pp_lisc)</title>
        </head>
        Welcome to <i>$pp_version</i>, $username!";
     }  else {
        echo "bad boy.";
     }
}
}
else {
  echo "<font color='red'>Error. Invalid DIM variables.</font>";
}

mberman1

Yes, that helped. Now it parses the first page, but when I enter a username and password, it gives me a parse error on line 44 that I can't figure out either. 😢

P.S. Thanks, you've been very helpful so far.

barand

I just noticed the = crept back in (instead of ==) when I copied yur code to find the missing }'s

mberman1

Ok... so now, with an invalid password, it prints "bad boy.bad boy.bad boy." -- one for every entry, becuase the if() that prints it is inside of the foreach.... How could I have it be outside, or at least only print the "error" one time?

barand

$match_found = 0;
foreach($filearray as $data) { 
          list($user,$pwd) = explode(',' , $data); 
            //process the username/password data 
         if($username = $user && $pwd = $password) { 
            echo " 
            <html><head><title>$pp_version ($pp_lisc)</title> 
            </head> 
            Welcome to <i>$pp_version</i>, $username!"; 
            $match_found = 1;
            break;
         }  

} 
if (!$matchfound) {

        echo "bad boy."; 
}

tbone-tw

Change:

         if($username = $user && $pwd = $password) {
    //end test code
            echo "
            <html><head><title>$pp_version ($pp_lisc)</title>
            </head>
            Welcome to <i>$pp_version</i>, $username!";
         }  else {
            echo "bad boy.";
         }

to:

        if($username = $user && $pwd = $password) {
                $valid = true;
        }

Then outside the foreach loop, add:

        if ($valid) {
            echo "
            <html><head><title>$pp_version ($pp_lisc)</title>
            </head>
            Welcome to <i>$pp_version</i>, $username!";
         }  else {
            echo "bad boy.";
         }

And of course just before the foreach loop throw in one of these:

        $valid = false;

(Not strictly necessary, but a good habit.)

tbone-tw

Or do what barand suggested, since he obviously types faster than I do. 🙂

But we both made the same mistake, allowing your assignment to creep back in instead of using the comparison. So change the comparison line to the following no matter whose solution you use:

if($username == $user && $pwd == $password) {

Also, barand's code has a minor mistake. The variables in the last if statement should be changed to $match_found.

barand

Thone-tw

I prefer the elegance of your code, though I'd still 'break' after setting valid to 'true'. No point reading more false ones.

tbone-tw

I agree about the break. I should have added that in as another "Not strictly necessary but a good habit" comment, especially since I would probably have put it there if this was my own code.

mberman

Thank you both for your help! I'll revise it tomorrow, and hopefully it'll work! Sorry it took me so long to respond to your posts!