File Writing

bpfonte

Hi all,

I'm writing a little music poll program.

I use a text file to keep the music names and the number of votes just

like this:
[FONT=courier new]
Soulmagic - Soulmagic |1
Simply Red - Fake |1
Sting - Send Your Love |4
Moloko - Forever Love |3
[/FONT]
and the following function where I input the line number where the music
is:

  function vote($answer){
     global $datafile; //file with the music list
     If (!empty($answer)) {
        $line=file("$datafile");
        $regist=explode("|",$line[$answer]);
        $regist[2]++;
        $line[$answer]=implode("|", $regist);
        $line[$answer]=$line[$answer]."\r\n";
        ignore_user_abort(true);
        $file = fopen($datafile, 'w+b');
        if ($file){
             if (flock($file, LOCK_EX)){
                flock($file, LOCK_UN);
                $i=0;
                do{
                    fwrite($file,$line[$i],strlen($line[$i]));
                    $i++;
                }while($i<count($line));
             } else echo "Could not lock file '$datafile'";
             fclose($fich);
        } else  echo "Could not open file '$datafile'";
         ignore_user_abort(false);
     } else echo "No answer!";
  }

I'm using Apache running on windows filesystem.

Can anybody please help me undersanting what am I doing wrong?

Many thanks in advance and sorry for the long post.

            Bruno

intenz

Sigh, use MySQL.
A lot easier.

bpfonte

I wish...
The company I'm writing this code for hosts its site on a server without MySQL access.
I'm trying to convince them to upgrade but... only if I can make the site worthit...:rolleyes:

okuto1973

That's the right one.
This is the line you have to change:
$regist[1]=$regist[1]+1;
don't know why $regist[1]++ doesn't work!
and the value had to be 1 not 2!

  function vote($answer){
     global $datafile; //file with the music list
     If (!empty($answer)) {
        $line=file("$datafile");
        $regist=explode("|",$line[$answer]);
        $regist[1]=$regist[1]+1;
        $line[$answer]=implode("|", $regist);
        $line[$answer]=$line[$answer]."\r\n";
        ignore_user_abort(true);
        $file = fopen($datafile, 'w+b');
        if ($file){
             if (flock($file, LOCK_EX)){
                flock($file, LOCK_UN);
                $i=0;
                do{
                    fwrite($file,$line[$i],strlen($line[$i]));
                    $i++;
                }while($i<count($line));
             } else echo "Could not lock file '$datafile'";
             fclose($fich);
        } else  echo "Could not open file '$datafile'";
         ignore_user_abort(false);
     } else echo "No answer!";
  }

bpfonte

Thanks for the help... it worked!!
Just had to adjust slightly the code so that the linefeed wouldn't get in the way. The solution I found was using rtrim() in the working line.
The final and working code is as follows.

function vote($answer){
	global $datafile;
	If (!empty($answer)) {
	$text=file("$datafile");
	$line=rtrim($text[$answer]);
	$regist=explode("|",$line);
	$regist[1]=$regist[1]+1; 
	$line=ltrim(implode("|", $regist));
	$text[$answer]=$line."\r\n";
	ignore_user_abort(true);
	$fich = fopen($datafile, 'w+b');    

	if ($fich){
    	if (flock($fich, LOCK_EX)){     

          	flock($fich, LOCK_UN);
			$i=0;
			do{
				fwrite($fich,$text[$i],strlen($text[$i]));
				$i++;
			}while($i<count($text));
    	} else echo "Could not lock file '$counter_file'";
     	fclose($fich);
	} else  echo "Could not open file '$counter_file'";
	ignore_user_abort(false);  

	} else echo "No answer!!";
}

If anyone needs the full code, don't hesitate to ask.