problems with if { else }

[peter_b]

Hi,

I am trying to create a user registration page and appear to be having a problem using IF { ELSE } .

Here is a piece of code:

if ( !$submit)
{
echo "<form action=\"tform2.php\" method=\"get\">";
echo "<center>";
echo "<table>";

echo "<tr><td colspan = 2 bgcolor=\"#000000\"><font color=\"#aaddaa\"><center>Online Registration</center></font></td></td>" ;

echo "<tr><td>first name";

echo "<td><input type=\"text\" name=\"namef\" size=40></tr></td>";
echo "<tr><td>last name</td>";
echo "<td><input type=\"text\" name= \"namel\" size=40></tr></td>";

echo "<tr><td>&nbsp;</td>";
echo "<td><center><input type=\"submit\" name=\"submit\" value=\"submit\"></center></tr></td>";
echo "<tr><td colspan=2><center>Section</center></td></td>" ;
echo "</table></center></form>";

if ( $submit && ($namef || $namel ))
{
echo "<br><br><b><font size=+2><font color=\"blue\">";
echo "<center>Your data has been successfully entered.";
echo "</b></center></font></font>";
}

if ( $submit && (!$namef || !$namel ))
{
$errorList = array();
$count = 0;
if (!$namef) { $errorList[$count] = "Missing first name"; $count++; }
if (!$namel) { $errorList[$count] = "Missing last name"; $count++; }
// if (sizeof($errorList) == 0)

echo "<br><br><font size=+1><center>"; 
echo "You <font color=\"#FF0000\"><b>must</b></font> "; 
echo "Please enter required data!<br><br>";
for ($x=0; $x < sizeof($errorList); $x++)
    { echo "$errorList[$x] <br>"; } 
echo "<br><a href=\"tform2.php\">here</a> to start over"; 
echo "</font></center><br><br>"; 

}

}
?>

Can someone tell me why it doesn't report errors after clicking submit with empty fields?

Thanks,

Peter

[OhLordy]

<?php
//form has not been submited
if ( !$submit) {
//drop out of php tags for long chunks of text as php has to parse everything in the echo statements but
//does not outside the pjp tags
?>
<form action="tform2.php" method="get">
<center>
<table>
<tr><td colspan = 2 bgcolor="#000000"><font color="#aaddaa"><center>Online Registration</center></font></td></td>
<tr><td>first name
<td><input type=\"text\" name="namef" size=40></tr></td>
<tr><td>last name</td>
<td><input type=\"text\" name= \"namel\" size=40></tr></td>
<tr><td> </td>
<td><center><input type=\"submit\" name=\"submit\" value=\"submit\"></center></tr></td>
<tr><td colspan=2><center>Section</center></td></td>
</table></center></form>
<?php
//both namef and namel are filled
} elseif($namef && $namel) { ?>
<br><br><b><font size=+2><font color=\"blue\">
<center>Your data has been successfully entered.
</b></center></font></font>
<?php
//one of the names is incorrect
} else {
    //count is not needed [] places var in the arrays next element ie adding one on the end.
    //this has the same effect as array_push();
    if(!$namef) { $errorList[] = "Missing first name"; }
    if(!$namel) { $errorList[] = "Missing last name"; }
    ?>
    <br><br><font size="+1"><center>
    You <font color="#FF0000"><b>must</b></font>
    Please enter required data!<br /><br />
<?php
    for($x=0;$x<sizeof($errorList);$x++) {
        //cannot have arrays within double quotes must have them outside and catenate
        //also avoid using more than one echo when the output can be catenated into one.
        echo($errorlist[$x]."<br />\n<br />\n<a href=\"tform2.php\">here</a> to start over\n".
            "</font></center><br /><br />");
    }
}
?>

HTH
Rob

[Nehle]

Proper indenting helps a lot when you get problems like these

[Weedpacket]

Cutting out all the code that doesn't affect the program's decision-making helps isolate the problem as well:

if ( !$submit)
{
	...
	if ( $submit && ($namef || $namel ))
	{
		...
	}

if ( $submit && (!$namef || !$namel ))
{
	...
	if (!$namef) { ... }
	if (!$namel) { ... }
	...
}
} 

[peter_b]

Hi,

Okay, now I see it better.

You are right, I thought that it would be easier to keep the code and the html going in one thought.
Now I see that I will have to use a better style.

Thank you both for your help.

Peter