Can anyone spot the problem?

droms

Can anyone spot any problems with this simple guestbook comment submit form? it has just stopped work all of a sudden?


<html>
<head>
<title>Guestbook</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<center>Castle FM Guestbook</center>
<body bgcolor="#FFFFFF" leftmargin="6" topmargin="3" marginwidth="6" marginheight="3">
<p align="center"><font size="2" face="Verdana, Arial, Helvetica, sans-serif">[Entries] 
  </font></p>
<hr size=2 width=350 color="#003366">
<form action="?page=gbook&cmd=post" method="post">
  </form>
  <div align="center">
    <table width="300" align="center">
      <tr> 
        <td> 
          <div align="right">
            <font face="Verdana, Arial, Helvetica, sans-serif" size="2" color="#FFFFFF"><b>name</b></font><font color="#FFFFFF">
            </font> 
          </div>
        </td>
        <td> 
          <input type="text" name="name" size="30">
        </td>
      </tr>
      <tr> 
        <td> 
          <div align="right"><font face="Arial" size="2" color="#FFFFFF"><b><font face="Verdana, Arial, Helvetica, sans-serif">email</font></b></font><font color="#FFFFFF">
            </font> 
          </div>
        </td>
        <td> 
          <input type="text" name="email" size="30">
        </td>
      </tr>
      <tr> 
        <td> 
          <div align="right">
            <font face="Verdana, Arial, Helvetica, sans-serif" size="2" color="#FFFFFF"><b>www</b></font><font color="#FFFFFF">
            </font> 
          </div>
        </td>
        <td> 
          <input type="text" name="www" size="30" value="http://">
        </td>
      </tr>
      <tr> 
        <td valign="top"> 
          <div align="right"><font face="Arial" size="2" color="#FFFFFF"><b><font face="Verdana, Arial, Helvetica, sans-serif"> 
            comments</font></b></font><font color="#FFFFFF"> </font> </div>
        </td>
        <td> 
          <textarea name="comments" rows="5" cols="26"></textarea>
        </td>
      </tr>
      <tr> 
        <td></td>
        <td> 
          <input type="submit" value="Sign " name="submit">
          <input type="reset" name="Clear it">
        </td>
      </tr>
    </table>
    <font face="Verdana, Arial, Helvetica, sans-serif" size="1" color="#FFFFFF"><br>
    <br>

</form>
</body>
</html>

You can find the guestbook at http://www.castlefm.net/?page=gbook

Cheers guys

tbach2

ummm, cant' tell much with just the html code:rolleyes:

I did notice

<form action="?page=gbook&cmd=post" method="post">

which could potentially be a problem in some browsers-- need to specify what page to post to.

No, wait a minute, that applies if you have a <base href="something"> in your html (which you don't).

Oh, well, can't do much without the code...

droms

here is the PHP CODE

<?
error_reporting(0);
include("config.php");

mysql_connect ($dbhostname , $dbusername , $dbpassword);
function addpost ($name,$email,$www,$comments) 
{
	global $guestbook;
	global $database;
	$now = time();
	mysql($database,"insert into ".$guestbook." values(null,\"$now\",\"$name\",\"$email\",\"$www\",\"$comments\")")or die(mysql_error());
}

if ($cmd == "post")
	addpost($name,$email,$www,$comments);

$postid = array();
$thenames = array();
$theemails = array();
$thewwws = array();
$thecomments = array();
$time = array();

$getentries = mysql($database,"select idnum,whenposted,name,email,www,comments from ".$guestbook." order by idnum desc");
while(list($postid[],$whenposted,$thenames[],$theemails[],$thewwws[],$thecomments[]) = mysql_fetch_row($getentries))
{
	$time[] = date("l, F d, Y @ h:ia", $whenposted);
}
$post_temp = implode("",file($posttemplate)); 

$onthispage = array();
if (!isset($whichpage))
		$whichpage = 1;

$pages = ceil(count($postid)/$postsperpage);	
$thepage = 1;
for($i = 0;$i<count($postid);$i++)
{
	if ($i < $postsperpage)
		$thepage = 1;
	if ($i/$postsperpage == $thepage)
		$thepage++;
	if ($thepage == $whichpage)
	{
		if ($thenames[$i] != "")
		{
			$entry = str_replace("[name]",$thenames[$i],$post_temp);
			$entry = str_replace("[email]",$theemails[$i],$entry);
			$entry = str_replace("[www]",$thewwws[$i],$entry);
			$entry = str_replace("[comments]",str_replace("\n","<br>",$thecomments[$i]),$entry);
			$entry = str_replace("[postnumber]",$postid[$i],$entry);
			$entry = str_replace("[timedate]",$time[$i],$entry);
			$entries .= $entry;
			unset($entry);
		}
	}
}

$entries .= "<font face=\"arial\" size=\"1\" color=\"#FFFFFF\">Pages : </a>";
for($i=1;$i<=$pages;$i++)
{
	$entries .= "<font face=\"arial\" size=\"1\" color=\"#FFFFFF\">[<a href=\"?whichpage=$i\">".$i."</a>] </font>\n";
}
$view_temp = implode("",file($displaytemplate));
echo str_replace("[Entries]",$entries,$view_temp);

?>

droms

I have fixed it🙂 Thanks for your help guys