javascript include does not work?

acidbox

I don't know if this is the proper place to ask this, but I'll ask it all the same. Here is my problem.

Basically, my .php files do not include files from jasvascript includes. For instance I have the following code:

Does Not Work:

<?php
do some php stuff
?>
<script language="JavaScript" SRC="includes/myscript.js"></script>
<?
do whatever
?>

Does Work:

<?php
do some php stuff
?>
<script language="JavaScript">
actual javacript that was inside the .js file
</script>
<?
do whatever
?>

So basically, If I just copy paste the .js file into my PHP file, it works fine, but if I set it to an include, it does not.

The pathing is correct, because If I view source and save the file as a .HTML file, it works fine on my local machine. Not sure why this is happening..

bad76

Hi,
try using type instead language.

...and you can't insert a php code in it...

synergypoint

I'm not sure what you mean when you say you can't put PHP in a JavaScript file but you can call a php file as JavaScript in a script tag as long as the output is valid JavaScript.

Here is what I mean...

There are only two requirements for this to work.

First, the location of the php file must be on a server that will process it as php.

Second, whatever the file jscript.php does, like get data from a database, it just needs to send any output in valid JavaScript format.

I found this very usefull for adding server side generated data like database output to plain old HTML pages that I didn't want to convert to PHP pages.

The need arose when I had to add a dynamic news database to a home page which was very well indexed with the search engines.

synergypoint

By the way, what you are trying to do will work.

I think the problem may be located in the "do whatever"part of your PHP.

It sounds like you might have some conditional statements that are causing PHP to skip that section with your call to JavaScript.

acidbox

All I am saying is that when I include a .js file, I get javascript errors in my browser saying that the functions in that file do not exist. Therefore none of my javascripts work. If, instead of including the .js file, I just paste its contents directly into the page, the scripts work fine. It has nothing to do with incorporating php in javascript. The only connection is that the .js file is being included into a .php file.

synergypoint

Well either your JavaScript file is not being included as you think because of a php coding error, or the file is being included but has a JavaScript error which prevents the functions from being created.

The most common JavaScript error I have found in including a JavaScript file which will prevent any of the JavaScript from running is to include the <SCRIPT> tag inside the included JavaScript file.

If your include looks like...

Then the actual file myscript.js needs to look like...

<!--

function jsfunction1(){
do_whatever
}

//-->

If you include the opening and closing <SCRIPT> tag in myscript.js it will behave as you have described.

Hope that helps.

acidbox

I don't know why this is happening, but it doesn't work.

If I Include the javascript file in the head it doesnt work
Doesn't Work
<SCRIPT TYPE="text/javascript" SRC="includes/myscript.js"></SCRIPT>

If I Just paste the javascript from the .js file like the following, it works fine.
Does Work
<script language="javascript">
<!--

function jsfunction1(){
do_whatever
}

//-->
</script>

There should be no difference, maybe it has something to do with the webserver, but I know it's not the script, because I have tried various javascripts writen by numerous people.

tbone-tw

Can you post more of the PHP code, and the .js file. That's probably the only way we're going to be able to figure out the problem.