Supplied argument not valid

[umol]

Hi all....

I am learning to make guestbook so I download the script from the site, but when I try it in my computer I got error message :

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in C:\Web\guest.php on line 34
query 1 failed

Here is the script :

<?php
// only change this include if you renamed the file
include ("config.inc.php");

//connect
// change localhost to your db host name
mysql_pconnect( "localhost", "$username", "$password")
or die( "Unable to connect to SQL server");
mysql_select_db( "$db_name") or die( "Unable to select database");

$numresults=mysql_query("SELECT name, email,comments FROM guestbook");
$numrows=mysql_num_rows($numresults)
or die ("query 1 failed");

if (empty($offset)) {
$offset=0;
}

$query = "SELECT name, date, email, comment FROM guestbook order by date DESC limit $offset,$limit";

$result = mysql_query ($query)
or die ("query 2 failed");

while ($row = mysql_fetch_row ($result))
{
for ($i = 0; $i < mysql_num_fields ($result); $i++)
{
if ($i > 0)
print ("<br>");

if ($i == 0){
print "<b>Name: </b>";

}
else if ($i == 1){
print "<b>Date: </b>";
}
else if ($i == 2){
print "<b>Email: </b>";
}
else{
print "<b>Comment:</b><br>";
}

print ($row[$i]); 

} 

print "<br><br><center><hr></center>";
print ("<P>");
}
if ($offset >= 3) {
$prevoffset = $offset - $limit;
print "<a href=\"guest.php?offset=$prevoffset\">PREV</a>&nbsp;\n";
}
$pages=intval($numrows/$limit);
if ($pages < ($numrows/$limit)){
$pages=($pages + 1);
}
for ($i = 1; $i <= $pages; $i++) {
$newoffset = $limit*($i-1);
if ($newoffset == $offset) {
print "$i&nbsp;\n";
} else {
print "<a href=\"guest.php?offset=$newoffset\">$i</a>&nbsp;\n";
}
}

//show next if not last
if (! ( ($offset/$limit) == ($pages - 1) ) && ($pages != 1) ) {
$newoffset = $offset+$limit;
print "<a href=\"guest.php?offset=$newoffset\">NEXT</a><p>\n";
}
?>

I dont know which one is wrong....any suggestion pls

thanks

[laserlight]

um, but you deliberately wrote your code so you would know which one is wrong...

$numresults=mysql_query("SELECT name, email,comments FROM guestbook");
$numrows=mysql_num_rows($numresults)
or die ("query 1 failed");

it would have been clearer to write that as:
$numresults=mysql_query("SELECT name, email,comments FROM guestbook")
or die("query 1 failed");
$numrows=mysql_num_rows($numresults);

[umol]

Hi.....

Like I said I didn't write the code... I downloade it
Well, but I have fixed the code like u told .....and it works ...🙂
very helpful..

many thanks