using 2 switch staements confusion

[forcer]

i have a page on my site which holds profiles

index.php?page=profiles

worked fine the page displayed a list of profiles to be clicked

i added another statement so that when a prifle was clicked it would look like this...

index.php?page=profiles&u=user

but ever since i added this extra statement all my pages have my 404 error page stuck on the bottom. and when i try to click a user it shows their profile underneath the original profile list page instead of changing..

here is the code i am using...

<?php  

if (!$page) { 
include 'home.php'; 
} elseif (file_exists($page.".php")) { 
switch ($page) {  

case 'home':  

include 'home.php'; 
break;
case 'about':
include 'about.php';
break;
case 'profiles':
include 'profiles.php';
break;
case 'audio':
include 'audio.php';
break;
case 'photos':
include 'photos.php';
break;
case 'videos':
include 'videos.php';
break;
case 'choons':
include 'choons.php';
break;
case 'guestbook':
include 'guestbook/index.php';
break;
case 'links':
include 'linksphp';
break;
case 'xtra':
include 'xtra.php';
break;
default:  

include '404.php'; 
} 
} else { 
include '404.php'; 
} 
switch ($u) {
case 'reflex':  

include 'profiles/reflex.php'; 
break;
default:  

include '404.php'; 
}
?>

and u can see the site at http://technovibe.digitalbreeze.net to understand better whats happening

[dankstick]

Try putting breaks after the ...

default:  

include '404.php';
break;

and check the dot in linksphp...

case 'links':
include 'links.php';
break; 

[dankstick]

as I look at it more the url
http://technovibe.digitalbreeze.net/index.php?page=profiles&u=reflex
has no 404 because of this bit of code you have

switch ($u) {
case 'reflex':  

include 'profiles/reflex.php'; 
break;
default:  

include '404.php'; 
} 

that is the problem, for sure

[tbone-tw]

I think you'll see the problem if you simplify the code first (and use some indentation):

if (!$page) { 
    include 'home.php'; 
} elseif (file_exists($page.".php")) { 
    switch ($page) {  

        case 'xxx:  

            // do something
            break;

    default:  
        // do something; 
} 
} else { 
    include '404.php'; 
}

switch ($u) {
    case 'reflex':  

        include 'profiles/reflex.php'; 
        break;
    default:  

        include '404.php'; 
} 
 

so....
if there is no $page, include home.php, then if there is no $u do the default case, which is include 404.php.

if there is a $page, include pagexxx.php, then if there is no $u do the default case, which is include 404.php.

if there is a $page, but the file does not exist, include 404.php, then if there is a user name is reflex include 404.php.

if there is a $page, but the file does not exist, include 404.php, then if there is no user include 404.php again.

You have some serious logic errors going on there.

[tbone-tw]

And for God's sake man, replace that whole giant switch statement with something more maintainable!!!!!

include($page.".php");

One line of code replaces that whole thing, and then you don't have to add a new case every time you add a new page. Of course, it won't work with that "guestbook/index.php", but that code already doesn't work anyway (see other errors below).

Other errors:

1. you check for file_exists($page.".php"), but then in the switch you have:

case 'guestbook':
include "guestbook/index.php";

So if page=guestbook, it would only hit that case if "guestbook.php" exists, and not "guestbook/index.php". And if guestbook.php does exist, you could still use my method above and just make guestbook.php a redirect.

2. you will only hit that giant switch if a matching file exists, so you probably never want to hit that 404.php page anyway. If you get in to that switch there must already be a file with the matching name, so just load it.

Other notes:

When you have both a page= and a u= set, do you want to display both pages?

[tbone-tw]

Try this (not sure if it is 100% what you are looking for, but your logic errors on the last one made it hard to tell exactly what you wanted:

if ($page || $u) {

if (file_exists($page.'.php')) {
    include($page.'.php');
} else {
    include('home.php');
}

if (file_exists($u.'.php')) {
    include('profiles/'.$u.'.php');
}

} else {
    include('404.php');
}

Now from looking at your original code, I assume that you want the profiles page to be displayed, with the specified profile to be displayed after it. (i.e. page=profile&u=reflex displays the profiles page followed by the reflex profile). If that's not the case then a few changes should take care of it.

Note that I haven't tested that code, it's just directly from my head, so there may be some problems.

PS. I looked at your HTML source and you are loading an entire HTML page into another page (i.e. with all the HTML , HEAD, etc tags). You really shouldn't be doing that.

[forcer]

<?php  

if (!$page) { 
	include 'home.php'; 
} elseif (file_exists($page.".php")) { 
	switch ($page) {  

		case 'home':  

		include 'home.php'; 
		break;
		case 'about':
		include 'about.php';
		break;
		case 'profiles':
		include 'profiles.php';
		break;
		case 'audio':
		include 'audio.php';
		break;
		case 'photos':
		include 'photos.php';
		break;
		case 'videos':
		include 'videos.php';
		break;
		case 'choons':
		include 'choons.php';
		break;
		case 'guestbook':
		include 'guestbook/index.php';
		break;
		case 'links':
		include 'linksphp';
		break;
		case 'xtra':
		include 'xtra.php';
		break;
	default:  

	include '404.php'; 
	} 
	} else { 
	include '404.php'; 
	} 
	switch ($u) {
		case 'reflex':  

		include 'profiles/reflex.php'; 
		break;
	}
?>

i am using this code which works apart from..

http://technovibe.digitalbreeze.net/index.php?page=profiles&u=reflex

can u see it has the profiles page and under neath it has the new page saying "palmers profile" how can i get it to change to the palmers profile page

[tbone-tw]

You may be using that code, but that doesn't mean it's going to work. With your current code you should get the following behavior:

Click on "Links" => 404
Click on "Guestbook" => 404

But I think you have changed your code since you posted that anyway. If you post your current code I'll take a look.

[forcer]

this is the code i am using now...

<?php  

if (!$page) { 
	include 'home.php'; 
} elseif (file_exists($page.".php")) { 
	switch ($page) {  

		case 'home':  

		include 'home.php'; 
		break;
		case 'about':
		include 'about.php';
		break;
		case 'profiles':
		include 'profiles.php';
		break;
		case 'audio':
		include 'audio.php';
		break;
		case 'photos':
		include 'photos.php';
		break;
		case 'videos':
		include 'videos.php';
		break;
		case 'choons':
		include 'choons.php';
		break;
		case 'guestbook':
		include 'guestbook.php';
		break;
		case 'links':
		include 'links.php';
		break;
		case 'xtra':
		include 'xtra.php';
		break;
		case 'contact':
		include 'contact.php';
		break;
	default:  

	include '404.php'; 
	} 
	} else { 
	include '404.php'; 
	}

switch ($u) {
	case 'reflex':  
	include 'profiles/reflex.php'; 
	break;
	case 'scottyg':
	include 'profiles/scottyg.php';
	break;
}
?>

[tbone-tw]

Okay, aside from the fact that I wish you would change that long switch to a simple:

include($page.'.php');

and that second switch to:

include('profiles/'.$page.'.php');

(which it looks like you're not going to do) the two problems I see is that the profile files are not being found. Can you do a:

$current = getcwd();
echo $current;

and post the output? The other problem I see is that your html includes two complete pages with two heads, two bodies, etc. Looks like the way you are building the pages is a bit wonky.

Nice graphics though!!

[Weedpacket]

Originally posted by tbone-tw
Okay, aside from the fact that I wish you would change that long switch to a simple:

include($page.'.php');

and that second switch to:

include('profiles/'.$page.'.php');

After of course checking to see that $page has a sensible value and actually does refer to a proper page (and not just some other page that happens to be in the directory: if you can be sure that those pages are the only ones in those directories it could be done).

[forcer]

<?php   

if (!$page) {  

    include 'home.php';  

} elseif (file_exists($page.".php")) {  

    switch ($page) {   

        case 'home':   

        include 'home.php'; break; 
        case 'about': 
        include 'about.php'; break; 
        case 'profiles': 
        include 'profiles.php'; break; 
        case 'audio': 
        include 'audio.php'; break; 
        case 'photos': 
        include 'photos.php'; break; 
        case 'videos': 
        include 'videos.php'; break; 
        case 'choons': 
        include 'choons.php'; break; 
        case 'guestbook': 
        include 'guestbook.php'; break; 
        case 'links': 
        include 'links.php'; break; 
        case 'xtra': 
        include 'xtra.php'; break; 
        case 'contact': 
        include 'contact.php'; break; 
    default:   

    include '404.php';  

    }  

    } else {  

    include '404.php';  

    } 


if (file_exists('profiles/'.$u.'.php')) {  

    switch ($u) { 
        case 'reflex':   

        include 'reflex.php'; break; 
        case 'scottyg':  

        include 'scottyg.php'; break; 
		case 'dannyf':
		include 'dannyf.php'; break;
		case 'forcer':
		include 'forcer.php'; break;
		case 'future':
		include 'future.php'; break;
		case 'icey':
		include 'icey.php'; break;
		case 'rebel':
		include 'rebel.php'; break;
		case 'pudd':
		include 'pudd.php'; break;
		case 'stryke':
		include 'stryke.php'; break;
    default:   

    include '404.php'; break;
	}
	}
?> 

i have expanded and changed my code a little...

still not working...

i aint that advanced with php so i am gunna need more help with it :s

[dankstick]

According to your code a $page and a $u must have a valid value or there will be a 404.

YOu may want...

if (file_exists('profiles/'.$u.'.php') && $u) {

instead of your....

if (file_exists('profiles/'.$u.'.php')) {

...in case there isn't a $u there.