Wierd!!!!!!!!

Napster

I have this in my script

elseif (!ereg("[0-9]{1,20}",$gold))

That is for a bank on my site, but it still accepts numbers with a - on it. How do I fix it?

Moonglobe

pot some more code please.let us see the reast of the if..elseif..else structure

Napster

here is part of the code that code is in

if ($action == deposit)
{
if ($gold == "")
{
echo "<body bgcolor='000000' text='ffffff'>";
exit("You cant deposit nothing");
}
elseif (!ereg("[0-9]{1,20}",$gold)) 
{
echo "<body bgcolor='000000' text='ffffff'><center>";
echo "<table border=1 width=300><tr><td><center>The Bank</td></tr>
<tr><td><center>You cant deposit that!</td></tr></table>";
die("");
}
elseif ($gold > $uinfo[money])
{
echo "<body bgcolor='000000' text='ffffff'><center>";
echo "<center><table border=1 width=300><tr><td><center>The Bank</td></tr>
<tr><td><center>Don't cheat you filthy little cheater!</td></tr></table>";
die("");
}
elseif ($gold <= $uinfo['money'])
{

Moonglobe

where are these variables coming from? what version of PHP are you using? is register_globals on?

Napster

php 4, yes it is on and $action is from the url, $gold is the money they are trying to deposit and $uinfo[money] is how much money they actually have

Moonglobe

well then, try this:

elseif (is_numeric($gold) && strlen($gold) <= 20)

Napster

I live in kamloops

but waht will that code u provided me with do/

Moonglobe

check if $gold contains only a numeric value, then check if its 20 or less digits.

Napster

ok thank you

drawmack

elseif (!ereg("^[0-9]{1,20}$",$gold))

what your old regex said was - if $gold contains 1 to 20 numerals. What this one says is if the first carater is a numeral and it is followed by 1 to 19 more numerals then it ends that's what the ^ and $ characters do. However this code will let you deposit 0 or 00 or 001 or you get the idea so I would recommend this code instead

elseif (!ereg("^[1-9][0-9]{0,19}$",$gold))

so that the first character must be between 1 and 9 followed by 0 to 19 more numerals then the end of the string.

Moonglobe

ahh yes.... sorry, my regex is kinda rusty...