Function help

furious5

I'm trying to tidy some code up and put it in a function, my problem is that I am only getting the first letter of a string back now.

The function I am using is this:

function Decoder($decode){ // Get URL Encoded Text held in an array and decode

$count=count($decode);

for ($i=0; $i<$count; $i++) {
	$decode[$i] = urldecode($decode[$i]);
	return ($decode[$i]);
}

}

I am calling the function like so:

	list($decode[$i]) = Decoder($location); // Decode the array, and return the string back to this page

echo "RESULT:$decode[$i]";

Initially I was justing echoing the values from the function, but need to be able to put them in an SQL statement hence having to return them.

Soon as I tried to return them back to the PHP page, I just get the first letter e.g All, comes back as A and so on.

Weedpacket

I think you'd want to put off returning until after you've finished the loop...

furious5

Nope that doesn't work.

laserlight

Assuming you already took the return statement out of the loop, then when you call the function, where does $i come from?

i.e.
list($decode[$i]) = Decoder($location);
echo "RESULT:$decode[$i]";

does not make any sense, since $i is undefined.
Even if it was defined, it would be equivalent to dealing with only 1 element from the array.

furious5

I half knew that taking the return out of the loop wouldn't work, but nothing ventured nothing gained.

What I cannot understand is that if I substitue the return, and echo the values the values are displayed no problem.

How would you suggest I go about this laserlight??

tekky

function Decoder($decode){ // Get URL Encoded Text held in an array and decode

$count=count($decode);

for ($i=0; $i<$count; $i++) {
	$decode[$i] = urldecode($decode[$i]);
	return ($decode[$i]);
}

}

Call it like this...:

	$decoded = Decoder($location); // Decode the array, and return the string back to this page

echo "RESULT: <pre>" .print_r($decoded). "</pre>";

You were telling Decode() to expect and treat the arg as an array, and passing it only 1 element of an array, IE a string not an array

so you were loopin through the letters A L L and returning A the first iteration which EXITS the function....

😉

furious5

Ah thanks for that.

We are getting there, the problem is that if I select multiple entries I only get the first value back e.g if I select All, North West, North East.

It only returns All, this being the the first value.

Any ideas, on this one??

tekky

woops I forgot to fix it all

here is the fixed code

function Decoder($decode){ // Get URL Encoded Text held in an array and decode

$count=count($decode);

for ($i=0; $i<$count; $i++) {
	$decode[$i] = urldecode($decode[$i]);
}
            return $decode;
}

Call it like this...:

	$decoded = Decoder($location); // Decode the array, and return the string back to this page

echo "RESULT: <pre>" .print_r($decoded). "</pre>";

furious5

Hmm

I'm still struggling to get my head around this.

The code provided will now print an array like this: Array ( [0] => All [1] => North West [2] => Scotland [3] => South East )

But how do I then get the values All, North West, Scotland, South East in to a string.

Basically I then want to put the location values in to an SQL statement??

Sorry if this is a simple question, but I haven't done any work with arrays before.

tekky

print_r is generally used for trouble shooting.. to ensure your arrays are setting how you want... that was hte only reason I used it there.... I assumed since you were making functions that used arrays... (or trying to anyways) that you had some idea what you were doing....

uhm...

for($i=0;$i<count($decoded);$i++)
{
     echo "array value $i: " . $decoded[$i] . '<br>';
}

furious5

Thanks for all your help with this, all my problems are solved!!