while/for loops

[tuf-web_co_uk]

i am trying to display a couple of records with php and mysql, and i want 'vs' in the middle of the two records

eg.

Record1 vs Record2

but when i try to do this i get

Record1 vs Record2 vs

using this code
<?
$sql = "SELECT DISTINCT match_id FROM `match` where event='monday'";
				$query = mysql_query($sql) or die (mysql_error());

			while ($m_m=mysql_fetch_array($query)) {

				$sql2 = "SELECT * FROM `match` WHERE match_id='".$m_m['match_id']."'";
				$query2 = mysql_query($sql2) or die (mysql_error());

				while ($m_m2=mysql_fetch_array($query2)) {

					$wid = $m_m2['wid'];
					$sql3 = "SELECT w_name FROM roster where id='$wid'";
					$query3 = mysql_query($sql3) or die (mysql_error());



					while ($m_m3=mysql_fetch_array($query3)) {

						echo $m_m3['w_name']." vs";

					}

				}

			}
?>

i know this is because of the while statement and i could fix this by using a for() statement but i cant quite figure out how

could someone please help?!

thanks 🙂

[drawmack]

<?php
$matches = array();
while ($m_m3=mysql_fetch_array($query3)) {
   array_push($matches,$m_m3['w_name']);
} //end while

echo implode (" vs. ",$matches);
?>

for further reference
http://www.php.net/implode

[tuf-web_co_uk]

hi

i implied the code to the rest of my script

and i got Record1Record2 without the .vs and without any spacer

is this natural?

thanks

[laserlight]

No, the code should not do that.

[Merve]

Originally posted by laserlight
No, the code should not do that.

drawmack's code looks good.

implode() can receive its arguments in either order. Try implode($matches, " vs. ") and see if that works.

[LordShryku]

Call me picky...but it looks like you could probably cut down the SQL statements to one, maybe two just joining the tables. Here's my feeble attempt at it, and spitting it out without using implode. Don't know if it'll work, but you're free to try..

<?
$sql = "SELECT DISTINCT match_id 
        FROM match 
        WHERE event='monday'";

$query = mysql_query($sql) or die (mysql_error());

while($m_m=mysql_fetch_array($query)) {
    $sql2 = "SELECT r.w_name
             FROM match m, roster r
             WHERE m.wid = r.id
             AND m.match_id = '".$m_m['match_id']."'";

$query2 = mysql_query($sql2) or die (mysql_error());

$top=2;
$var=0;

while($m_m2=mysql_fetch_array($query2)) {
    $var++;
    echo $m_m3['w_name'];

    if($var == $top) {
       $top += 2;
       echo "<br>";
    }
    else {
       echo " vs ";
    }
}
}
?>

hth

[tekky]

or just use your end variable "match1 vs match2 vs"

and do this

$var = substr($var,0,-3);

takes your variable starting at 0 (first char) and returns up to the 3rd char from the end, dropping the " vs"

[tuf-web_co_uk]

hey

i tried LordShryku's code and i got a mysql problem

then i tried tekkys code, and i got the same problem as with drawmacks code

Record1Record2

no vs what so ever!

any ideas?

thanks

[tekky]

you have to use mine with your ORIGINAL method that was giving you the bad code... not in conjunction with anyone elses fixes

just put my line AFTER all your looping is done, but before you use the var in anything else such as the echo

[tuf-web_co_uk]

i did try my original code with your suggestions like such

<?

			$sql = "SELECT DISTINCT match_id FROM `match` where event='monday'"; 
            $query = mysql_query($sql) or die (mysql_error()); 

            while ($m_m=mysql_fetch_array($query)) { 

                $sql2 = "SELECT * FROM `match` WHERE match_id='".$m_m['match_id']."'"; 
                $query2 = mysql_query($sql2) or die (mysql_error()); 

                while ($m_m2=mysql_fetch_array($query2)) { 

                    $wid = $m_m2['wid']; 
                    $sql3 = "SELECT w_name FROM roster where id='$wid'"; 
                    $query3 = mysql_query($sql3) or die (mysql_error()); 

                    $match = "";

                    while ($m_m3=mysql_fetch_array($query3)) { 

                 		$match .= $m_m3['w_name']." vs "; 

                    } 

                    // tekkys code here

                    $match = substr($match,0,-3);
                    echo $match;

                } 

            } 

		?>

[tekky]

I just tested my code...

<?
for ($i=0;$i<2;$i++)
{
	$var .= 'testing vs ';
}
$var = substr($var,0,-3);
echo $var;
?>

and it works fine...

what version of PHP are you using?

substr should work in anything from php3+

[tekky]

Consequently... try this..

<?

$sql = "SELECT DISTINCT match_id FROM `match` where event='monday'"; 
$query = mysql_query($sql) or die (mysql_error()); 

while ($m_m=mysql_fetch_array($query))
{ 
	$sql2 = "SELECT * FROM `match` WHERE match_id='".$m_m['match_id']."'"; 
	$query2 = mysql_query($sql2) or die (mysql_error()); 

while ($m_m2=mysql_fetch_array($query2))
{ 
  	$wid = $m_m2['wid']; 
	$sql3 = "SELECT w_name FROM roster where id='$wid'"; 
	$query3 = mysql_query($sql3) or die (mysql_error()); 
	$match = "";

	while ($m_m3=mysql_fetch_array($query3))
	{ 
        	$match .= $m_m3['w_name']." vs "; 
	} 
} 
} 

// tekkys code here
$match = substr($match,0,-3);
echo $match;

?>

executing the code after all the loops are done...

[tuf-web_co_uk]

hi, i am using 4.3.2

i tried the code you posted in your last post, and the output was only 1 record, and it was the second record

---

Record2

---

nothing else was displayed

[tuf-web_co_uk]

please help

[tekky]

Originally posted by tuf-web.co.uk
please help

if what I posted didnt work... you got some other issue...
make your script echo out EACH $match as it compiles the long variable... and then AFTER the substr() call... you probably have another issue...

[drawmack]

Try this

<?
// tekkys code here
$match = substr($match,0,(strlen($match)-3));
echo $match;
?>

[tekky]

Originally posted by drawmack
Try this

<?
// tekkys code here
$match = substr($match,0,(strlen($match)-3));
echo $match;
?>

[/B]

same as using substr($match,0,-3)

according to the docs... if substr() works negative length should work...