[Resolved] Header Error

dogboss

Hi,

I have page which both displays and checks a form. So, the user displays the page, fills in the form and clicks on submit. the post is to php_self so the page is called again. it figures out, by way of a hidden field, that it should be checking submitted data and, if there are errors, display them and redisplay the form.

If the data is 'clean' I've got a header statement which should redirect to a confirmation page.

But

If the data is clean, instead of redirecting, I get the folowing error:

Warning: Cannot modify header information - headers already sent by (output started at /home/balloo2/public_html/Flights.php:9) in /home/balloo2/public_html/FlightsCentre.php on line 84

Flights.php is the 'main' page which includes FlightsCentre.php - line 84 in FlightsCentre.php is the header statement.

Any help greatly appreciated.

laserlight

this means that somewhere, output is sent before the header call is made.

You cannot send output (e.g. writing html) before making a header call.

I suggest re-structuring the flow of your code, or if you really cannot do that, then use output buffering.

dogboss

Hi,

Tried moving the php code to b4 the <html> tag......same problem.

Have moved to to various places.....no difference, same error.

Here's the 'main page':

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "DTD/xhtml1-transitional.dtd">
<?php
include "./FlightsVal.php";
?>
<html>
<head>
<title>Santana Estates - The Costa del Sol's Premier Estate Agents</title>
<link rel="stylesheet" href="./3colstyles.css" type="text/css">
</head>
<?php
include "./pagehead.php";
include "./leftcontent.php";
include "./FlightsCentre.php";
include "./rightcontent.php";
?>
</body>
</html>

FlightsVal.php performs the validation and, theoretically, the redirect.

Here's FlightsVal.php:

<?php
if($action == "check") {

	if($HTTP_POST_VARS['DepDate']=="")	{
		$errors[] = "Please enter a Departure Date."; 
						}

	if($HTTP_POST_VARS['RetDate']=="")	{
		$errors[] = "Please enter a Return Date."; 
						} 

	if($HTTP_POST_VARS['Name']=="")	{
		$errors[] = "Please enter your name."; 
						} 

	if($HTTP_POST_VARS['Address']=="")	{
		$errors[] = "Please enter your address."; 
						} 

	if($HTTP_POST_VARS['PostCode']=="")	{
		$errors[] = "Please enter your Post Code."; 
							} 

	if($HTTP_POST_VARS['Country']=="")	{
		$errors[] = "Please enter your Country."; 
						} 

	if($HTTP_POST_VARS['Phone']=="")	{
		$errors[] = "Please enter your Phone No."; 
						} 

	if($HTTP_POST_VARS['Email']=="")	{
		$errors[] = "Please enter your Email address."; 
						} 

	$errcount=count($errors);

	if ($errcount == 0)	{
		header("Location: [url]http://www.balloonmessages.com/FormAction.php[/url]");
		exit;
				}

			}

Any more help greatly appreciated!!

tekky

you answered your own question right here...

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "DTD/xhtml1-transitional.dtd">

you cant have ANY output that the browser will see BEFORE the header() function is called

also, use

 tags to make your code more readable...

dogboss

tags?

wot do you mean?

groovything

Change this:

if ($errcount == 0) {
header("Location: http://www.balloonmessages.com/FormAction.php");
exit;
}

to this:

if ($errcount == 0) {
print "<script language='javascript'>window.location='http://www.balloonmessages.com/FormAction.php;</script>";
exit;
}

that should work for you. (red text all on one line)

tekky

Originally posted by dogboss
tags?

wot do you mean?

php tags....

echo "this would be php code... since its in [code=php] tags its hilited...";

tekky

consequently... this should work...

	<?php
		include "./FlightsVal.php";
	 ?> 		
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "DTD/xhtml1-transitional.dtd">
<html>
<head>
<title>Santana Estates - The Costa del Sol's Premier Estate Agents</title>
<link rel="stylesheet" href="./3colstyles.css" type="text/css">
</head>
<?
		include "./pagehead.php";
		include "./leftcontent.php"; 
		include "./FlightsCentre.php";
		include "./rightcontent.php";
	 ?> 		


</body>
</html>

FlightsVal.php performs the validation and, theoretically, the redirect.

Here's FlightsVal.php:

<?php 
	if($action == "check") {

	if($HTTP_POST_VARS['DepDate']=="")	{
		$errors[] = "Please enter a Departure Date."; 
						}

	if($HTTP_POST_VARS['RetDate']=="")	{
		$errors[] = "Please enter a Return Date."; 
						} 

	if($HTTP_POST_VARS['Name']=="")	{
		$errors[] = "Please enter your name."; 
						} 

	if($HTTP_POST_VARS['Address']=="")	{
		$errors[] = "Please enter your address."; 
						} 

	if($HTTP_POST_VARS['PostCode']=="")	{
		$errors[] = "Please enter your Post Code."; 
							} 

	if($HTTP_POST_VARS['Country']=="")	{
		$errors[] = "Please enter your Country."; 
						} 

	if($HTTP_POST_VARS['Phone']=="")	{
		$errors[] = "Please enter your Phone No."; 
						} 

	if($HTTP_POST_VARS['Email']=="")	{
		$errors[] = "Please enter your Email address."; 
						} 

	$errcount=count($errors);

	if ($errcount == 0)	{
		header("Location: [url]http://www.balloonmessages.com/FormAction.php[/url]");
		exit;
				}

			}
?>