Can som body please help me whit my forum problem!!

Chrysanthus

Hi im working on this forum now for like 4 vecks and it still cant get it to work.....

The problem is that when i select a topicID to go to it works fine but the problem is that i want all the post to be in the right topicid order......

Now i have manage to find the error but i do not know how to solve it,,,

The problem is that it dosent echo a TopicID after function.php and tha means that every thing just gets in the same sight!!

Sow far has nowbody figured ut how to solve it if the is som one

ihop some guru can help me with this one!

here are three files..

first file .. index.php

<?php
require( './functions.php');

showheader("Flamelines Topics");
?>

<TABLE BORDER=0 WIDTH=100% CELLSPACING=3 CELLPADDING=5>
<TR>
<TD>
<FONT COLOR="#000000" FACE="Arial,Verdana,Helvetica" size=-1>
<b>Forum Topics Bord: </b>
<BR>
<P>
<a href="add-topic.php"><FONT COLOR="#000000">Click here to make a topic</a>
</TD>
</TR>
</TABLE>
<P>
<TABLE BORDER=0 CELLSPACING=0 CELLPADDING=0 WIDTH=100%>
<TR VALIGN=TOP ALIGN=LEFT>
<TD WIDTH=100%>
<TABLE BORDER=0 BGCOLOR="#000000" CELLSPACING=1 CELLPADDING=1 WIDTH=100%>
<TR>
<TD BGCOLOR="#C0C0C0" WIDTH=100%>
<TABLE BORDER=0 CELLSPACING=0 CELLPADDING=5 WIDTH=100%>
<TR>
<TD>
<P><B><FONT COLOR="#000000" FACE="Trebuchet MS,Arial,Helvetica">Flamelines Topics</FONT></B>
</TD>
</TR>
</TABLE>
</TD>
</TR>
<?php
$topic_query = mysql_query("SELECT * FROM topics ORDER BY ID") or die (mysql_error());
while ($topic = mysql_fetch_array($topic_query)) {
?>
<TR>
<TD WIDTH=82% BGCOLOR="#FFFFFF" HEIGHT=28 VALIGN=TOP>
<TABLE BORDER=0 CELLSPACING=0 CELLPADDING=5 WIDTH=100%>
<TR>
<TD>
<P><FONT SIZE="+1" FACE="Trebuchet MS,Arial,Helvetica"><a href="view.php?topicID=<?php echo $topic['ID'] ?>"><?php echo $topic['TopicName'] ?></a></FONT>
</TD>
</TR>
</TABLE>
</TD>
</TR>
<?php
}
if (mysql_num_rows($topic_query) < 1) {
?>
<TR height=300>
<TD WIDTH=100% BGCOLOR="#FFFFFF" HEIGHT=28 VALIGN=TOP>
<CENTER><FONT SIZE="-1" FACE="Trebuchet MS,Arial,Helvetica">
<BR><B>There Are No Topics</B><BR><BR></CENTER>
</TD>
</TR>
<?php } ?>
</TABLE>
</TD></TR>
</TABLE>
<?php
showfooter();
?>

and the second file view.php

<?php
require( './functions.php');
viewpost ($topicID);

And the last file... functions.php

<?php

mysql_connect("**","","");
mysql_select_db("**");

function showheader($title) {
?>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">
<HTML>
<HEAD>
<TITLE> <?php echo $title ?> </TITLE>
</HEAD>

<BODY BGCOLOR="#FFFFFF">
<?php
}

function showfooter() {

?>
</BODY>
</HTML>
<?php
}

function viewpost ($topicID) {

$topic_query = mysql_query("SELECT topicname FROM topics WHERE ID='$topicID'") or die (mysql_error());
$topic = mysql_fetch_array($topic_query);
?>
<TABLE BORDER=0 WIDTH=100% CELLSPACING=3 CELLPADDING=5>
<TR>
<TD>
<FONT COLOR="#000000" FACE="Arial,Verdana,Helvetica" size=-1>
<b>Flameline Forum Bord</b>
<BR><?php echo $topic['TopicName'] ?>
<P>
<a href="index.php"><FONT COLOR="#000000">Return back to flamelines topics List</a>
<P>
<a href="add-post.php?topicID=<?php echo $topicID?>"><FONT COLOR="#000000">Make a new post</a>
</TD>
</TR>
</TABLE>
<P>
<TABLE BORDER=0 CELLSPACING=0 CELLPADDING=0 WIDTH=100%>
<TR VALIGN=TOP ALIGN=LEFT>
<TD WIDTH=100%>
<TABLE BORDER=0 BGCOLOR="#000000" CELLSPACING=1 CELLPADDING=1 WIDTH=100%>
<TR>
<TD COLSPAN=3 BGCOLOR="#C0C0C0" WIDTH=100%>
<TABLE BORDER=0 CELLSPACING=0 CELLPADDING=5 WIDTH=100%>
<TR>
<TD>
<P><B><FONT COLOR="#000000" FACE="Trebuchet MS,Arial,Helvetica">Topic Posts</FONT></B>
</TD>
</TR>
</TABLE>
</TD>
</TR>

<?php

// Läger upp postsen i ordning

$post_query = mysql_query("SELECT * FROM posts WHERE (TopicID='$topicID') ORDER BY TimeStamp") or die (mysql_error());
while ($post = mysql_fetch_array($post_query)) {
?>
<TR>
<TD WIDTH=82% BGCOLOR="#FFFFFF" HEIGHT=28 VALIGN=TOP>
<TABLE BORDER=0 CELLSPACING=0 CELLPADDING=5 WIDTH=100%>
<TR>
<TD>
<P><FONT SIZE="-1" FACE="Trebuchet MS,Arial,Helvetica"><?php echo $post['Post'] ?></FONT>
</TD>
</TR>
</TABLE>
</TD>
<TD WIDTH=18% BGCOLOR="#C0C0C0" VALIGN=TOP>
<TABLE BORDER=0 CELLSPACING=0 CELLPADDING=5 WIDTH=100% >
<TR>
<TD>
<P ALIGN=center><FONT SIZE="-1" FACE="Trebuchet MS,Arial,Helvetica" color=#000000>Posted By: <A HREF="mailto:<?php echo $post['Email'] ?>"> <FONT COLOR=#000000><?php echo $post['Name'] ?></A>
<BR><BR>
<A HREF="edit-post.php?postID=<?php echo $post['ID'] ?>"><FONT COLOR=#000000>Edit Your Post</FONT>
<BR><BR>
<A HREF="delete-post.php?postID=<?php echo $post['ID'] ?>"><FONT COLOR=#000000>Delete Your Post</FONT>
</TD>
</TR>
</TABLE>
</TD>
</TR>
<?php
}
if (mysql_num_rows($post_query) < 1) {
?>
<TR height=300>
<TD WIDTH=100% BGCOLOR="#FFFFFF" HEIGHT=28 VALIGN=TOP colspan=2>
<CENTER><FONT SIZE="-1" FACE="Trebuchet MS,Arial,Helvetica">
<BR><B>There Are No Posts Currently For This Topic</B><BR><BR></CENTER>
</TD>
</TR>
<?php } ?>
</TABLE>
</TD></TR>
</TABLE>
<?php
}

// Lägger till en post

function addpost () {
global $password,$email,$name,$post,$topicID;
$timestamp = time();
$new_password = addslashes($password); $new_email = addslashes($email);
$new_name = addslashes($name);
$new_post = addslashes(nl2br(htmlspecialchars($post)));
$insert = mysql_query("INSERT INTO posts VALUES ('NULL','$topicID','$new_name','$new_email','$new_password','$timestamp','$new_post')");
if (mysql_error() != "") {
showheader("MySQL Error ".mysql_error());
?>
<br><p><center><b>There was a MySQL Error -- <?php echo mysql_error() ?></b></center></p>
<?php
showfooter();
exit;
}
}

// Editerar en post

function editpost () {
global $postID,$post;
$new_post = addslashes(nl2br(htmlspecialchars($post)));
$insert = mysql_query("UPDATE posts SET post='$new_post' WHERE (ID='$postID')");
if (mysql_error() != "") {
showheader("MySQL Error ".mysql_error());
?>
<br><p><center><b><FONT SIZE="-1" FACE="Trebuchet MS,Arial,Helvetica">There was a MySQL Error -- <?php echo mysql_error() ?></b></center></p>
<?php
showfooter();
exit;
}
}

// Tar bort en post

function deletepost () {
global $postID;
$post_query = mysql_query("DELETE FROM posts WHERE (ID='$postID')");
if (mysql_error() != "") {
showheader("MySQL Error ".mysql_error());
?>
<br><p><center><b><FONT SIZE="-1" FACE="Trebuchet MS,Arial,Helvetica">There was a MySQL Error -- <?php echo mysql_error() ?></b></center></p>
<?php
showfooter();
exit;
}
}

// Lägger upp en topic

function addtopic () {
global $topicname;
$new_topicname = addslashes($topicname);
$topic_query = mysql_query("INSERT INTO topics VALUES ('NULL','$new_topicname')");
if (mysql_error() != "") {
showheader("MySQL Error ".mysql_error());
?>
<br><p><center><b><FONT SIZE="-1" FACE="Trebuchet MS,Arial,Helvetica">There was a MySQL Error -- <?php echo mysql_error() ?></b></center></p>
<?php
showfooter();
exit;
}
return mysql_insert_id();
}

bastien

newer versions of PHP require the use of $GET or $POST or $_REQUEST to access form data or LINK data...

so if the topicID is the value from the link

$TopicID = $_GET['TopicID'];

note: you didn't specifically say which one is function.php ( assumed it was the bottom one)

Chrysanthus

Functions.php was the last one....

and where should i specifiy that code stringe... In functons.php or in the view.php

bastien

both, i think....anywhere you are trying to use the value and it is not showing up....note that if you are passing it with the post method in a form you need to use $_POST

hth

Chrysanthus

I have tryed $POST AND $GET and $_REQUEST and still i cant keep the value after i get to view.php or i am makeing some error.... if i enter a stacic value it works but that's not god....

This is the value i wanna get see the index.php

<?php
$topic_query = mysql_query("SELECT * FROM topics ORDER BY ID") or die (mysql_error());
while ($topic = mysql_fetch_array($topic_query)) {
?>

bastien

you are also having a problem with the scope of the db connection string variables

they need to be added to each function
ie

function viewpost ($topicID) {

[b]mysql_connect("*****","***","***");
mysql_select_db("*****");[/b]


$topic_query = mysql_query("SELECT topicname FROM topics WHERE ID='$topicID'") or die (mysql_error());
$topic = mysql_fetch_array($topic_query);
?>

otherwise the function cannot see the connections

see here

Chrysanthus

thanks i check the link?? uhhh i read it and now i can say that im over my head now?

ill be back??🙁

Chrysanthus

Now i Know what is wrong but how do i get the varibel o the next page and sow on with out registering a global varibale!!

???? Please help some one?

bastien

i have taken a closer look at the pages and the design of the functions page concerns me most...what i prefer to do is to place function that are common to all pages (like a calculation or the showing of a product) that can be called from any page in the common.php or functions.php...

your functions page has a discreet set of functions that do not relate to each other and is probably the cause of most of your headaches...

i would suggest that each of the functions be placed into a different page where in one part you could show the form and the other have the php code to run the update. you will find it easier to manage the application that way, i know i do...

so we take the add-post.php for example:

if (!$_POST['submit']){
   show_entry_form();
}else{
   insert_data();
}
function show_entry_form()
{

//php and html code to show the form and allow the user to update the site

}

function insert_data()
{
//php code to accept the form data and shove into the db

//include the db connection page and data for the insert
require("dbconn1.php");

//get/set the variables for the post
$timestamp = time();
$new_password = addslashes($_POST['password']); 
$new_email = addslashes($_POST['email']);
$new_name = addslashes($_POST['name']);
$new_post = addslashes(nl2br(htmlspecialchars($_POST['post'])));

//create the query
$query =("INSERT INTO posts VALUES ('$topicID','$new_name','$new_email','$new_
password','$timestamp','$new_post')");

//run the query
$result=mysql_query($query,$conn) or die ("Can't process request because ".mysql_error());

//check the result of the query and post success or failure to user
//could consider redirection of user to another confirmation page 
//with a menu 
if ($result){
    echo "post successful";
}else{
    echo "post failed";
} //end if
}//end function
?>

note: I have played some with your files...if you want, send me your email and I can email them direct to you

my email:

bastien@bastienkoert.com

Chrysanthus

ahha integrate the functions in to the same pages like exampe add-topic.php add the topic function there and the same with add-post and sow on ....

that means i do not know how to start...

bastien

actually, you can use the template i showed above for this...all the pages other than index or viewpost can look like this...its not that difficult to adapt to what you need

Chrysanthus

yeah i know but i only have workt on my php for 2 month now sow im trying to learn .....

Am read two books sow om trying my beast..

i have never programed before but im god at networking and sow on TCP/IP and sow on....

I must say that im impressed by you programing i cant even compare my old code with your and it took to you only 1 day to make all of this...

for me it i dont wanna talk aboute it....

i tested the code but i cant get it to start...

Now error msg do i get and i cant view non pages at all!.....