newbie variable problems

Sul

As you've guessed I'm new to php! I'm trying to load an image in a webpage - depending upon the value of the variable. I have a variable that stores the url of the picture.

When the user clicks a link from a parent webpage it passes the variable a value

-i.e. page.php?pic=picture1

in the popup window (page.php) I have a php script with a switch statement saying that if pic == picture1 then set pic to whatever the path of picture1 is. Then further down in the code I have another php where <image src=<?php $pic ?>...> - something like that. I'm expecting the relevant picture to be displayed, but instead I get nothing...

I'm not sure if I'm doing this the right way, but if you have any ideas please can you help.

Thank you.

LordShryku

Right click and view the source of the popup page. Take a look and see if the image sourcelooks like it's supposed to.

Sul

I've done that, and it doesn't look like it's supposed to. The php script has been parsed though. It looks like

LordShryku

Okay, so let's see the code. It's obviously a coding issue.

Sul

Here's the code:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<title>View along the River Thames</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<link href="../../../style.css" rel="stylesheet" type="text/css">
<?php
switch ($pic)
{
case thames:
$pic = 'sights1L.jpg';
break;
}

?>
</head>

<body>
<table width="640" border="1" cellpadding="2" cellspacing="1" bordercolor="#000000">
<tr>
<td bordercolor="#0099CC"><?php print ("<img src=$pic width='640' height='480'>")?></td>
</tr>
<tr>
<td class="normaltext"><div align="center"><a href="javascript:window.close()" onmouseover="javascript:window.status='Close Window';return true" onmouseout="javascript:window.status'';return true" class="normaltext">Close</a></div></td>
</tr>
</table>
</body>
</html>

LordShryku

Okay, try changing your switch statement to this

switch ($_GET['pic']) { //$_GET to specify it's a GET var
   case "thames": //note the quotes....
      $pic = "sights1L.jpg";
      break;
}

Sul

It worked! Thanks! The only thing now is that I don't understand why you have to use GET? Could you please explain it to me. Thanks so much.

Also, what if I did this another way, by doing page.php?pic=picurl, where picurl is the url of the actual picture, and then on the pop up page I just put in the same php code, except for the bit in the header. Would this work? Would I still need to use GET?

LordShryku

Well, I'm guessing you probably don't need it. Take a look at the manual for register_globals. You could also search the forums. Tons of discussion about it.