Query Problem

takeanu

hi i'm having a query update problem, i have a form where a user can update but doesn't seem to work. please help . thanks in advance.

if (session_is_registered("loginUsername"))
{
$BREWid = getBrewersID($loginUsername, $connection);

$query = "UPDATE wine_entries SET ".
"wine_entry = \"" . $formVars["wine_entry"] . "\", " .

"wine_year = \"" . $formVars["wine_year"] . "\", " .
"wine_name = \"" . $formVars["wine_name"] . "\", " .
"wine_ingredient = \"" . $formVars["wine_ingredient"] . "\", " .
" WHERE wine_id = " . $wine .
" AND brewers_id = $BREWid" .
" AND wine_class = '$class'";

}
else
header("Location: login.php");

this is the update, but i keep getting
Check the manual that corresponds to your MySQL server version for the right syntax to use near 'WHERE wine_id = 1 AND brewers_id = 26 AND wine_class = 'H'' at (# 256).
don't know what to do. thanks

LordShryku

You have a comma at the end of this line
"wine_ingredient = \"" . $formVars["wine_ingredient"] . "\", " .
It shouldn't be there

takeanu

thanks but it doesn't work, don't know why i've tried many combinations too like
$query = "UPDATE wine_entries SET ".
"wine_entry = \"" . $formVars["wine_entry"] . "\"," .

"wine_year = \"" . $formVars["wine_year"] . "\"," .
"wine_name = \"" . $formVars["wine_name"] . "\"," .
"wine_ingredient = \"" . $formVars["wine_ingredient"] . "\"," .
" WHERE wine_id = \"" . $wine . "\"" .
" AND wine_class = \"" .$class . "\"" .
" AND brewers_id = $BREWid";

and

LordShryku

Your comma is still there. You can't have a comma on the last update statement before the WHERE clause because it will look for something else to update.

"wine_ingredient = \"" . $formVars["wine_ingredient"] . "\"--->,<---" .

jweissig

hi,

Here is a good debug tip for you. When creating complex SQL querys that spam many lines use a print($sql) statement so that you can see what is being sent to the database.

You problem is that you have a "," before the WHERE that breaks the sql command. Try this

$query = "UPDATE wine_entries SET " . 
"wine_entry = \"" . $formVars["wine_entry"] . "\", " . 
"wine_year = \"" . $formVars["wine_year"] . "\", " . 
"wine_name = \"" . $formVars["wine_name"] . "\", " . 
"wine_ingredient = \"" . $formVars["wine_ingredient"] . "\"" . 
" WHERE wine_id = $wine " . 
" AND brewers_id = $BREWid" . 
" AND wine_class = '$class'";

let me know if that works.. you can also use something like this

$query = "UPDATE wine_entries SET " . 
"wine_entry = '$formVars["wine_entry"]', " . 
"wine_year = '$formVars["wine_year"]', " . 
"wine_name = '$formVars["wine_name"]', " . 
"wine_ingredient = '$formVars["wine_ingredient"]' " . 
"WHERE wine_id = $wine " . 
"AND brewers_id = $BREWid " . 
"AND wine_class = '$class'";