Check User To Database

fire_cracker

I'm working on my first member's area for a website, and I am having a little trouble getting my check user script to work. It is telling me that there is an error in a line of my code, that seems alright to me. I've been pulling my hair out trying to figure out what the problem is. Let me know if you guys have any ideas, as to what I need to change to make the code work (btw, I'm getting a parse error).

<?
session_start();

include("db.inc");

$username = $_POST['username'];
$password = $_POST['password'];

if((!$username) || (!password)) {
echo "Please enter ALL of the information! <br />";
include("login_form.html';
exit();
}

$password = md5($password);

//This is the line that is giving me trouble.
$sql = mysql_query("SELECT * FROM users WHERE username='$username' AND password='$password' AND activated='1'");
$login_check = mysql_num_rows($sql);

if($login_check > 0) {
while($row = mysql_fetch_array($sql)){
foreach($row AS $key => $val){
$$key = stripslashes($val);
}

session_register('first_name');
$_SESSION['first_name'] = $first_name;
session_register('last_name');
$_SESSION['last_name'] = $last_name;
session_register('email_address');
$_SESSION['email_address') = $email_address;
session_register('special_user');
$SESSION['user_level'] = $user_level;

mysql_query("UPDATE users SET last_login=now() WHERE userid='$userid'");

header("Location: login_success.php");
}
} else {
echo "You could not be logged in! Either the username and password do not match or you have not validated your membership!<br />
Please try again! <br />";
include("login_form.html");
}
?>

LordShryku

Yeah, hey, why don't ya let us know what the actual error is and on what line?

Nevermind. Here's your error

include("login_form.html';

fire_cracker

alright, that fixed the script, but now their is another problem that I am dealing with. For some reason the script isn't posting the username to the script. I've changed it a little bit, so that I could try and figure out the problem, but allas, my newbieness has won the battle again. Here is what I have for the checkuser.php now:

<?
session_start();

include("db.inc");

$username = $_POST['username'];
$password = $_POST['password'];

if((!$username) || (!$password)) {
echo "Please enter ALL of the information! <br />";
echo $username;
echo "<br />";
echo $password;
echo "<br />";
include("login_form.html");
exit();
}

$password = md5($password);

$sql = mysql_query("SELECT * FROM users WHERE username='$username' AND password='$password' AND activated='1'");
$login_check = mysql_num_rows($sql);

if($login_check > 0) {
while($row = mysql_fetch_array($sql)){
foreach($row AS $key => $val){
$$key = stripslashes($val);
}

session_register('first_name');
$_SESSION['first_name'] = $first_name;
session_register('last_name');
$_SESSION['last_name'] = $last_name;
session_register('email_address');
$_SESSION['email_address'] = $email_address;
session_register('special_user');
$SESSION['user_level'] = $user_level;

mysql_query("UPDATE users SET last_login=now() WHERE userid='$userid'");

header("Location: login_success.php");
}
} else {
echo "You could not be logged in! Either the username and password do not match or you have not validated your membership!<br />
Please try again! <br />";
include("login_form.html");
}
?>

And here is the form that is passing the information to the script:

<html>
<body>
<center>
<form action="checkuser.php" method="post">
<table width="50%" border="0" align="center" cellpadding="4" cellspacing="0">
<tr>
<td width="22%">Username</td>
<td width="78%"><input name="username" type="text"></td>
</tr>
<tr>
<td>Password</td>
<td><input name="password" type="password"></td>
</tr>
</table>
<input type="submit" name="submit" value="Submit"></td>
</form>
</center>
</body>
</html>

When I execute the script, it is giving me the first error (Please enter all the information), and then it is only echoing back my password, but not the username. What is wrong here?

Thanks for the help guys.

stangoe

your code is fine, as far as I can see.....

I tried it on my server and works fine......

a good way to see if the variable is being passed correctly is to change "post" to "get" in the form method. Then check the url line to see what is being passed to the script.

hope this was some help

LordShryku

Here's a good way to debug it...

<? 
session_start(); 
include("db.inc"); 

/* 
  Print the entire POST array.
  If the username is not in there, 
  it's your form
*/
echo "<pre>";
print_r($_POST);
echo "</pre>";


$username = $_POST['username']; 
$password = $_POST['password']; 

/*
  Split up the error checking.
*/

if(!isset($username)) {
   echo "Username not set";
}

if(!isset($password)) {
   echo "Password not set";
}
?>