[Resolved] help with code

john2k

This script is causing the entire page not to load. I'm not very experienced with PHP & had to reference my PHP book a few times to put this script together. I just can't seem to get it working. The HTML page loads when this code is not on the page, so the problem must be somewhere in the script.

Can anyone see where I messed up?

Thanks,

John

<?php

switch ($do) {

case "submit":

// check for errors
	if ($sender_email == "") || ($sender_email != $sender_email_confirm) || ($message == "") {

		if ($sender_email == "") {
			echo "
<font color=red>Message Error: Your did not enter an email address.  Please enter an email address and resubmit your message.</font><br><br>
				";
			}

		if ($sender_email != $sender_email_confirm) {
			echo "
<font color=red>Message Error: Your email address and confirmed email address do not match.  Please correct this and resubmit your message.</font><br><br>
				";
			}

		if ($message == "") {
			echo "
<font color=red>Message Error: You did not include a message.  Please enter a message and resubmit.</font><br><br>
				";
			}

echo "
Fill out the form below and press the <b>Submit Your Message</b> button.<br><br>

<form method=\"POST\" action=\"contact_us.php?do=submit\">

<b>Your Name:</b><br>
<input type=\"text\" name=\"sender_name\" size=50 value=\"$sender_name\"><br><br>

<b>Your Email Address:</b><br>
<input type=\"text\" name=\"sender_email\" size=50 value=\"$sender_email\"><br><br>

<b>Confirm Your Email Address:</b><br>
<input type=\"text\" name=\"sender_email_confirm\" size=50 value=\"$sender_email_confirm\"><br><br>

<b>General Topic of Message:</b><br>
<select name=\"topic\" value=\"$topic\">
<option value=\"Comment, Question or Suggestion\">Comment, Question or Suggestion</option>
<option value=\"Technical Issue\">Technical Issue</option>
<option value=\"Advertising\">Advertising</option>
<option value=\"Business Development\">Business Development</option>
<option value=\"Other\">Other</option>
</select><br><br>

<b>Subject:</b><br>
<input type=\"text\" name=\"subject\" size=50 value=\"$subject\"><br><br>

<b>Type Your Message Below:</b><br>
<textarea name=\"message\" cols=50 rows=10 value=\"$message\"></textarea><br><br>

<input type=\"submit\" value=\"Send Your Message\">

</form>
";

exit;
		}				

// send message and let sender know message was successful

	mail("me@mydomain.com", "$subject", "$message", "From: \"$sender_name\" <\"$sender_email\">\n");

echo"
<h2>Your message was submitted successfully.  Thank you for contacting us.  We will reply as soon as possible.</h2>
";

break;

default:

echo "
<b><font size=+2>Contacting us is easy!</font></b><br>
Fill out the form below and press the <b>Submit Your Message</b> button.<br><br>

<form method=\"POST\" action=\"contact_us.php?do=submit\">

<b>Your Name:</b><br>
<input type=\"text\" name=\"sender_name\" size=50><br><br>

<b>Your Email Address:</b><br>
<input type=\"text\" name=\"sender_email\" size=50><br><br>

<b>Confirm Your Email Address:</b><br>
<input type=\"text\" name=\"sender_email_confirm\" size=50><br><br>

<b>General Topic of Message:</b><br>
<select name=\"topic\">
<option value=\"Comment, Question or Suggestion\">Comment, Question or Suggestion</option>
<option value=\"Technical Issue\">Technical Issue</option>
<option value=\"Advertising\">Advertising</option>
<option value=\"Business Development\">Business Development</option>
<option value=\"Other\">Other</option>
</select><br><br>

<b>Subject:</b><br>
<input type=\"text\" name=\"subject\" size=50><br><br>

<b>Type Your Message Below:</b><br>
<textarea name=\"message\" cols=50 rows=10></textarea><br><br>

<input type=\"submit\" value=\"Send Your Message\">

</form>
";

}
?>

planetsim

I have a few suggestions

Use $POST on posted data
Use $GET when the page hasnt been posted via a form.

I have a feeling your $do is suppose to incorporate $POST and $GET and probably the reason no HTML is being shown.

mcrbids

Try changing the switch) line...

Originally posted by john2k
<?php

switch ($_REQUEST[do]) {

// SNIP // 

case "submit":
[/B]

john2k

Thanks for the help. I rewrote my script piece by piece fixing any errors along the way as they appeared (I kept running the script in between adding new code). Doing that helped me to get any other errors out. Both of your suggestions above were useful and I did wind up using the $_GET for the switch to get the 'do' variable.

This issue has been resolved. Thanks again.