Upload and Rename image file using autoincrement

[volitan]

Hello all,

I am very new to php but I have coded most of a script for my site to have a Saltwater Aquarium Fish and corals Database.. I am stuck at the picture uploading and renaming part.. the following code doesn't give any errors but it also doesnt upload a picture either.. I am not sure what I am doing wrong and every example I look at seems to confuse me even more.. so if anyone can point out to me whats wrong with the following code I would be happy as a pig in ****. 🙂

        $sql = "INSERT INTO ".$prefix."_tri_profiles (category,scientific,common,description,origin,size,temp,sg,diet,ph,hardy,skill) VALUES ('$category','$scientific','$common','$description','$origin','$size','$temp','$sg','$diet','$ph','$hardy','$skill')";

   	$result = mysql_query($sql);
    $id  = mysql_insert_id();
    $jpg = $id.".jpg";
    $base_dir = "C:\apache\htdocs\nuke\images\profiles";

      if ($_FILES['image']['type'] != 'image/gif') {

    copy($_FILES['image']['tmp_name'], "$base_dir/$jpg");

       header("Location: admin.php?op=profiles");
     }
    } 

[volitan]

ok for some reason this board is pulling the backslashes out of my code.. the basedir line actually looks like

$base_dir = "C:\apache\htdocs\nuke\images\profiles";

[Merve]

Read this helpful article: http://www.developer.com/lang/php/article.php/1456041

[volitan]

thanks.. was a good read and another great example.. but can you see a reason to why my current code doesn't work? I need an expert to look at it and see if they can see why it doesn't work. I am not asking for a free script.. just some help 🙂

Thanks Much

[marque]

It's always good to put some error checking in your code.

copy returns true or false, so you can do:

if(copy(src,dst)) {
   echo "it worked";
}
else {
   echo "it didn't work!";
}

Thought your problem may lie in your form it's self. Is the form set to a multi part data form. If not it should be.

eg <form enctype="multipart/form-data">

[volitan]

Nope.. had that in the form already.. my form works for everything other then the pic upload.. which is on the bottom of this form..

// Profile Creation
OpenTable();
echo "<br><br><b>Add Profile Below<br><br></b>
<table width=\"326\">
<form action=\"admin.php?op=profiles\" method=\"post\" enctype=\"multipart/form-data\">
<TR>
<TD valign=top bgcolor=\"#EEEEEE\"><b>Category:</b></TD>
<TD valign=top bgcolor=\"#EEEEEE\">

			&nbsp;<select name=\"category\">

			<option value='' selected>Select Category</option>";

			$result0 = mysql_query("select * from ".$prefix."_tri_category where parent='0'");
             while ($row0=mysql_fetch_assoc($result0)) {

       echo "<option value=\"$row0[id]\">$row0[species]</option>";

	   $result1 = mysql_query("select * from ".$prefix."_tri_category where parent='$row0[id]'");

       while ($row1=mysql_fetch_assoc($result1)) {

          echo "<option value=\"$row1[id]\">- $row1[species]</option>";

	      $result2 = mysql_query("select * from ".$prefix."_tri_category where parent='$row1[id]'");

       	  while ($row2=mysql_fetch_assoc($result2)) {

       	     echo "<option value=\"$row2[id]\">-- $row2[species]</option>";

	         $result3 = mysql_query("select * from ".$prefix."_tri_category where parent=\"$row2[id]\"");

             while ($row3=mysql_fetch_assoc($result3)) {

       		    echo "<option value=\"$row3[id]\">--- $row3[species]</option>";
	         }
		  }
	   }
	}
    echo "</select></TD>

       <TR><TD valign=top bgcolor=\"#FFFFFF\"><b>Common:</b></TD>
			<TD valign=top bgcolor=\"#FFFFFF\"><input type=\"text\" name=\"common\" size=\"35\" value=\"\"></TD>
		</TR><TR>
			<TD valign=top bgcolor=\"#EEEEEE\"><b>Scientific:</b></TD>
			<TD valign=top bgcolor=\"#EEEEEE\"><input type=\"text\" name=\"scientific\" size=\"35\" value=\"\"></TD>
		</TR>
                <TR><TD valign=top bgcolor=\"#FFFFFF\"><b>Origin:</b></TD>
			<TD valign=top bgcolor=\"#FFFFFF\"><input type=\"text\" name=\"origin\" size=\"35\" value=\"\"></TD>
		</TR><TR>
			<TD valign=top bgcolor=\"#EEEEEE\"><b>Size:</b></TD>
			<TD valign=top bgcolor=\"#EEEEEE\"><input type=\"text\" name=\"size\" size=\"35\" value=\"\"></TD>
		</TR><TR>
			<TD valign=top bgcolor=\"#FFFFFF\"><b>Temp:</b></TD>
			<TD valign=top bgcolor=\"#FFFFFF\"><input type=\"text\" name=\"temp\" size=\"35\" value=\"\"></TD>
		</TR><TR>
			<TD valign=top bgcolor=\"#EEEEEE\"><b>Specific Gravity:</b></TD>
			<TD valign=top bgcolor=\"#EEEEEE\"><input type=\"text\" name=\"sg\" size=\"35\" value=\"\"></TD>
		</TR>
      <TR><TD valign=top bgcolor=\"#FFFFFF\"><b>Diet:</b></TD>
			<TD valign=top bgcolor=\"#FFFFFF\"><input type=\"text\" name=\"diet\" size=\"35\" value=\"\"></TD>
		</TR><TR>
			<TD valign=top bgcolor=\"#EEEEEE\"><b>PH:</b></TD>
			<TD valign=top bgcolor=\"#EEEEEE\"><input type=\"text\" name=\"ph\" size=\"35\" value=\"\"></TD>
		</TR>          <TR><TD valign=top bgcolor=\"#FFFFFF\"><b>Hardiness:</b></TD>
			<TD valign=top bgcolor=\"#FFFFFF\"><form method=\"post\" action=\"admin.php?op=profiles\"><select name=\"hardy\">
                <option value=\"Very Hardy(Good Beginner)\">Very Hardy(Good Beginner)
                <option value=\"Moderately Hardy (requires special care)\">Moderately Hardy (requires special care)
                <option value=\"Not Hardy (experienced only)\">Not Hardy (experienced only)</select></TD>
		</TR><TR>
			<TD valign=top bgcolor=\"#EEEEEE\"><b>Skill Level:</b></TD>
			<TD valign=top bgcolor=\"#EEEEEE\"><form method=\"post\" action=\"admin.php?op=profiles\"><select name=\"skill\">
                <option value=\"1-Easy\">1-Easy
                <option value=\"2-Easy\">2-Easy
                <option value=\"3-Easy/moderate\">3-Easy/Moderate
                <option value=\"4-Easy/moderate\">4-Easy/Moderate
                <option value=\"5-Moderate\">5-Moderate
                <option value=\"6-Moderate/Difficult\">6-Moderate/Difficult
                <option value=\"7-Moderate/Difficult\">7-Moderate/Difficult
                <option value=\"8-Difficult/Very-Difficult\">8-Difficult/Very-Difficult
                <option value=\"9-Very-Difficult\">9-Very-Difficult
                <option value=\"10-Extremely-Difficult\">10-Etremely Difficult</select>
                </TD>
		</TR><TR>
			<TD COLSPAN=2 width=\"318\">You may use standard html to jazz up the descriptions.</TD>
		</TR>
        <TR><TD valign=top><b>Description:</b></TD>
			<TD valign=top>&nbsp;<textarea name=\"description\" cols=\"35\" rows=10>No Description At This Time</TEXTAREA></TD>
		</TR>			<TR>
			<TD valign=top bgcolor=\"#FFFFFF\"><b>Image:</b></TD>
			<TD valign=top bgcolor=\"#FFFFFF\">&nbsp;<input type='file' name='image'></TD>
		</TR>
        <TR><TD colspan=2 width=\"318\">
        <input type=\"hidden\" name=\"op\" value=\"add_profile\">
        <input type=\"submit\" value=\"Add Profile\"></TD>
		</TR>
	</form>
	</TD></TR></TABLE>";

[marque]

you know you have this:

<form method=\"post\" action=\"admin.php?op=profiles\"> twice in the middle of your html without any close tags and inside the main form!?

[volitan]

will that make it not work? cause the rest of that form does work..

[marque]

i don't know why the form is working with that in there, html is very forgiving like that.

I could imagine that it is overwriting the origional form tag with the multipart.

try on the return script to print_r($_FILES) if you get an empty array, the file upload isn't comming through.

[procoder]

to use backslashes, u have to have them twice, else it tries to parse them

change

$base_dir = "C:\apache\htdocs\nuke\images\profiles";

to

$base_dir = "C:\apache\htdocs\nuke\images\profiles";

if that doest help, at the top of the script add this:

error_reporting(E_ALL);

this will make it show errors;

[volitan]

I can't make heads or tails of this.. it's getting very frustrating.. I guess I am just a dumb @ss.. 🙁

[marque]

Another thing i forgot to tell you is to make sure you have the correct permissions set. unix systems you need your permissions set to 777, i'm not sure on windows though.

[volitan]

I figured it out.. I didn't have all the variables listed in my function otherwise the code I had does work.. 🙂 so I am not as stupid as I thought.. just kinda stupid.. But thanks everyone for the help you offered.. 🙂

Now more features can be added to my script .. (just what I need)