Need a more efficient loop idea

[skeetley]

Hi, here is what I have:

for ($i = 0 ; $i < count($FileArray); $i++)	
{
	if ($FileArray[$i][0] == YPY) 
	{
	PrintRow();
	}
}

This works fine except that I need to do that if statement repeatedly.

I need to do the if statement if FileArray = YPY, then after it completes the if loop I need it to do it again, if FileArray = YSM, then i need it do it again, if FileArray = WWC, etc, etc. However, the FileArray is not in the right order of how I need to display the rows so continuing the for loop won't work. I can do it like below but there has to be a better way. Any suggestions? Thanks to LordShryku for all his past help.

for ($i = 0 ; $i < count($FileArray); $i++)	
{
	if ($FileArray[$i][0] == YPY) 
	{
	PrintRow();
	}
}
for ($i = 0 ; $i < count($FileArray); $i++)	
{
	if ($FileArray[$i][0] == YSM) 
	{
	PrintRow();
	}
}
for ($i = 0 ; $i < count($FileArray); $i++)	
{
	if ($FileArray[$i][0] == WWC) 
	{
	PrintRow();
	}
}

etc, etc, etc....

Shayne

[Wynder]

You could do something like:

for ($i = 0 ; $i < count($FileArray); $i++)     

{ 
    switch($FileArray[$i][0])
    {
        case "YPY":
           PrintRow();
           break;
        case "YSM":
           PrintRow();
           break;
        case "WWC":
           PrintRow();
           break;
    }
}

[skeetley]

Thanks for the code Wynder, but it doesn't quite fit what i need. I never knew of switch/case before so I can apply that elsewhere. But in this case the FileArray is sorted alphabetically at the source. My if variables though have to be printed out in a certain order and they are from all over the alphabet. Any other ideas?

Shayne

[lazzerous]

If all you're looking to do is have less lines of code, you can go this route:

$results_array = array('YPY','YSM','WWC','etc');

for ($i=0; $i<sizeof($results_array); $i++)
    {
    for ($j=0; $j<sizeof($FileArray); $j++)
        {
        PrintRow();
        }
    }

-=Lazzerous=-

[drawmack]

you're using string constants and haven't told us what those constants represent. So I'll code a generic solution that works no matter what the values of the constants are.

<?php

$constants = array(YPY=>1,YSM=>2,WWC=>3):

//count is expensive you only want to execute it once
$ary_length = count($FileArray);

//create a one dimensional array with the same keys as
//the original array and the value of this element's
//constant from the constants array
for($i=0;$i<$ary_length;$i++) {
    $TempAry[$i] = $constants[$ThisFile[0]]; 
} //end for

//sort the new array based on the value of the constants
//and maintain key association
$TempAry = arsort($TempAry);

//get the keys from the sorted temp array into a new array
$TempAry = array_keys($TempAry);

//echo the files array in the sorted order
for($i=0;$i<$ary_length;$i++) {
    PrintRow($FileArray[$TempAry[$i]]);
} //end for

While this method implements two for loops it is still more efficient then the original for two reasons
1) it only executes count once
2) there is not a single if statement in the code