Looking for ways to speed up this code..

[laeelin]

I have a script that parses visitor logs, and the section that is looking at the url they are comeing from is takeing to long to run..

This is the function:

Function URLtracker($url)
{
// $url containes url's.. like this:"https://books.com/folder/page.htm
global $UrlList;
	if(strlen($url)>5){// makes sure something is there
		$url=parse_url($url);

// because you can use "." in a vailable, i replace it with "_"

	$url=str_replace('.', '_', $url['host']); 
	if(isset($UrlList[$url])){

// url already is listed, adds one to the number of times used

		$UrlList[$url]++; 
	}else{

//new url, add it to the array

		$UrlList[$url]=1;
	}
}

}

I'm trying to learn better habits, but still ahve a long way to go..

any suggestions for speeding this up?

thanks
Laeelin

[drawmack]

The only way I see to speed this up is to get rid of the if statement but splitting this into two functions.

1) creates UrlList array with a list of unique hosts all being set to 0

2) count the hosts and just increment the appropriate field in UrlList

[PHPGuru2]

Don't see any reasons that you should try to rewrite this function to speed up the process.... If it takes 5 seconds to process this function then yeah, you should think other way to write it, but you are talking about the speed in miliseconds I think....

There are things that help you to write a better code.
PHP offers different ways to write, for example, a looping an array. There are while(), foreach(), for(), and so on. Test them and see which one is actually the fastest way to loop an array with a lot of values in it. If you find the fastest one, then alwys use that to process loop and you can actually save a lot of time.
Usually people write same code such as loop over and over again in different places and they add up really fast, so you can end up spending a lot of time processing a stupid thing...

I hope this helps.

P.S. There are softwares to speed up the process such as Zend Optimizer. You should consider installing it, it really speeds up PHP.