[Resolved] sql query, not sure on the problem

[helz]

SELECT * FROM site_downloads_dir
Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/hell/public_html/bowling/modules/Downloads.php on line 116

if a database table is empty that shouldnt cause the error?

	$getdir = "SELECT * FROM $dirtbl";
	echo $getdir;//this is correct
	$getdir = mysql_query($getdir);// get info from db
	while ($getdir = mysql_fetch_array($getdir)) {// output info from the db==-=-=-=-=-=-=-=THIS IS LINE 116-=-=-=-=
		extract($getdir);// convert field names into variables
		$sumofdls = mysql_num_rows(mysql_query("SELECT dlid FROM $dltbl WHERE dldid='$did' "));
		echo "Directory: <a href='$modules&did=$did'>$dirname</a>  No. of Downloads: $sumofdls<br>\n";// display the directory name and number of downloads in that directory
		$getsubdir = mysql_query("SELECT * FROM $subdirtbl WHERE idid='$did' ");
		while ($getsubdir = mysql_fetch_array($getsubdir)) {//now list the number of subdirectories in that directory
			extract($getsubdir);// convert field names into variables
			$sumofdlss = mysql_num_rows(mysql_query("SELECT dlid FROM $dltbl WHERE dlsdid='$sdid' "));// total number of downloads for the sub-dir
			echo "  Sub-Directory: <a href='$modules&did=$did&sdid=$sdid'>$subdirname</a>  No. of Downloads: $sumofdlss<br>\n";
		}
	echo "<br><br>\n";
	}

[LordShryku]

I think it's a variable naming thing. Your naming the SQL string, the query, the array the same thing. Try naming them different...

Of course, that's just a guess 😃

[helz]

i changed it to:

$getdir0 = "SELECT * FROM $dirtbl";
	echo $getdir0;
	$getdir1 = mysql_query($getdir0);// get info from db
	while ($getdir = mysql_fetch_array($getdir1)) {// output info from the db

still no luck 🙁

[LordShryku]

use

$getdir1 = mysql_query($getdir0) or die(mysql_error());

to see if there is a problem

[helz]

god darnit, its pointing to the wrong database 🙂

==edit==

found out it was pointing to a different sql connect file 😃

no errors now woo

[stolzyboy]

that's why i try cramming that down everyone's minds here to use the or die(mysql_error());
cuz it is normally a simple error that the mysql_error will catch
and you don't have to beat yourself up over it...

[LordShryku]

Yeah, that leaves us plenty of room to beat you up instead 😃

[helz]

well we should let stolzyboy create a thread on good coding practices and make it sticky 🙂

[stolzyboy]

Originally posted by helz
well we should let stolzyboy create a thread on good coding practices and make it sticky 🙂

well there is a code critique forum that would probably be best suited for that,
but that is what the whole forum is about...

I'll let you know in a couple months about good coding practices
and catching errors and error handling...

[LordShryku]

Of all the people to write on good coding.......stolzy? You sure? 😃

[stolzyboy]

Originally posted by LordShryku
Of all the people to write on good coding.......stolzy? You sure? 😃

Of course he's sure...

[helz]

i was hoping for a group effort 🙂
like stolzy with his: or dies
and lord with something
and me with my indentations

[stolzyboy]

like this

<?
switch ($coding)
{
     case stolzyboy:
          echo "dies";
     break;
     case LordShryku:
          echo "something from lord";
      break;
     case helz:
          echo "his indentations";
     break;
}
?>

[LordShryku]

Addition....

<? 
switch ($coding) 
{ 
     case stolzyboy: 
          echo "dies"; 
     break; 
     case LordShryku: 
          echo "something from lord"; 
      break; 
     case helz: 
          echo "his indentations"; 
     break; 
     default:
          echo "newbie code";
     break;
} 
?> 

I seem to be the "date" guy anymore. A lot of the question I've recently answered do with date formatting. So if anything, that's my specialty

[helz]

yep, hold on a minute just testing the echo""

echo "echo echo echo echo ";

yep it works

[stolzyboy]

yeah i've been doing a lot of date/calendar stuff for clients lately