PHP Cart Reading from DB toooo slow.

[somedudeppf]

I am new to php and recently inherited a very basic shopping cart where I work. My boss is not very bright and has no clue who set it up for him.

When displaying the orders it displays about 1 per second or slower.. very slow when you have about 10,000 orders sitting there to be done and you're seafching for one. Or if someone is on the phone and their order is at the bottom of the list.

From what I see in the code, it does a simple read from a mysql DB reading only the order#, name, and order status (which is just a check box) then it displays it on a website. Seems very basic to me. Although it is capable of doing a little more, this is all we have it doing.

Why is it so slow? I know it's not the server because I have a copy on my testing server here next to me and it's the same speed.

stumped,
Adam

[TheIceman5]

dunno, cant see any of the coding.

[weekender]

yeah, put some code up. important stuff would be connection to the database, fetching and outputting the data.

[somedudeppf]

<?
if ($View == "All") {
$ShowOrders = ShowOrders(FALSE);
} else {
$ShowOrders = ShowOrders(TRUE);
}
while ($line = mysql_fetch_array($ShowOrders, MYSQL_ASSOC)) {
set_time_limit(30);
echo "<table border=\"0\">\n";
echo " <tr>\n";
echo " <td width=\"50\"><a class=\"HoverLink\" href=OrderShow.php?OrderId=" . $line["OrderNumber"] . ">" . $line["OrderNumber"] ."</a></td>\n";
echo " <td width=\"70\"><div class=\"Plain\">" . ReturnOrderDate($line["OrderNumber"]) . "</div></td>\n";
echo " <td width=\"150\"><div class=\"Plain\">" . $line["Name"] ."</div></td>\n";

if ($line["PickedUp"] == 0) {
	echo "	<td width=\"70\"><input type=\"Checkbox\" name=\"PickedUp_CheckBox_" . $line["OrderNumber"] . "\" OnClick=__doPostBack('PickedUp_CheckBox_" . $line["OrderNumber"] . "','on')></td>\n";
} else {
	echo "	<td width=\"70\"><a id=\"PickedUpDateLink\" class=\"HoverLink\" onmouseover=\"window.status = 'Click here to reset this field.'; return true;\" OnClick=\"__doPostBackVerify('PickedUp_Link_" . $line["OrderNumber"] . "','off')\" onmouseout=\"window.status=''; return true;\">" . ParseDate($line["PickedUp"]) . "</a></td>\n";
}

echo	"	</tr>\n";
echo	"</table>\n";

}
?>

[drawmack]

that's a very nice html form, we need to see the code that's doing the db stuff if you want help with the db stuff.

[somedudeppf]

Sorry, I'm new 🙂

function ShowOrders($Active) {
if ($Active == TRUE) {
$MysqlQuery = "SELECT distinct OrderNumber, Name, Active, Paid, OrderFilled, OrderReady, PickedUp FROM Orders WHERE Active=1 ORDER BY OrderNumber desc";
$result = ExecuteQuery($MysqlQuery);
return $result;
} else {
$MysqlQuery = "SELECT distinct OrderNumber, Name, Active, Paid, OrderFilled, OrderReady, PickedUp FROM Orders ORDER BY OrderNumber desc";
$result = ExecuteQuery($MysqlQuery);
return $result;
}
}

function ShowOrder($OrderId) {
$MysqlQuery = "SELECT * FROM Orders WHERE OrderNumber=" . $OrderId;
$result = ExecuteQuery($MysqlQuery);
return $result;
}

[weekender]

can you show us the ExecuteQuery function definition?

cheers 😃

[somedudeppf]

here's a link to my test page, this is the one that is so slow. Hope this is what you were looking for.

http://www.auburn.edu/~white04/test/manager/Orders.php

and here's the function:

function ExecuteQuery($MysqlQuery) {
$MysqlInfo = MysqlInfo();
$link = mysql_connect($MysqlInfo[0], $MysqlInfo[1], $MysqlInfo[2])
or die("Could not connect");

mysql_select_db($MysqlInfo[3])
or die("Could not select database");

    // Performing SQL query
    $result = mysql_query($MysqlQuery)  
        or die("Query failed");

    // return array
    return $result;

    // Closing connection

mysql_close($link);
}
function ExecuteNonQuery($MysqlQuery) {
$MysqlInfo = MysqlInfo();
$link = mysql_connect($MysqlInfo[0], $MysqlInfo[1], $MysqlInfo[2])
or die("Could not connect");
mysql_select_db($MysqlInfo[3])
or die("Could not select database");

    // Performing SQL query
    mysql_query($MysqlQuery)
    or die("Query failed");

    $result = mysql_insert_id();

    // Closing connection
    mysql_close($link);
    return $result;

}

---

I just found a problem in some other code.. so if that link doesn't work, i'm sorry.

[somedudeppf]

ok, I just found something in the code. There was a second config file stuck inside of the code and it was reading from the wrong database. Now it is reading from my database and it is a lot faster.

But, it's still slower than I would expect.. is it slow to you?

http://www.auburn.edu/~white04/test/manager/Orders.php

thanks!