simple php loop and removing single , comma

[aron]

hi all, im inserting this php script into a javascript

<? while ($line1 = mysql_fetch_array($sql_result1, MYSQL_ASSOC)) { ?>"<? print $line1["url"] . ".jpg"; ?>",

                      <? }/* Free resultset */

mysql_free_result($sql_result1);?>

example of javascript

slideshowimages("property1.jpg","property12.jpg","property13.jpg","property14.jpg","property15.jpg","property16.jpg","property17.jpg","property18.jpg")

sojavascript with php script

slideshowimages(<? while ($line1 = mysql_fetch_array($sql_result1, MYSQL_ASSOC)) { ?>"<? print $line1["url"] . ".jpg"; ?>",

                      <? }/* Free resultset */

mysql_free_result($sql_result1);?>)

what it does is this
slideshowimages("property1.jpg","property12.jpg","property13.jpg","property14.jpg","property15.jpg","property16.jpg","property17.jpg","property18.jpg",)
notice the extra , comma at the ends of ...","property18.jpg",)
that is screwing up the javascript i need to not have it put the end comma on.

anyone able to help.

cheers.

[laserlight]

That is because your loop print the comma out for each row retrieved.

One way is to keep a running count of thw rows, and if the current row is the last row, you do not print the comma:

<?php
$row_num = mysql_num_rows($sql_result1);
$count = 1; //the first record
while ($line1 = mysql_fetch_array($sql_result1, MYSQL_ASSOC)) {
	echo '"' . $line1["url"] . '.jpg"';
	//print the comma unless it is the last record
	if ($count < $row_num) {
		echo ', ';
	}
	$count++;
}

[olaf]

Or use

implode(",", $array);

[aron]

There is a problem when it selects all the records from the database. it seems to miss the first one everytime.

this is select statement

$sql1 = "SELECT * FROM images WHERE listing_id = $property_id";
$sql_result1 = mysql_query($sql1,$connection) or die ("Could not connect to database 1");
$line1 = mysql_fetch_array($sql_result1);

this is the code (thanks to laserlight)

$row_num = mysql_num_rows($sql_result1);
$count = 1; //the first record
while ($line1 = mysql_fetch_array($sql_result1, MYSQL_ASSOC)) {
echo '"' . $line1["url"] . '.jpg"';
//print the comma unless it is the last record
if ($count < $row_num) {
echo ', ';
}
$count++;
}

but what happens is if there are 2 records inthe database it misses the first and prints the second

number of images whos listing_id = 2 is 2

2fgfgdfgdfg.jpg number 17

this one misses

fghfgfd435345.jpg number 16 (but its the first listed record in the database for listing_id 2)

and another example

number of images whos listing_id = 3 is 12

13101121876bl1066961410.jpg number 2 101121876cl1066961413.jpg number 3 101121876dl1066961418.jpg number 4 101121876el1066961424.jpg number 5 101121876fl1066961899.jpg number 6 101121876gl1066961905.jpg number 7 101121876hl1066961993.jpg number 8 101121876il1066961997.jpg number 9 101121876jl1066962002.jpg number 10 101121876kl1066962006.jpg number 11 101121876ml1066961428.jpg number 12 101121876al1066961405.jpg number 15

this ones misses

101121876al1066961405.jpg number 13 (but its the first listed record in the database for listing_id 3)

any ideas

[aron]

thanks