emailing multiple all users with $Email variable

[cybersounds]

Basically, I want to provide a button which upon clicking, will select all records in the table, and email them information based upon their email address stored in the same table. The following code yields the browser showing the button, and when I click it I get an error message for line 82 which points to my foreach statement (Invalid argument supplied for foreach() ). Anyone have any pointers for my foreach statement? Here's my code, and much appreciation for any help (I changed the tabs a bit in order to make this hopefully more legible):

<form action="<?php echo $PHP_SELF; ?>" method="post">

<?php

$db = @mysql_connect('localhost', 'user', 'pass');

if (!$db)
	{
	echo 'Error: Could not connect to database. Please try again later.<br /><br /><br /><br /><br /><br /><br />';
	exit;
	}

if(!$Submitbutton) 
	{ 
	?> 

	<table class="mainbodyformcell" valign="top" cellspacing="0" cellpadding="0">
	<tr>
	<td class="center">
	<input type="submit" value="Email" name="Submitbutton" class="button" />
	</td></tr></table>

	<?php 
	} 

if($Submitbutton)
	{
	mysql_select_db('esbsolu_esbcontact');

	$result = mysql_query("select * from contact");

	$num_results = mysql_num_rows($result);

	if (!$db)
		{
		echo 'Error: Could not connect to database. Please try again later.';
		exit;
		}

	if ($num_results == 0)
		{
		echo 'There are no records in your database. Please <a href="insert.php" class="rollmain">insert</a> a record into your database.';
		exit;
		}

        while($r = mysql_fetch_array($result)) 
               {     
    		$id=$r["id"]; 
            	$Company=$r["Company"];
    		$Name=$r["Name"]; 
    		$Address=$r["Address"]; 
    		$City=$r["City"]; 
    		$State=$r["State"]; 
    		$Zip=$r["Zip"];
            	$Country=$r["Country"];
    		$Phone=$r["Phone"];
    		$Fax=$r["Fax"];
    		$URL=$r["URL"];
    		$Email=$r["Email"]; 
    		$Service=$r["Service"];
    		$WebDesignList=$r["WebDesignList"]; 
    		$OtherMediaList=$r["OtherMediaList"];
    		$Balance=$r["Balance"];
            	$Comments = trim($r["Comments"]);

	foreach($r["Email"] as $Email) 
		{ 

                            $msg = "Name:\t$_POST[Name]\n";
		$msg .= "Email:\t$_POST[Email]\n";
		$msg .= "Phone:\t$_POST[Phone]\n\n";
		$msg .= "Service:\t$_POST[Service]\n\n";
		$msg .= "\t$_POST[WebDesignList]\n\n";
		$msg .= "\t$_POST[OtherMediaList]\n\n";
	$msg .= "Comments:\t$_POST[Comments]\n\n";

$msg .= "View Database: [url]http://www.esbsolutions.com\n\n[/url]";
$recipient = "$_POST[Email]";
$subject = "Mass-mailing";
$mailheaders = "From: Esbsolutions.com<> \n";
$mailheaders .= "Reply-To: [e-mail]\n\n";
@mail($recipient, $subject, $msg, $mailheaders);

	                mysql_query($query) or die(mysql_error());

		if(!$query)
		    {
    		    echo 'ERROR: emails unsuccessfull.<br /><br /><br /><br /><br /><br /><br />';
    		     }

		if($query)
    		     {
    		     echo 'Emails successfully sent.<br /><br /><br /><br /><br /><br /><br /><br /><br />';
    		      }
    		}	
	}

}

mysql_close($db);
?>

</form>

THANKS!!

[Pig]

Your loops are incorrect. You use 2 seperate loops, but give each of them only half the of the components they need.

this line:
while($r = mysql_fetch_array($result))
is the only loop you need. Just do everything in there.

Also, this should not be done:
{
$id=$r["id"];
$Company=$r["Company"];
$Name=$r["Name"];
$Address=$r["Address"];
$City=$r["City"];
$State=$r["State"];
$Zip=$r["Zip"];
$Country=$r["Country"];
$Phone=$r["Phone"];
$Fax=$r["Fax"];
$URL=$r["URL"];
$Email=$r["Email"];
$Service=$r["Service"];
$WebDesignList=$r["WebDesignList"];
$OtherMediaList=$r["OtherMediaList"];
$Balance=$r["Balance"];
$Comments = trim($r["Comments"]);
}
You never want to do anything in a loop unless you have to. It can create very expesive processes. Defining these variables, for no reason, and then reassigning them a moment later is not good.

What you want to do, is stick all that mail() shizzle in your while() loop, and use $r['var_name'] directly in your code instead of defining $var_name=$r['var_name'].

HTH

[cybersounds]

I made the following changes accordingly but now my mysqlordie tells me that 'Query was empty' (I had to leave the single quotes from around the variable names in the mail() section otherwise the strings weren't recognized):

	$result = mysql_query("select * from contact");

	$num_results = mysql_num_rows($result);

	if (!$db)
		{
		echo 'Error: Could not connect to database. Please try again later.';
		exit;
		}

	if ($num_results == 0)
		{
		echo 'There are no records in your database. Please <a href="insert.php" class="rollmain">insert</a> a record into your database.';
		exit;
		}

        while($r = mysql_fetch_array($result)) 
	        {     
			$msg .= "Name:\t$r[Name]\n";
			$msg .= "Email:\t$r[Email]\n";
			$msg .= "Phone:\t$r[Phone]\n\n";
			$msg .= "Service:\t$r[Service]\n\n";
			$msg .= "\t$r[WebDesignList]\n\n";
			$msg .= "\t$r[OtherMediaList]\n\n";
			$msg .= "Comments:\t$r[Comments]\n\n";
			$msg .= "View Database: [url]http://www.esbsolutions.com/authentication.php\n\n[/url]";
			$recipient = "$r[Email]"; 
			$subject = "Mass-mailing";
			$mailheaders = "From: Esbsolutions.com Datbase V.1.2 <> \n";
			$mailheaders .= "Reply-To: [email][e-mail][/email]\n\n";
			@mail($recipient, $subject, $msg, $mailheaders);

			mysql_query($query) or die(mysql_error());

			if(!$query)
		    		{
    			echo 'ERROR: emails unsuccessfull.<br /><br /><br /><br /><br /><br /><br />';
    			}

			if($query)
    			{
    			echo 'Emails successfully sent.<br /><br /><br /><br /><br /><br /><br /><br /><br />';
    			}
    		}

THANKS AGAIN!

[cybersounds]

OK, I've edited my code as follows and now it emails to the first email address in my talbe but none of the others. Why is this happening? THanks!!!!! PS-Ignore the repeating block of code in the mail() code, I don't know why this text box repeats that code automatically! :-(

<form action="<?php echo $PHP_SELF; ?>" method="post">

<?php

$db = @mysql_connect('localhost', 'esbsolu_esbsolu', 'armagita');

if (!$db)
	{
	echo 'Error: Could not connect to database. Please try again later.<br /><br /><br /><br /><br /><br /><br />';
	exit;
	}

if(!$Submitbutton) 
	{ 
	?> 

	<table class="mainbodyformcell" valign="top" cellspacing="0" cellpadding="0">
	<tr>
	<td class="center">
	<input type="submit" value="Email" name="Submitbutton" class="button" />
            </td></tr></table>
	<?php 
	} 

if($Submitbutton)
	{
	mysql_select_db('esbsolu_esbcontact');

	$result = mysql_query("select * from contact");

	$num_results = mysql_num_rows($result);

	if (!$db)
		{
		echo 'Error: Could not connect to database. Please try again later.';
		exit;
		}

	if ($num_results == 0)
		{
		echo 'There are no records in your database. Please <a href="insert.php" class="rollmain">insert</a> a record into your database.';
		exit;
		}

        while($r = mysql_fetch_array($result)) 
	{     
		$msg .= "Name:\t$r[Name]\n";
		$msg .= "Email:\t$r[Email]\n";
		$msg .= "Phone:\t$r[Phone]\n\n";
		$msg .= "Service:\t$r[Service]\n\n";
		$msg .= "\t$r[WebDesignList]\n\n";
		$msg .= "\t$r[OtherMediaList]\n\n";
		$msg .= "Comments:\t$r[Comments]\n\n";
$msg .= "View Database: [url]http://www.esbsolutions.com\n\n[/url]";
		$recipient = "$r[Email]";
		$subject = "Mass-mailing";
$mailheaders = "From: Esbsolutions.com Datbase V.1.2 <> \n";
		$mailheaders= "Reply-To: [email][e-mail][/email]\n\n";
	@mail($recipient, $subject, $msg, $mailheaders);

    		}

   		echo 'Emails successfully sent.<br />';

		}

mysql_close($db);
?>

<?php
}

else
{
?>
<?include("headerdb.php");?><br /><br />
You are not logged in.<br /><br />
<a href="authentication.php" class="rollmain">Log in</a> or return to the <a href="main.php" class="rollmain">main website.</a>
<?php
}
?>
</form>

[Pig]

echo mysql_num_rows and see what it says.

[Pig]

Also, please put the php bb tags ( [ php ] and [ /php ], but without the spaces) around your code when you post. It makes it much more readable.