trouble with syntax within function

danacton

Hello,

Sorry about the PHP format, but I thought this code would be easier to read in this example - by using the bold tags - which I could not do within the PHP tags...

I've been wrestling with this stupid little problem all night - so thought I would ask you guys for help....Please?

To quickly explain this mess - Just the function at the bottom is the problem.

I can take the code out from within this function and it will return the average for me, but why won't it return the average while within the function? Does it have to do with globals? I tried that and still could not make it work. The code below shows the function as I have tried to make it work (see the bold font) - with a simple test function directly below it.

Thanks ahead

Dan

[PHP
<?php

error_reporting (E_ERROR | E_WARNING |E_PARSE);

if ( $GET ['op'] == "add" ) { echo $GET ['number1'] ." + ". $GET ['number2'] ." = "; echo ($GET ['number1'] + $_GET ['number2']);
}

if ( $GET ['op'] == "sub" ) { echo $GET ['number1'] ." - ". $GET ['number2'] ." = "; echo ($GET ['number1'] - $_GET ['number2']);
}

if ( $GET ['op'] == "mul" ) { echo $GET ['number1'] ." ". $GET ['number2'] ." = "; echo ($GET ['number1'] $GET ['number2']);}

if ( $GET ['op'] == "div" ) { echo $GET ['number1'] ." / ". $GET ['number2'] ." = "; echo ($GET ['number1'] / $GET ['number2']);
}

//for($i= 0; $i < 10; $i++);
$addingArray[0] = $GET ['number1'];
$addingArray[1] = $GET ['number2'];
print(' ');

echo count($addingArray);
print(' ');
//echo rsort($addingArray);

function myAverage(){
print ( $GET ['number1'] + $GET ['number2']) / count($addingArray);
}
myAverage();

print(' ');
function say_hi() {
print "Hi there!";
}
say_hi();

?>
[/code]

EgoManiac

try putting a

global $addingArray;

inside (at the beginning) of your MyAverage() function.

danacton

I tried putting global in various places, but have not had any luck.
Here is the HTML code to complete the story...
Any other ideas out there.

So I still need help. As I state in the above post - most everything works except two problem areas I'm having. One with an array, and the other, a function.

How do I get an array to work with this form
I need to have an array return some data. (see bolded area)

return Max: Done
return Min: Done
return Count: Done
**** I cannot get the array (the way I have it set up) to do a sort. I need to accomplish this so I can return the 3 highest values, and then the 3 lowest values.

PLease help!
Thanks.

[PHP

<?php

error_reporting (E_ERROR | E_WARNING |E_PARSE);

if ( $GET ['op'] == "add" ) { echo $GET ['number1'] ." + ". $GET ['number2'] ." = "; echo "".($GET ['number1'] + $_GET ['number2']) ."";
}

if ( $GET ['op'] == "sub" ) { echo $GET ['number1'] ." - ". $GET ['number2'] ." = "; echo "". ($GET ['number1'] - $_GET ['number2'])."" ;
}

if ( $GET ['op'] == "mul" ) { echo $GET ['number1'] ." ". $GET ['number2'] ." = "; echo "".($GET ['number1'] $_GET ['number2'])."";
}

if ( $GET ['op'] == "div" ) { echo $GET ['number1'] ." / ". $GET ['number2'] ." = "; echo "". ($GET ['number1'] / $_GET ['number2'])."";
}

echo "You have entered ".count($addingArray)." values. ";
echo "This is the Highest Number: ". "". Max($addingArray). " ";
echo "This is the Lowest Number: ". "". Min($addingArray). " ";

//for($i= 0; $i < 10; $i++);
$addingArray[0] = $GET ['number1'];
$addingArray[1] = $GET ['number2'];

echo sort($addingArray) ." ";

function myAverage(){
print ( $GET ['number1'] + $GET ['number2']) / count($addingArray);
}
myAverage();

function say_hi() {
print "Hi there!"." ";
}
say_hi();
?>

[/code]

  <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01  

           Transitional//EN">
<html>
  <head>
    <title>Untitled Document</title>
      <meta http-equiv="Content-Type" content="text/html;      

       charset=iso-8859-1">
  </head>

<body>
<form method="get" action="basicAction.php">
     Enter Number <input type="text" name="number1"><br> 
     Enter Number <input type="text"  

     name="number2"><br><br>  

     <b>Choose the operation</b><br><br>
<input type="radio" name="op" value="add" checked>
    Addition<br> <input type="radio" name="op" value="sub">
    Subtraction<br> <input type="radio" name="op" value="mul">
    Multiplication<br> <input type="radio" name="op" value="div">
    Division<br> <input type="submit" name="Submit"
    value="Submit">
</form>

</body>
</html>

tekky

//for($i= 0; $i < 10; $i++);
$addingArray[0] = $_GET ['number1'];
$addingArray[1] = $_GET ['number2'];
sort($addingArray); //sort returns nothing... it only sorts (as do all other sort functions... try reading the online docs on functions you dont understand....
for($i=0;$i<count($addingArray);$i++) //loop to print the sorted array
{
     echo $addingArray[$i] ."<br>";
}

function myAverage($avgArray){ //use the passed array so you know you get the values... 
print ( $_GET ['number1'] + $_GET ['number2']) / count($avgArray); 
}
myAverage($addingArray); //pass the array

function say_hi() {
print "Hi there!"."<br>";
}
say_hi();
?>

try something like that....

BSTRhino

The 'global $addingArray' statement suggested before is an important line, so don't forget to put that in.

function myAverage(){ 
    global $addingArray;
    print ( $_GET ['number1'] + $_GET ['number2']) / count($addingArray); 
} 
myAverage();

Without the 'global $addingArray' line, count($addingArray) will always return zero, because $addingArray is not a local variable, it is a global one.

Also, if you are sorting numeric values, it's a good idea to specify this in sort()'s second parameter, which is only supported in PHP 4 upwards:

sort($addingArray, SORT_NUMERIC);

tekky

note: my method uses arguements to the function myAvg to bypass the need to worry about global or local variable scopes... that last post doesnt apply to my offered suggestion

danacton

Thanks guys - a lot.

I ended up using Tekky's method, since he explained it VERY CLEARLY for a newbie like me. Works perfectly!!! He also commented on how it works!

I was also told to avoid using Globals whenever possible (maybe good advice for beginners) - since they change the value of the variable in memory - some day I'll understand the importance of this. I know that "by value" only changes the value within the function, but don't really understand yet why one would be more useful than the other..

You guys have shown me how to use both -
Thanks