[Resolved] Where 's the error??

[Tomz]

Hi

I've written some php code that keeps on generating an error and I just don't see the problem.
Any of you care to have a look?

Error: Warning: Bad arguments to implode()

The values that are posted look like p1=50,23;p2=200... and so on.

$index = 0;

foreach ($_POST as $key => $value) {

   if (substr($key,0,1) == "p") {

   $prijzen[$index] = $value;
    $index++;
    }

  $prijzendb = implode('`',$prijzen);
}

// insert into database..

[Merve]

Always put spaces after the comma before the next argument. Also, implode() sometimes accepts its arguments in the inverse order. Try that and see if it works.

[Tomz]

Hey Merve,

thanks for your quick reply. Tried that both. (putting space after the comma and putting arguments in reverse order)
Same problem still.

What's funny is that I use this code in my script twice. I only get an error in one of them.

Below is the complete script, the first implode generates the error while the second implode gets executed without any problem:

The values that are posted to the second look like t1=text1;t2=text2... and so on

<?php

include ('connectdb.php');

$index = 0;

foreach ($_POST as $key => $value) {

if (substr($key, 0, 1) == "p") {

    $prijzen[$index] = $value;
    $index++;
}

$prijzendb = implode('`',  $prijzen);
}

// submit string to database
$query = "UPDATE riet_prijzen SET prijzen=\"$prijzendb\" WHERE id=1";
   	$result = mysql_query($query);
        if (!$result){
        	die ("Error performing query in riet_prijzen q1 | ". mysql_error() );}


$index = 0;

foreach ($_POST as $key => $value) {

if (substr($key, 0, 1) == "t") {

    $text[$index] = $value;
    $index++;
}

$textdb = implode('`', $text);
}


// submit string to database
$query = "UPDATE riet_prijzen SET text=\"$textdb\" WHERE ID=1";
	   	$result = mysql_query($query);
            if (!$result){
            	die ("Error performing query in riet_prijzen q2 | ". mysql_error() );}
?>

[Merve]

If you copy-pasted that code, there are now two spaces after the first argument in the first implode. What error were you getting? And what exactly does the script do?

[Tomz]

Yep, removed the second space already.

This script handles the input from a form which lets the user input text and prices.
I want to store them in one database row where the text goes in one field and the prices in another, seperated by a `.
That's why I need to implode them.

I am getting :Warning: Bad arguments to implode() in G:\FoxServ\www\rietveld\admin\functions\sub_prices.php on line 24

Although the values are indeed submitted tot the database correctly!

[Tomz]

Well, that's strange.

While trying something I inserted

    $prijzen[$index] = "";

directly before

$prijzendb = implode($prijzen, '`'); 

.
Now the error is gone.

[Merve]

That's strange. Does the code still work the way it's supposed to? What version of PHP are you using?

[Tomz]

yes, very weird. Code works perfectly! 😕

Php version 4.2.2

http://62.166.33.177/phpinfo.php

[Merve]

Originally posted by Tomz
yes, very weird. Code works perfectly! 😕

Php version 4.2.2

http://62.166.33.177/phpinfo.php

Well, I guess you should take it for what it is then.

[tekky]

judging by the statements you've made... I would say your if statement is never evaluating to TRUE to build your array.... implode() then errors becuase the variable isnt an array....

[LordShryku]

imploding with an unset array could cause this error. Imploding on an empty array wouldn't though. I'd suggest setting your array before your foreach statement...

$prijzen = array();

[Tomz]

I've done some ivestigating...
To LordShryku and Tekky; I guess you're both right 🙂

Tekky: There are some empty values submitted in the $prijzen array (like: prijzen[1]=20, prijzen[2]="", prijzen[3]=40....)
It seems as if that causes the error with implode().
This could be a plausible solution because I never got the error with the $text array. That might be because the $text array never contains empty values....(?)

Lord: I've tried setting the array like you said and that solved the problem completely!

Thanks all! 🙂