Scription help

[Chrono121]

I'm working on a script, and it's pretty much designed to take in the fallowing variables, output errors if some of the fields are blank and also save it to a file that's named after $user

WHAT's wronge Please

whatever.php

• <!--title-->
  <font size="3" face="arial"><p>
  ShowCase Signup:
  </p></font>
  <!--/title-->
  <form action="scripts/showcase/showcase.php" method=post>
  <table border=0 cellpadding=0 cellspacing=0 width="100%" class="default">
  <tr>
  <td width=120>
  User:
  </td>
  <td nowrap>
  <input name=user maxlength=25 size=23>
  </td>
  </tr>

  		  <tr>
  		  		 <td width=120>
  		  		 Password:
  		  		 </td>
  				 <td nowrap>
  		  		 <input type=password name=password maxlength=25 size=23>
  		  		 </td>
  		  </tr>
  
  		  <tr>
  		  		 <td width=120>
  		  		 Email:
  		  		 </td>
  				 <td nowrap>
  		  		 <input name=email maxlength=25 size=23>
  		  		 </td>
  		  </tr>
  
  		  <tr>
  		  		 <td width=120>
  		  		 Homepage:
  		  		 </td>
  				 <td nowrap>
  		  		 <input name=homepage maxlength=25 size=23>
  		  		 </td>
  		  </tr>
  
  		  <tr>
  		  		 <td width=120>
  		  		 Games name:
  		  		 </td>
  				 <td nowrap>
  		  		 <input name=gamename maxlength=25 size=23>
  		  		 </td>
  		  </tr>
  
  		  <tr>
  		  		 <td width=120>
  		  		 Demo URL:
  		  		 </td>
  				 <td nowrap>
  		  		 <input name=gamedemo maxlength=25 size=23>
  		  		 </td>
  		  </tr>
  
  		  <tr>
  		  		 <td height=25 colspan=2></td>
  		  </tr>
  
  		  <tr>
  		  		 <td width=120>
  		  		 Screenshot 1:
  		  		 </td>
  				 <td nowrap>
  		  		 <input name=screenshot1 maxlength=40 size=23>
  		  		 </td>
  		  </tr>
  
  		  <tr>
  		  		 <td width=120>
  		  		 Screenshot 2:
  		  		 </td>
  				 <td nowrap>
  		  		 <input name=screenshot2 maxlength=40 size=23>
  		  		 </td>
  		  </tr>
  
  		  <tr>
  		  		 <td width=120>
  		  		 Screenshot 3:
  		  		 </td>
  				 <td nowrap>
  		  		 <input name=screenshot3 maxlength=40 size=23>
  		  		 </td>
  		  </tr>
  
  		  <tr>
  		  		 <td width=120>
  		  		 Screenshot 4:
  		  		 </td>
  				 <td nowrap>
  		  		 <input name=screenshot4 maxlength=40 size=23>
  		  		 </td>
  		  </tr>
  
  		  <tr>
  		  		 <td width=120>
  		  		 Screenshot 5:
  		  		 </td>
  				 <td nowrap>
  		  		 <input name=screenshot5 maxlength=40 size=23>
  		  		 </td>
  		  </tr>
  
  		  <tr>
  		  		 <td width=120>
  		  		 Screenshot 6:
  		  		 </td>
  				 <td nowrap>
  		  		 <input name=screenshot6 maxlength=40 size=23>
  		  		 </td>
  		  </tr>
  
  		  </table>
  		  <br>
  
  		  <table border=0 cellpadding=0 cellspacing=0 width="100%" class="default">
  
  		  <tr>
  		  	  <td>
  			  Story:<br>
  		  	  <textarea cols=30 name=story rows=5>N/A</textarea>
  		  	  </td>
  		  </tr>
  
  		  <tr>
  		  	  <td>
  			  Description:<br>
  		  	  <textarea cols=30 name=description rows=5>Please give a brief description about your game</textarea>
  		  	  </td>
  		  </tr>
  
  		  <tr>
  		  	  <td>
  			  <input type=submit value="Send">
  		  	  <input type=reset value=Reset name="reset">
  		  	  </td>
  		  </tr>
  
  		  <table>
  		  </form>
  
  		  </p>

scripts/showcase/showcase.php is below

• <?php

  $error=0;
  ####################Error Messages##############################
  if($user=="")
  {
  $errorMes1="provide your user name";
  $error=1;
  }

  if($password=="")
  {
  $errorMes2="provide your password";
  $error=1;
  }

  if($email=="")
  {
  if (!eregi("^.+@.+\..+$", $email))
  {
  $errorMes3="provide your valid email address";
  $error=1;
  }
  else
  {
  $errorMes3="provide your email address";
  $error=1;
  }
  }

  if($gamename=="")
  {
  $errorMes4="provide your games name";
  $error=1;
  }

  if($gamedemo=="")
  {
  $errorMes5="provide your demo's URL";
  $error=1;
  }

  if($screenshot1==""
  and $screenshot2==""
  and $screenshot3==""
  and $screenshot4==""
  and $screenshot5==""
  and $screenshot6=="")
  {
  $errorMes6="Provide us with at least one screenshot";
  $error=1;
  }

  if($description=="")
  {
  $errorMes7="fill out a description for your game";
  $error=1;
  }
  ###################/Error Messages##############################

  #Error adding your game to the showcase
  if ($error==1)
  {
  echo ("<head>
  <title>Zelda Evolution // ShowCase Addition</title>
  </head>
  <body>
  <?php include "../../format_top.php"; ?>
  <br>
  Error adding to the ShowCase
  <br>
  <br>
  Before you continue you must:
  <br>
  <br>
  $errorMes1<br>
  $errorMes2<br>
  $errorMes3<br>
  $errorMes4<br>
  $errorMes5<br>
  $errorMes6<br>
  $errorMes7<br>
  <?php include "../../format_top.php"; ?>");
  }

  ?>

[tekky]

put that in PHP tags so its hilited.... BBcode php tags that is...

 [/ PHP]

[dta]

you might wnat to revise your code in the form-handler php page.. its pretty hard to debug as-is.

this is a little 'cleaner' and should be a little more simple:

<?php

$valid=true;
$error="";
####################Error Messages##############################
if($user==""){
	$error.="provide your user name<br>\n";
	$valid=false;
}

if($password==""){
	$error.="provide your password<br>\n";
	$valid=false;
}

if($email!=""){
	if (!eregi("^.+@.+\\..+$", $email)){
		$error.="provide your valid email address<br>\n";
		$valid=false;
	}else{
		$error.="provide your email address<br>\n";
		$valid=false;
	}
}

if($gamename==""){
	$error.="provide your games name<br>\n";
	$valid=false;
}

if($gamedemo==""){
	$error.="provide your demo's URL<br>\n";
	$valid=false;
}

if($screenshot1==""
&& $screenshot2==""
&& $screenshot3==""
&& $screenshot4==""
&& $screenshot5==""
&& $screenshot6==""){
	$error.="Provide us with at least one screenshot<br>\n";
	$valid=false;
}

if($description==""){
	$error.="fill out a description for your game<br>\n";
	$valid=false;
}
###################/Error Messages##############################

#Error adding your game to the showcase
if (!$valid){
	echo "<head>
	<title>Zelda Evolution // ShowCase Addition</title>
	</head>
	<body>";

include "../../format_top.php";

echo "
<br>
Error adding to the ShowCase
<br>
<br>
Before you continue you must:
<br>
<br>
$error";

include "../../format_top.php";
}else{
	echo "everything checks out";
}


?>

[Chrono121]

sorry, i wasn't exactly sure by what he meant.. but it's a bit obvious now..