Calculate Number Of Weekdays

Tracer

Err.... I have this code...and I thought it worked (It works for Jan, Feb, March But not APRIL?) ...Can someone please look closely and point out my mistake....

//Loop through PHP Datestamps for # weekdays
$workdays=0;  //sets the count to zero
$testdate=$begindate;   //set the test date to the first date
while($testdate <= $enddate)   //begin the while loop
  {
    if (date("D", $testdate)=='Mon') //Check for mondays
      {$workdays++;}
    if (date("D", $testdate)=='Tue') //Check for tuesdays
      {$workdays++;}
    if (date("D", $testdate)=='Wed') //Check for wednesdays
      {$workdays++;}
    if (date("D", $testdate)=='Thu') //Check for thursdays
      {$workdays++;}
    if (date("D", $testdate)=='Fri') //Check for fridays
      {$workdays++;}
    $testdate=($testdate+86400);
  }

bad76

Hi,
I'm sorry, but your code give me:

23 in Jan, 20 in Feb, 21 in March and 22 in APRIL (2003...)
And a rigth 86 from 1 jan to 30 apr.

All work fine.

 
<?php
$workdays=0; 
$testdate=mktime(0,0,0,4,1,2003);
$enddate=mktime(0,0,0,5,1,2003);
while($testdate < $enddate)   //begin the while loop 
  { 
    if (date("D", $testdate)=='Mon') //Check for mondays 
      {$workdays++;} 
    if (date("D", $testdate)=='Tue') //Check for tuesdays 
      {$workdays++;} 
    if (date("D", $testdate)=='Wed') //Check for wednesdays 
      {$workdays++;} 
    if (date("D", $testdate)=='Thu') //Check for thursdays 
      {$workdays++;} 
    if (date("D", $testdate)=='Fri') //Check for fridays 
      {$workdays++;} 
    $testdate=($testdate+86400); 
  }
echo $workdays;
?>

Tracer

Maybe it's the code that generates the first anmd last days of the months?

//Determine the first day of the month
$first_timestamp=mktime(0, 0, 0, $period, 1, $year);
$first_day_month=date("z",$first_timestamp);
$first_rx30_day=($first_day_month+1);
// echo "First PHP day of month value: $first_day_month <br>";  //REMOVE FOR PRODUCTION
// echo "First Rx30 of month value: $first_rx30_day <br>";  //REMOVE FOR PRODUCTION


//Determine the last day of the month
$last_timestamp = mktime(0, 0, 0, $period);
$last_day_month=date("t",$last_timestamp);
$last_rx30_day=($first_rx30_day+$last_day_month-1);
$end_timestamp= mktime(0, 0, 0, $period, $last_day_month, $year);
// echo "Number days in month value: $last_day_month <br>";  //REMOVE FOR PRODUCTION
// echo "Last rx30 day of month value: $last_rx30_day <br>";  //REMOVE FOR PRODUCTION

//Define the end and begin dates
$begindate=$first_timestamp;
$enddate=$end_timestamp;

//Loop through PHP Datestamps for # weekdays
$workdays=0;  //sets the count to zero
$testdate=$begindate;   //set the test date to the first date
while($testdate <= $enddate)   //begin the while loop
  {
    if (date("D", $testdate)=='Mon') //Check for mondays
      {$workdays++;}
    if (date("D", $testdate)=='Tue') //Check for tuesdays
      {$workdays++;}
    if (date("D", $testdate)=='Wed') //Check for wednesdays
      {$workdays++;}
    if (date("D", $testdate)=='Thu') //Check for thursdays
      {$workdays++;}
    if (date("D", $testdate)=='Fri') //Check for fridays
      {$workdays++;}
    $testdate=($testdate+86400);
  }

bad76

The only one I look is this line:

$last_timestamp = mktime(0, 0, 0, $period);

You miss the year and day.
Maybe this is your bug's source...

Tracer

$period is the moth (1-12 format)

That line of code is determining the last day of the $period (month) in PHP parsable format..... I can't fill out the day argument because It is yet unknown....

bad76

Try with $last_timestamp = mktime(0, 0, 0, $period,1,$year);

I don't know if mktime(0, 0, 0, $period) is wrong but surely mktime(0, 0, 0, $period,1,$year) work better.

And surely your way give a wrong february... (28/29 days are in year, not in month!)

I hope this helps you...

(and putting a day DON'T influence date("t") function...)

Tracer

Thanks For your help...The solution was actaully sort of stupid...I am adding the seconds to work through the days...and I was nut beggining at 0:00 hours GMT.....So I was missing the last day sometimes...Fixed by changing to

$end_timestamp= mktime(24, 0, 0, $period, $last_day_month, $year, -1);

to ensure I catch all the hours of that "last day"

Pilly

I got to ask...

I typed in the below from what is above and got 23 for january 2004, but when i look on my trusty wall planner its 22.
Am i missing something here?

<?
//Determine the first day of the month
$first_timestamp=mktime(0, 0, 0, $period, 1, $year);
$first_day_month=date("z",$first_timestamp);
$first_rx30_day=($first_day_month+1);
echo "First Timestamp $first_timestamp ";
echo "First PHP day of month value: $first_day_month "; //REMOVE FOR PRODUCTION
echo "First Rx30 of month value: $first_rx30_day "; //REMOVE FOR PRODUCTION

//Determine the last day of the month
$last_timestamp = mktime(0, 0, 0, $period);
$last_day_month=date("t",$last_timestamp);
$last_rx30_day=($first_rx30_day+$last_day_month-1);
//$end_timestamp= mktime(0, 0, 0, $period, $last_day_month, $year);
$end_timestamp= mktime(24, 0, 0, $period, $last_day_month, $year, -1);

echo "Number days in month value: $last_day_month "; //REMOVE FOR PRODUCTION
echo "Last rx30 day of month value: $last_rx30_day "; //REMOVE FOR PRODUCTION

//Define the end and begin dates
$begindate=$first_timestamp;
$enddate=$end_timestamp;

//Loop through PHP Datestamps for # weekdays
$workdays=0; //sets the count to zero
$testdate=$begindate; //set the test date to the first date
while($testdate <= $enddate) //begin the while loop
{
if (date("D", $testdate)=='Mon') //Check for mondays
{$workdays++;}
if (date("D", $testdate)=='Tue') //Check for tuesdays
{$workdays++;}
if (date("D", $testdate)=='Wed') //Check for wednesdays
{$workdays++;}
if (date("D", $testdate)=='Thu') //Check for thursdays
{$workdays++;}
if (date("D", $testdate)=='Fri') //Check for fridays
{$workdays++;}
$testdate=($testdate+86400);
}
echo "Weekdays in month = $workdays";

Can someone tell me whats wrong with this?