[Resolved] Trouble updating info in table

[browny]

Ok this is my query in PHP

		$result=mysql_query("UPDATE site_news SET title=$title, summary=$summary, news=$extended, active=$active WHERE nid=$nid", $link_id);

. It doesn't work so I tried phpmyadmin and got
UPDATE site_news SET title="test v2", summary="$summary", news="$extended", active="y" WHERE nid=32;
to work, but when placed into php it doesn't. I've tried changing the quotes, removing them escaping them and nothing works.

[bastien]

text values require single quotes around the value to be entered properly, numeric entries don't

so:

$result=mysql_query("UPDATE site_news SET title='$title', summary='$summary', news='$extended', active='$active' WHERE nid=$nid", $link_id);

hth

[browny]

Didn't work, I've been trying this for days, even my friends can't figure out whats wrong. The code is called from within an if statement and the if statement is working.

	if ($submit == 1)
	{
		$result=mysql_query("UPDATE site_news SET title='$title', summary='$summary', news='$extended', active='$active' WHERE nid=$nid", $link_id);

	echo (" your news item has been updated");
}

the echo statement is being called, but the data just isn't being updated.

[bastien]

try adding this to the query if you are sure it is being fired:

$result=mysql_query("UPDATE site_news SET title='$title', summary='$summary', news='$extended', active='$active' WHERE nid=$nid", $link_id) or die ("Can't do query because ".mysql_error()); 

this should print out an error to tell you what maybe wrong

hth

[browny]

Ok I get an error, now just to find the error,
😕 did that make sense?

Can't do query because You have an error in your SQL syntax near '' at line 1

[bastien]

okay so some value is not being set...can you change it to this?

$sql="UPDATE site_news SET title='$title', summary='$summary', news='$extended', active='$active' WHERE nid=$nid";

echo $sql;  //what does this look like?

$result=mysql_query($sql, $link_id) or die ("Can't do query because ".mysql_error()); 

then we can see wha is missing in the sql statement

[browny]

UPDATE site_news SET title='test v2dafasf', summary='$summaryfssaf', news='$extendedasfasfasf', active='y' WHERE nid=Can't do query because You have an error in your SQL syntax near '' at line 1

looks like $nid isn't being passed correctly,
I've just included an extra echo and it looks like this is no longer a DB problem.

I am passing $nid through the address, is looks like
news_edit.php?submit=1,nid=32,

ahh should use &

Thanks bastien its now sorted,