[Resolved] ascii mail adress to html tag

[wilku]

I copied such code as below from a book but it doesn't seem to work(I checked, doublechecked and triplechecked if I copied it right):

$akapity[$i] = preg_replace('/[^@\s]+@([-a-z0-9]+\.)+[a-z]{2,}/i','<a href="mailto:$1">$1</a>',$akapity[$i]);

When the input is:
"To jest mój mail [e-mail] i na niego mo¿na pisaæ"
the output is:
"To jest mój mail <a href="mailto:blahblah.">blahblah.</a> i na niego mo¿na pisaæ"
I tried to understand regular, expressions but it just gives me a headache. I tried to put ^ after first / and $ before second / but that way it doesn't do nothing to the input text - the output remains the same as input.
Please help.

[paulnaj]

Jen Dobry.

It was possibly a typo in the book - there are often many.

You want the whole address, but this regex is only picking out the part between the '@' sign and '.xxx' of the suffix.

It all depends on where you put the parenthesis in a regex, as to what gets returned.

I've re-positioned the parens '(' and ')' to inlude the whole mail address.

$akapity[$i] = preg_replace('/([^@s]+@[-a-z0-9]+.+[a-z]{2,})/i','<a href="mailto:$1">$1</a>',$akapity[$i]);

[wilku]

The final version (using the above written solution wasn't enough but it made the final solution possible - thanks) looks like this:

		$akapity[$i] = preg_replace('/([^@\s]+@[-a-z0-9]+.+(pl|com|net|edu|org|gov|mil|biz|pro|info|arpa|aero|coop|name|museum))/i','<a href="mailto:$1">$1</a>',$akapity[$i]);

I give up on this stage: sorry for those from other countries (adresses not ending with .pl or other not national suffixes)