[Resolved] Problem with post forum to self

[Sliver]

Plz tell me whats wrong with this code. I need the posted values if the forum is posted. Standard i would like the values 1.

$currentCity=1;
$maxUnits=1;
$fuelPrice=1;
if (isset($_POST['submit'])) 
{	
	$currentCity=$_POST['currentCity'] + 1;
	$maxUnits=$_POST['maxUnits'];
	$fuelPrice=$_POST['fuelPrice'];
}	

<form ACTION="<?php echo $PHP_SELF?>"  method="post" name"current">
<td>Current City: <select name="currentCity">
     <?
     while ($tellerCity < $num_rowsCity)
     {	
	$city=mysql_result($resultCity, $tellerCity, "name");
				print"<option value=\"$tellerCity\" name=\"currentCity\">$city\n";
	$tellerCity++;
     }
     $tellerCity=0;
     ?>
</select>
</td>
<td>
	Max units: <input type="text" name="maxUnits" width="40"  value="<? print "$maxUnits" ?>">
</td>
<td>Fuel price: <input type="text" name="fuelPrice" width="50" value="<? print "$fuelPrice" ?>"> $
</td>
<td><input type="submit" value="Go">
</td>
</form>

[bretticus]

Well looking at your form for 2 seconds, I see no name attribute with your HTML:

<input type="submit" value="Go">

Yet, in your PHP code you look for $_POST['submit'].

Should be able to just change your HTML a bit:

<input type="submit" name="submit" value="Go">

FYI - I see a lot of people using isset with super globals or arrays. I have always just tested for a value in the array.

I would have written:

if ($_POST['submit']) 
{     

    //...do stuff
}

Can someone tell me if there is any advantage in using isset here?

[LordShryku]

Newer versions of PHP will throw an "Undefined Variable" notice when you don't use isset()

On another note, I usually name the submit buttons something other than submit. I've only seen it cause problems in one occurance so far (Javascript auto-submitting), but it doesn't hurt to get in the habit

[bretticus]

Right, as a professional Web developer, I know it's not good practise to use 'submit' as the name and usually never do it myself (I learned long ago about the JavaScript factor). I answer these questions and try not to change much of the scriptor's code.

Thanks for the tip on isset(). I did not know that. That may come in handy somday when a sys admin upgardes PHP and my scripts suddenly don't work. Now I'll know why! 😃 I don't script much in PHP these days. Wish I could use it more.

[Sliver]

Thx, it works 🙂